From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECC5C433EF for ; Wed, 20 Apr 2022 13:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379073AbiDTN25 convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2022 09:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379036AbiDTN2l (ORCPT ); Wed, 20 Apr 2022 09:28:41 -0400 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D322C42A0C; Wed, 20 Apr 2022 06:25:54 -0700 (PDT) Received: by mail-qt1-f170.google.com with SMTP id fu34so913641qtb.8; Wed, 20 Apr 2022 06:25:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rFIpc07kdcdErSG52Vnbbh7AXlY7+Cv1PmRK4le+8hE=; b=qg+WFdkx4IbdGAhs6Qg8ioPAL7HPsKaHU9gHRJX4SoGOKv3t0XJrr6VSrjoyezTaLX cEAfNbtVAWjOkGXTB0BGTDKdf6ph1+vJtTQSqVqwpi+tfGtAv/CHct/aaAeVDgNCdj5L zGwf0cIgTKADFvc0LSXaAQvaT7ZrzGOZNmIgOFEvjxaO7cqN17QfpHkrGB+KAg0eBXve 9MHe6YV611CU5lYPvMpp1tBHwojtqR7Vje6CDdNoL7WaKZV1x3Tns3kgzfRijuvtoX1g UejEVI9pGaRGJ1Hl/k6HPPMRjRJbQbZFa8oYuwqe7gDWcMPJXoz/EJWerv9ExzwWAoZM azLA== X-Gm-Message-State: AOAM531cEGJVvRDu8jIqDbAABj+O2E6mBlsKPTLQqsx7QJSu0QoIt8Fm wWvfgoF+KurBQNisLxOJ4/31c3mQ2+EUBg== X-Google-Smtp-Source: ABdhPJy1h9FAARtdksCNxxWNLmD6QSb2LbPLHU2aqWwqhgHDmK+7y/M0BDYaDsymgIgngtXhwDIaKg== X-Received: by 2002:ac8:5f07:0:b0:2e1:d695:d857 with SMTP id x7-20020ac85f07000000b002e1d695d857mr13815421qta.40.1650461153730; Wed, 20 Apr 2022 06:25:53 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id n11-20020a05622a11cb00b002f344f11849sm293030qtk.71.2022.04.20.06.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 06:25:52 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id f38so2841486ybi.3; Wed, 20 Apr 2022 06:25:52 -0700 (PDT) X-Received: by 2002:a05:6902:724:b0:644:c37b:4e21 with SMTP id l4-20020a056902072400b00644c37b4e21mr19809816ybt.6.1650461152378; Wed, 20 Apr 2022 06:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20220414122250.158113-1-clement.leger@bootlin.com> <20220414122250.158113-5-clement.leger@bootlin.com> In-Reply-To: <20220414122250.158113-5-clement.leger@bootlin.com> From: Geert Uytterhoeven Date: Wed, 20 Apr 2022 15:25:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next 04/12] net: pcs: add Renesas MII converter driver To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Heiner Kallweit , Russell King , Thomas Petazzoni , Herve Codina , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Milan Stevanovic , Jimmy Lalande , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , netdev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clément, Thanks for your patch! Only cosmetic comments from me, as I'm not too familiar with MII. On Thu, Apr 14, 2022 at 2:24 PM Clément Léger wrote: > Add PCS driver for the MII converter that is present on Renesas RZ/N1 Add a ... on the ... > SoC. This MII converter is reponsible of converting MII to RMII/RGMII responsible for > or act as a MII passtrough. Exposing it as a PCS allows to reuse it pass-through > in both the switch driver and the stmmac driver. Currently, this driver > only allows the PCS to be used by the dual Cortex-A7 subsystem since > the register locking system is not used. > > Signed-off-by: Clément Léger > --- a/drivers/net/pcs/Kconfig > +++ b/drivers/net/pcs/Kconfig > @@ -18,4 +18,11 @@ config PCS_LYNX > This module provides helpers to phylink for managing the Lynx PCS > which is part of the Layerscape and QorIQ Ethernet SERDES. > > +config PCS_RZN1_MIIC > + tristate "Renesas RZN1 MII converter" RZ/N1 > + help > + This module provides a driver for the MII converter that is available > + on RZN1 SoC. This PCS convert MII to RMII/RGMII or can be in RZ/N1 > + passthrough mode for MII. > + > endmenu Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds