All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kbingham@kernel.org>
Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions
Date: Tue, 20 Feb 2018 14:58:17 +0100	[thread overview]
Message-ID: <CAMuHMdXeLXTnUDwxjkGsaeiHvdTZdc-XzE2+2bgC394S6RyxdQ@mail.gmail.com> (raw)
In-Reply-To: <1518696091-23561-2-git-send-email-ulrich.hecht+renesas@gmail.com>

Hi Uli,

On Thu, Feb 15, 2018 at 1:01 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> This patch adds VIN4 and VIN5 pins, groups and functions for the
> R8A7796 SoC.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

However, I guess you can use union vin_data and VIN_DATA_PIN_GROUP() to
reduce duplication, like on R-Car Gen2?

Would there be a use case for vin4_data4 and vin5_data4, or is that
mode only supported on R-Car H2?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2018-02-20 13:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 12:01 [PATCH 0/4] r8a779{5,6,95} VIN and DU pin control tables Ulrich Hecht
2018-02-15 12:01 ` [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions Ulrich Hecht
2018-02-20 13:58   ` Geert Uytterhoeven [this message]
2018-02-26  9:02     ` Ulrich Hecht
2018-02-26  9:21       ` Geert Uytterhoeven
2018-02-26 10:18         ` Geert Uytterhoeven
2018-03-09 12:33           ` Geert Uytterhoeven
2018-03-09 21:58             ` Niklas Söderlund
2018-03-09 22:24               ` Geert Uytterhoeven
2018-03-09 23:44                 ` Niklas Söderlund
2018-03-19 10:23                 ` Geert Uytterhoeven
2018-02-15 12:01 ` [PATCH 2/4] pinctrl: sh-pfc: r8a7795: " Ulrich Hecht
2018-02-20 13:58   ` Geert Uytterhoeven
2018-02-15 12:01 ` [PATCH 3/4] pinctrl: sh-pfc: r8a77995: Add VIN4 pins, groups and function Ulrich Hecht
2018-02-20 14:09   ` Geert Uytterhoeven
2018-02-15 12:01 ` [PATCH 4/4] pinctrl: sh-pfc: r8a77995: Add DU " Ulrich Hecht
2018-02-15 12:38   ` Kieran Bingham
2018-02-20 15:21     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXeLXTnUDwxjkGsaeiHvdTZdc-XzE2+2bgC394S6RyxdQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=kbingham@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=ulrich.hecht+renesas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.