From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673Ab2D0FRx (ORCPT ); Fri, 27 Apr 2012 01:17:53 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:51460 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112Ab2D0FRw convert rfc822-to-8bit (ORCPT ); Fri, 27 Apr 2012 01:17:52 -0400 MIME-Version: 1.0 In-Reply-To: <20120426153241.6d4762a2.akpm@linux-foundation.org> References: <20120425112623.26927.43229.stgit@zurg> <20120425112629.26927.21609.stgit@zurg> <20120426153241.6d4762a2.akpm@linux-foundation.org> Date: Fri, 27 Apr 2012 07:17:50 +0200 X-Google-Sender-Auth: MjKUYtkQJHUuNWuIs6mjKKo6uf0 Message-ID: Subject: Re: [PATCH 2/4] bug: completely remove code of disabled VM_BUG_ON() From: Geert Uytterhoeven To: Andrew Morton Cc: Konstantin Khlebnikov , Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2012 at 00:32, Andrew Morton wrote: > On Wed, 25 Apr 2012 16:40:32 +0200 > Geert Uytterhoeven wrote: > >> On Wed, Apr 25, 2012 at 13:26, Konstantin Khlebnikov >> wrote: >> > Even if CONFIG_DEBUG_VM=n gcc genereates code for some VM_BUG_ON() >> >> That's because of the side effects of the expression >> >> https://lkml.org/lkml/2012/4/25/146 >> >> But IRIC, we do want them here? >> > > AFAICT (lkml.org appears to be having a meltdown), you've gone and > linked to this very thread. > > Please try again, this time avoiding hyperlinks ;) Yeah, I noticed after the fact. I wanted to look up the definition of unused_expression(), which obviously wasn't in my tree yet ;-) Still, I think people started relyong on the side effects, didn't they? Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds