From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933280AbcLUHxr (ORCPT ); Wed, 21 Dec 2016 02:53:47 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34662 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755902AbcLUHxp (ORCPT ); Wed, 21 Dec 2016 02:53:45 -0500 MIME-Version: 1.0 In-Reply-To: <585A2D40.9000606@samsung.com> References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <585A2D40.9000606@samsung.com> From: Baolin Wang Date: Wed, 21 Dec 2016 15:53:44 +0800 Message-ID: Subject: Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* To: Chanwoo Choi Cc: myungjoo.ham@samsung.com, Chen-Yu Tsai , Kishon , =?UTF-8?Q?Heiko_St=C3=BCbner?= , LKML , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Linaro Kernel Mailman List , Mark Brown , NeilBrown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBL7rpj1012556 Hi, On 21 December 2016 at 15:20, Chanwoo Choi wrote: > Hi, > > On 2016년 12월 21일 15:10, Baolin Wang wrote: >> Current there is both "EXTCON_USB" and "EXTCON_CHG_USB_SDP" which >> both seem to suggest a standard downstream port. But there is no >> documentation describing how these relate. >> >> Thus add documentation to describe EXTCON_CHG_USB_SDP should always >> appear together with EXTCON_USB, and EXTCON_CHG_USB_ACA would normally >> appear with EXTCON_USB_HOST. >> >> Signed-off-by: Baolin Wang >> --- >> include/linux/extcon.h | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index b871c0c..6498b05 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -46,7 +46,14 @@ >> #define EXTCON_USB 1 >> #define EXTCON_USB_HOST 2 >> >> -/* Charging external connector */ >> +/* >> + * Charging external connector >> + * >> + * When one SDP charger connector was reported, we should also report >> + * the USB connector, which means EXTCON_CHG_USB_SDP should always >> + * appear together with EXTCON_USB. The same as ACA charger connector, >> + * EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. >> + */ > > Looks good to me. > But, you use the different word for ACA as following: > I think that 'would normally' is proper in descritpion. Okay, I will change to 'would normally' in next version patch. Thanks. > > - commit msg : EXTCON_CHG_USB_ACA would normally appear with EXTCON_USB_HOST. > - description: EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. > >> #define EXTCON_CHG_USB_SDP 5 /* Standard Downstream Port */ >> #define EXTCON_CHG_USB_DCP 6 /* Dedicated Charging Port */ >> #define EXTCON_CHG_USB_CDP 7 /* Charging Downstream Port */ >> > > -- > Regards, > Chanwoo Choi -- Baolin.wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: baolin.wang@linaro.org (Baolin Wang) Date: Wed, 21 Dec 2016 15:53:44 +0800 Subject: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* In-Reply-To: <585A2D40.9000606@samsung.com> References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <585A2D40.9000606@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 21 December 2016 at 15:20, Chanwoo Choi wrote: > Hi, > > On 2016? 12? 21? 15:10, Baolin Wang wrote: >> Current there is both "EXTCON_USB" and "EXTCON_CHG_USB_SDP" which >> both seem to suggest a standard downstream port. But there is no >> documentation describing how these relate. >> >> Thus add documentation to describe EXTCON_CHG_USB_SDP should always >> appear together with EXTCON_USB, and EXTCON_CHG_USB_ACA would normally >> appear with EXTCON_USB_HOST. >> >> Signed-off-by: Baolin Wang >> --- >> include/linux/extcon.h | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index b871c0c..6498b05 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -46,7 +46,14 @@ >> #define EXTCON_USB 1 >> #define EXTCON_USB_HOST 2 >> >> -/* Charging external connector */ >> +/* >> + * Charging external connector >> + * >> + * When one SDP charger connector was reported, we should also report >> + * the USB connector, which means EXTCON_CHG_USB_SDP should always >> + * appear together with EXTCON_USB. The same as ACA charger connector, >> + * EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. >> + */ > > Looks good to me. > But, you use the different word for ACA as following: > I think that 'would normally' is proper in descritpion. Okay, I will change to 'would normally' in next version patch. Thanks. > > - commit msg : EXTCON_CHG_USB_ACA would normally appear with EXTCON_USB_HOST. > - description: EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. > >> #define EXTCON_CHG_USB_SDP 5 /* Standard Downstream Port */ >> #define EXTCON_CHG_USB_DCP 6 /* Dedicated Charging Port */ >> #define EXTCON_CHG_USB_CDP 7 /* Charging Downstream Port */ >> > > -- > Regards, > Chanwoo Choi -- Baolin.wang Best Regards