From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gy0-f177.google.com ([209.85.160.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SOwBn-0005kC-0M for linux-mtd@lists.infradead.org; Mon, 30 Apr 2012 19:23:16 +0000 Received: by ghbf11 with SMTP id f11so1746301ghb.36 for ; Mon, 30 Apr 2012 12:23:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4F9EE445.6010402@freescale.com> References: <1335576594-25267-1-git-send-email-computersforpeace@gmail.com> <1335576594-25267-8-git-send-email-computersforpeace@gmail.com> <4F9EC11A.7020201@freescale.com> <4F9EE445.6010402@freescale.com> Date: Mon, 30 Apr 2012 12:23:13 -0700 Message-ID: Subject: Re: [PATCH v3 07/10] mtd: IFC NAND: utilize oob_required parameter From: Brian Norris To: Scott Wood Content-Type: text/plain; charset=ISO-8859-1 Cc: Artem Bityutskiy , linux-mtd@lists.infradead.org, Shmulik Ladkani , Li Yang , David Woodhouse , Prabhakar Kushwaha List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Apr 30, 2012 at 12:13 PM, Scott Wood wrote: > On 04/30/2012 02:08 PM, Brian Norris wrote: >> Is the read_page change sane? > > It should be harmless. Right, but I am now handling Shmulik's comments about auto-incremented NAND. It seems like there are few/no users of auto-incrementing page reads, but if any driver relied on reading page,oob,page,oob,etc. without a READ command in between, then we might cause problems by skipping the OOB buffer read. Of course, with various NAND controllers/drivers, this issue is hard for me to sort through. >> Did you review the (misspelled) eLBC patch? (patch 06/10) > > No, that one wasn't CCed to me (I should probably get around to > subscribing to linux-mtd...). scripts/get_maintainers.pl only goes so far. It's hard to track down the *real* experts here... > It looks like the same situation as IFC. OK, I'll fix it too then. Thanks. Brian