Re: [PATCH V5 0/4] Signaling api support in glink/rpmsg clients

From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Deepak Kumar Singh <deesin@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Chris Lew <clew@codeaurora.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-remoteproc <linux-remoteproc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 0/4] Signaling api support in glink/rpmsg clients
Date: Wed, 2 Sep 2020 10:40:51 -0600	[thread overview]
Message-ID: <CANLsYkxMrKdC8BAeskpM=Wqd=SDXc4GK1J=ATf_EUnGpoAdjTw@mail.gmail.com> (raw)
In-Reply-To: <5ce032b8-6b26-d0a7-f92d-f8487d810f0c@codeaurora.org>

On Wed, 2 Sep 2020 at 10:30, Deepak Kumar Singh <deesin@codeaurora.org> wrote:
>
>
> On 7/6/2020 11:34 PM, Mathieu Poirier wrote:
> > Hi Deepak,
> >
> > On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote:
> >> Change from version 5
> >> [V5,4/4] rpmsg: char: Add signal callback and POLLPRI support
> >> Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix
> >> warning.
> >>
> >> Change from version 4
> >> I am taking over these patches from aneela@codeaurora.org
> >> Fixed all the trivial review comments.
> >>
> >> Signal conversion to and from native signal as done in patch V4,2/4
> >> is intentional.
> >>
> >> Arun Kumar Neelakantam (3):
> >>    rpmsg: glink: Add support to handle signals command
> >>    rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
> >>    rpmsg: char: Add signal callback and POLLPRI support
> >>
> >> Deepak Kumar Singh (1):
> >>    rpmsg: core: Add signal API support
> > I'm confused here - V5 (or what I think it is) was sent out on June 24th without
> > a cover letter.  This set has a cover letter but it is labeled V5.  So is this
> > the cover letter that should have been sent out on the 24th and the content
> > herein relevent to that set?  Or is it accurate and the label on the cover
> > letter of this set is wrong and should have been V6?
> >
> > I have little confidence in both sets and as such won't be reviewing them.
> > Please send a new revision that is properly labeled.
> >
> > Thanks,
> > Mathieu
> >
> Mistakenly i forgot to update label for cover letter to V6.
>
> I have uploaded patch set V7 with updated cover letter.

Thank you for doing that - I have added your set to my list of patches
to review.  Note that I have a fair amount of patches to go over
lately and as such getting to yours will take some time.

Regards,
Mathieu

>
> There is no change in patches.
>
> >>   drivers/rpmsg/qcom_glink_native.c | 125 ++++++++++++++++++++++++++++++++++++++
> >>   drivers/rpmsg/rpmsg_char.c        |  76 ++++++++++++++++++++++-
> >>   drivers/rpmsg/rpmsg_core.c        |  40 ++++++++++++
> >>   drivers/rpmsg/rpmsg_internal.h    |   5 ++
> >>   include/linux/rpmsg.h             |  27 ++++++++
> >>   5 files changed, 270 insertions(+), 3 deletions(-)
> >>
> >> --
> >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> >> a Linux Foundation Collaborative Project
> >>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>