From: "Maciej Żenczykowski" <maze@google.com>
To: Nick <vincent@systemli.org>
Cc: Phil Sutter <phil@nwl.cc>,
Netfilter Development Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH iptables 1/2] xtables: fix compilation with musl
Date: Mon, 16 May 2022 00:12:33 -0700 [thread overview]
Message-ID: <CANP3RGfRcx-ykxVUMGE+Nw6vwC6OPQDq0R+BE36aJ=_MqTCHGQ@mail.gmail.com> (raw)
In-Reply-To: <1c529232-3219-2571-77df-84047f594178@systemli.org>
On Sun, May 15, 2022 at 11:53 PM Nick <vincent@systemli.org> wrote:
>
>
> >> Ultimately I find
> >> https://android.git.corp.google.com/platform/external/iptables/+/7608e136bd495fe734ad18a6897dd4425e1a633b%5E%21/
> >>
> >> +#ifdef __BIONIC__
> >> +#include <linux/if_ether.h> /* ETH_ALEN */
> >> +#endif
> > While I think musl not catching the "double" include is a bug, I'd
> > prefer the ifdef __BIONIC__ solution since it started the "but my libc
> > needs this" game.
> >
> > Nick, if the above change fixes musl builds for you, would you mind
> > submitting it formally along with a move of the netinet/ether.h include
> > from mid-file to top?
> I will test again. :) However, I can not open the
> "android.git.corp.google.com"? Can you maybe link (also for reference)
> to a freely available source?
Try https://cs.android.com/android/_/android/platform/external/iptables/+/7608e136bd495fe734ad18a6897dd4425e1a633b
next prev parent reply other threads:[~2022-05-16 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 16:33 [PATCH iptables 1/2] xtables: fix compilation with musl Nick Hainke
2022-05-14 16:33 ` [PATCH iptables 2/2] xshared: " Nick Hainke
2022-05-14 17:09 ` Phil Sutter
2022-05-16 6:47 ` [PATCH] treewide: use uint* instead of u_int* vincent
2022-05-16 10:28 ` Jan Engelhardt
2022-05-16 16:16 ` vincent
2022-05-17 8:10 ` Phil Sutter
2022-05-17 8:14 ` Jan Engelhardt
2022-05-18 13:21 ` Phil Sutter
2022-05-31 21:32 ` Nick
2022-05-14 17:04 ` [PATCH iptables 1/2] xtables: fix compilation with musl Phil Sutter
2022-05-14 19:14 ` Maciej Żenczykowski
2022-05-15 12:05 ` Phil Sutter
2022-05-15 13:40 ` Maciej Żenczykowski
2022-05-17 8:17 ` Phil Sutter
2022-05-17 8:22 ` Maciej Żenczykowski
2022-05-15 14:09 ` Florian Westphal
2022-05-15 14:13 ` Maciej Żenczykowski
2022-05-17 8:14 ` Phil Sutter
2022-05-16 6:52 ` Nick
2022-05-16 7:12 ` Maciej Żenczykowski [this message]
2022-05-16 16:24 ` [PATCH] " vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANP3RGfRcx-ykxVUMGE+Nw6vwC6OPQDq0R+BE36aJ=_MqTCHGQ@mail.gmail.com' \
--to=maze@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.