From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846B5C4BA06 for ; Wed, 26 Feb 2020 03:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B53321927 for ; Wed, 26 Feb 2020 03:05:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VQcINmPs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730196AbgBZDFg (ORCPT ); Tue, 25 Feb 2020 22:05:36 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:34365 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727880AbgBZDFf (ORCPT ); Tue, 25 Feb 2020 22:05:35 -0500 Received: by mail-io1-f68.google.com with SMTP id 13so1729013iou.1 for ; Tue, 25 Feb 2020 19:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZpoXmSgMubpOi5DQxpDALTYtlMkwTsn3LdFqrSxzDHI=; b=VQcINmPs7W5dpGMJBINFbHd6yvMbf22ThLQddwiXyeYpHR4PCI4PeVBa9ioLx2tkG8 Isnk8ag7ErjArIdrBZYkQA0LsDVLirTcaKkB7k5NaIsPjtfbts/xsgCIxpzTiFQlbuob /sG1urZZG/LZoZQEGixRj7qURMgo5IEM/tHZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZpoXmSgMubpOi5DQxpDALTYtlMkwTsn3LdFqrSxzDHI=; b=oYJIulNA+y2u722sx8Cmm+FL4v46Pwjf3lktTjGivxF8Q2UuluIXva2g+3cZM5aNxi X/pJhMeICLJpRZ+Ta9FOZccs8MaJbc6jwlXwYAAjd88ndanwYLENagXape+0HdzHCnoM W/MRPjC2G2vb46WNPvnx7tg1AjfcRjaANJxcPxBIOIPXo+nPMTxf5rqs3DEwkAbrw8ue h7N9VWjuBd9cqbonOgKnojrptabDfDGOkh0UhvZbht0LavY+/2IcLAk/aF1IYNamVjLp Q/rQ0RILGuRvTmqN384LogT7N7PFK0PAEJFKXlmVOLoweLKj91ZVqcSor2wgYeBwUixu IzEg== X-Gm-Message-State: APjAAAUvdrHSbj1hzwnrGY66olTi7ZJONiR3zNLN/RlaOhQ31N3xJnfQ Nl0Vq8s9mOhhviJrH3d0T+oRFc0wrs1BUK7uuNncLg== X-Google-Smtp-Source: APXvYqwzZpOup7HNjSuyaBr2WfdKmSPxs3zxBDbSBpnTKJKzjrq4aUtMcaYJS3D4NxC2YjwRsGV2uPLsVlQ2PmWN8/8= X-Received: by 2002:a6b:c9c6:: with SMTP id z189mr1848962iof.285.1582686334967; Tue, 25 Feb 2020 19:05:34 -0800 (PST) MIME-Version: 1.0 References: <20200226135127.31667f48@canb.auug.org.au> In-Reply-To: <20200226135127.31667f48@canb.auug.org.au> From: Devesh Sharma Date: Wed, 26 Feb 2020 08:34:58 +0530 Message-ID: Subject: Re: linux-next: build failure after merge of the rdma tree To: Stephen Rothwell Cc: Doug Ledford , Jason Gunthorpe , Linux Next Mailing List , Linux Kernel Mailing List , Naresh Kumar PBS , Selvin Xavier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 8:21 AM Stephen Rothwell wrote: > > Hi all, > > After merging the rdma tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__free_pbl': > drivers/infiniband/hw/bnxt_re/qplib_res.c:78:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration] > 78 | vfree(pbl->pg_arr); > | ^~~~~ > | kfree > drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__alloc_pbl': > drivers/infiniband/hw/bnxt_re/qplib_res.c:117:16: error: implicit declaration of function 'vmalloc'; did you mean 'kmalloc'? [-Werror=implicit-function-declaration] > 117 | pbl->pg_arr = vmalloc(pages * sizeof(void *)); > | ^~~~~~~ > | kmalloc > drivers/infiniband/hw/bnxt_re/qplib_res.c:117:14: warning: assignment to 'void **' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 117 | pbl->pg_arr = vmalloc(pages * sizeof(void *)); > | ^ > drivers/infiniband/hw/bnxt_re/qplib_res.c:121:18: warning: assignment to 'dma_addr_t *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > 121 | pbl->pg_map_arr = vmalloc(pages * sizeof(dma_addr_t)); > | ^ > > Caused by commit > > 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation") > > I added the following fix for today: > > From: Stephen Rothwell > Date: Wed, 26 Feb 2020 13:46:02 +1100 > Subject: [PATCH] RDMA/bnxt_re: using vmalloc requires including vmalloc.h > > Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation") > Signed-off-by: Stephen Rothwell > --- > drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c > index 4346b95963cf..fc5909c7f2e0 100644 > --- a/drivers/infiniband/hw/bnxt_re/qplib_res.c > +++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include "roce_hsi.h" > #include "qplib_res.h" > #include "qplib_sp.h" > -- > 2.25.0 > > -- > Cheers, > Stephen Rothwell Thanks! Acked-by: Devesh Sharma