From: Yuri Benditovich <yuri.benditovich@daynix.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] virtio: reset region cache when on queue deletion
Date: Sun, 5 Jan 2020 18:14:45 +0200 [thread overview]
Message-ID: <CAOEp5OeQx+6MsXPHCrQqo6a7fAo2Lzhd62qAMMY_d9+cgExM=w@mail.gmail.com> (raw)
In-Reply-To: <20200105071859-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On Sun, Jan 5, 2020 at 2:22 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1708480
> > Fix leak of region reference that prevents complete
> > device deletion on hot unplug.
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
>
> I rebased this on top of my tree.
>
> Got this:
>
>
> commit f3dee6a062c1f4445768296ee39070bab9863372
> Author: Yuri Benditovich <yuri.benditovich@daynix.com>
> Date: Thu Dec 26 06:36:48 2019 +0200
>
> virtio: reset region cache when on queue deletion
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1708480
> Fix leak of region reference that prevents complete
> device deletion on hot unplug.
>
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
> Message-Id: <20191226043649.14481-2-yuri.benditovich@daynix.com>
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 95d8ff8508..7b861e0ca0 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2344,6 +2344,7 @@ void virtio_delete_queue(VirtQueue *vq)
> vq->handle_aio_output = NULL;
> g_free(vq->used_elems);
> vq->used_elems = NULL;
> + virtio_virtqueue_reset_region_cache(vq);
> }
>
> void virtio_del_queue(VirtIODevice *vdev, int n)
>
> Can you confirm pls?
>
Yes, it is
[-- Attachment #2: Type: text/html, Size: 2382 bytes --]
next prev parent reply other threads:[~2020-01-05 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 4:36 [PATCH 0/2] Solve problem of hot removal of virtio-net-pci Yuri Benditovich
2019-12-26 4:36 ` [PATCH 1/2] virtio: reset region cache when on queue deletion Yuri Benditovich
2019-12-26 8:58 ` Jason Wang
2019-12-26 9:29 ` Yuri Benditovich
2020-01-01 23:50 ` Michael S. Tsirkin
2020-01-02 7:09 ` Yuri Benditovich
2020-01-05 11:39 ` Michael S. Tsirkin
2020-01-05 16:21 ` Yuri Benditovich
2020-01-06 9:10 ` Yuri Benditovich
2020-01-06 9:57 ` Michael S. Tsirkin
2020-01-06 10:37 ` Yuri Benditovich
2020-01-07 10:42 ` Yuri Benditovich
2020-01-05 12:21 ` Michael S. Tsirkin
2020-01-05 16:14 ` Yuri Benditovich [this message]
2019-12-26 4:36 ` [PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted Yuri Benditovich
2020-01-01 23:43 ` Michael S. Tsirkin
2020-01-02 6:52 ` Yuri Benditovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOEp5OeQx+6MsXPHCrQqo6a7fAo2Lzhd62qAMMY_d9+cgExM=w@mail.gmail.com' \
--to=yuri.benditovich@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.