Re: [RFC 00/12] Overhaul of error handling and module init/uninit

[Pekka Enberg <penberg@kernel.org>]

On Mon, Dec 19, 2011 at 3:58 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> This patch series is really a work in progress, but is mature enough to
> cover most of the different modules we have in the tool, and receive
> comments regarding the work done so far and any future work.
>
> There were three main goals while doing this work:
> 1. Less die(), more clean exits. We are not interested in hitting a die()
> during regular program flow. die() should be reserved to extreme cases where
> we are not able to report the error back.
>
> 2. Adding actual error handling where it was missing. Starting from simple
> things like checking malloc()s, through making functions report their failures
> (this meant switching lots of functions from 'void' to 'int' since they can
> actually fail), and all the way to being able to handle errors by
> uninitializing and exiting gracefully.
>
> 3. Getting initialization and uninitialization of modules somewhat
> standard. The main purpose here is to be able to either add __init functions
> or to be able to call all initialization functions from a single place without
> code duplication.

You're mixing up cleanups (especially whitespace ones) and fixes which
is painful to deal with. So how about submitting the cleanups first
without changing code logic to get them out of the way?

                     Pekka