All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] pci: imx: disable imx6sdl LTSSM upon driver remove
Date: Fri, 16 Apr 2021 17:41:01 -0300	[thread overview]
Message-ID: <CAOMZO5BVnKefxT3UtwyzJiWiCUVEoRsam_gs4x4PgWrTM8emzw@mail.gmail.com> (raw)
In-Reply-To: <20210416203041.5035-1-tharvey@gateworks.com>

Hi Tim,

Some more comments.

On Fri, Apr 16, 2021 at 5:30 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> commit 6ecbe1375671 ("drivers: pci: imx: add imx_pcie_remove function")
> attempted to resolve an issue caused by MX6QDL not having a proper
> intneral PCIe core reset and thus hanging during kernel init if the

"internal"

> --- a/drivers/pci/pcie_imx.c
> +++ b/drivers/pci/pcie_imx.c
> @@ -473,7 +473,7 @@ static int imx6_pcie_assert_core_reset(struct imx_pcie_priv *priv,
>          * If both LTSSM_ENABLE and REF_SSP_ENABLE are active we have a strong
>          * indication that the bootloader activated the link.
>          */
> -       if (is_mx6dq() && prepare_for_boot) {
> +       if ((is_mx6dq() || is_mx6sdl()) && prepare_for_boot) {

It seems that i.MX6QP is missing. What about adding is_mx6dqp() too?

  parent reply	other threads:[~2021-04-16 20:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 20:30 [PATCH] pci: imx: disable imx6sdl LTSSM upon driver remove Tim Harvey
2021-04-16 20:33 ` Fabio Estevam
2021-04-16 20:41 ` Fabio Estevam [this message]
2021-04-16 20:48   ` Tim Harvey
2021-04-16 21:12     ` Fabio Estevam
2021-05-02 11:43 ` stefano.babic at babic.homelinux.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5BVnKefxT3UtwyzJiWiCUVEoRsam_gs4x4PgWrTM8emzw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.