From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965112AbbJ1HHc (ORCPT ); Wed, 28 Oct 2015 03:07:32 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:33938 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932533AbbJ1HHZ (ORCPT ); Wed, 28 Oct 2015 03:07:25 -0400 MIME-Version: 1.0 X-Originating-IP: [58.123.138.250] In-Reply-To: <20151028070045.GI1854@malice.jf.intel.com> References: <1445992931-28107-1-git-send-email-olof@lixom.net> <1445992931-28107-8-git-send-email-olof@lixom.net> <20151028070045.GI1854@malice.jf.intel.com> Date: Wed, 28 Oct 2015 16:07:25 +0900 Message-ID: Subject: Re: [PATCH 07/10] merge_config.sh: add tests From: Olof Johansson To: Darren Hart Cc: Michal Marek , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Darren Hart Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 4:00 PM, Darren Hart wrote: > On Wed, Oct 28, 2015 at 09:42:08AM +0900, Olof Johansson wrote: >> For being a small script, merge_config.sh is fairly scary to change since there's no >> real way to know if you did something wrong. So it seems appropriate to add a simple >> test suite. >> >> I've started with testcases in the areas I care about, other should of course feel >> free to expand on this. >> >> Use is simple, from the kernel tree, run ./scripts/kconfig/merge_config_test/runall. >> It'll execute out of a tmpdir under /tmp. >> >> Signed-off-by: Olof Johansson > > Thanks for writing the test cases. Shell scripting is so easy to bikeshed - so > I'm going to skip that. I didn't catch any bashisms, and the test coverage is > good. Thanks! Anyone who wishes to contribute style comments has to contribute at least one additional testcase as well. Fair? :) -Olof