From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A31C433FE for ; Thu, 9 Dec 2021 17:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239160AbhLIRND (ORCPT ); Thu, 9 Dec 2021 12:13:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242503AbhLIRNC (ORCPT ); Thu, 9 Dec 2021 12:13:02 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F72C061A32 for ; Thu, 9 Dec 2021 09:09:28 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id h24so4933588pjq.2 for ; Thu, 09 Dec 2021 09:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=X11M2TlDgjJ6Jnz85pZfgXoUvRxyk1Ep1uRScdCq8JZU3KIc8cO5QEBB/cAjCTfQc1 swVoiOjEgYcQM3REh+hW80fuK6KE+lXnItAif+OK22UB0KfXph/sZ/Y/dkDPMNf1HmpR B31RZ2iWJuzDd3YfQRhYWY/j2Vi92o3+q374Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=g0Rgg/QEVtRaGCwngs8ZU+FqjtqMuzvyd29ZReO/OspFDLkTxyLo0zyFjfPCBnyUYS zTeRmYHZ+o+vlJsuO5SjwhtwVyIHZCCLfK+1BSe8gHUJ9+Ze3it2/9JgpB2P6d6/noMB aV/T1lmd7EJ+2tU/lHfOkiNuU6QR7KZTo6hTFzuyJFgp9t9mRgs5XUmmZ+Si5HFUibq2 9bIF4w5oJoltKdj+e6kOPdr+IdfArei3mGGjWQHPV7muNeskvDmO0HB6WWufwIk9hAhL w6ZkY/0EVPvoG59Q9da13dYML8O3vuYoe8BAAbMzWgtSUy5Y11rlI+nWCdFIFn7ZGwAy i2/g== X-Gm-Message-State: AOAM5324AZqX6TBWsNB74us44/iVh5PjR44u1wT5aYmoy8EOsRCqWTAr qdbqsFLXMInulAe9+BtAi0c3msoidX6CDrIA6J6xyg== X-Google-Smtp-Source: ABdhPJyCX8wQ+HUvA4s6g4Ya2TOcMuKHFO5FqSEOA83hPmJ1hZu9RpPCK5Uynse9z8q6es/uaeEeJTvXzf2twhi5B5E= X-Received: by 2002:a17:90b:3758:: with SMTP id ne24mr17081019pjb.59.1639069767405; Thu, 09 Dec 2021 09:09:27 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Thu, 9 Dec 2021 18:09:15 +0100 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Tim Harvey Cc: Jagan Teki , Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tim On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: > > On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Tim > > > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > > > Hi Sam, > > > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > > > Hi Jagan, > > > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > > users like i.MX8MM. > > > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > > component_ops and fixing exynos specific code in order to make > > > > > > the bridge more mature to use and the same is mentioned in > > > > > > drivers TODO. > > > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > > the exynos platform? > > > > > > > > > > > > Any inputs? > > > > > > > > > > I really like where you are headign with this! > > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > > individual patches. > > > > > > > > > > I hope you find a way to move forward with this. > > > > > > > > Thanks for the response. > > > > > > > > We have found some issues with Bridge conversion on existing exynos > > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > > attach if it involves kms hotplug. kms hotplug would require drm > > > > pointer and that pointer would only available after the bind call > > > > finishes. But the bridge attach in bind call will defer till it find > > > > the attached bridge. > > > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > > component based DSI drivers which involves kms hot-plug. > > > > > > > > If you have any ideas on this, please let me know. > > > > > > > > > > Jagan, > > > > > > How is your progress on this series? Looking at your repo it looks > > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > > branch but you've got a lot of things there that are likely not > > > related to this series? > > > > I have a bit of work on those patches and tested on imx8mn. Basically: > > > > - add the dsi timing calculation > > - change few difference with samsung bridge > > - fix crashes of my dsi panels > > - compare with NXP driver the final results > > > > I found that I have one problem that gives me some instability. In the > > NXP original driver the panel needs to be > > enabled in bridge_enable before out the standby. If I understand > > correctly, our standby should be done after. > > I would like to have some feedback and help and testing on other > > boards/devices and some suggestions on how to handle > > some of the differences. Another big problem is etnavi that is not stable > > > > Michael, > > Where can I find your patches? > I will push on some tree and share > What do you mean by etnaviv not being stable? > > I did some limited testing with etnaviv on imx8mm with 5.15 + dsi > patches on an Ubuntu focal root filesystem by: > apt update > apt install gnome-session gnome-terminal > ^^^ 2D hardware acceleration appears to be working (dragging opaque > windows around) > apt install mesa-utils glmark2 > glxgears > ^^^ ~160fps on IMX8MM > glmark2 > ^^^ score of 39 on IMX8MM > > I haven't seen any updates from Jagan since Nov 24 > (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not > sure if he's been able to work through drm/exynos issues that have > been blocking his progress. I plan to push on github [17:07:42.315] Sending ready to systemd [ 214.052085] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 214.595998] etnaviv-gpu 38000000.gpu: recover hung GPU! ** (maynard:386): WARNING **: 17:07:43.874: failed to setup mixer: Success [17:07:44.175] Added surface 0xaaab02630440, app_id (null) to pending list [17:07:44.176] Added surface 0xaaab026172b0, app_id (null) to pending list ** Message: 17:07:44.289: New advertisement app id maynard ** Message: 17:07:44.290: New advertisement app id maynard [17:07:45.171] (background) position view 0xaaab0261f860, x 0, y 0, on output DSI-1 [17:07:45.171] (panel) geom.width 100, geom.height 480, geom.x 0, geom.y 0 [17:07:45.171] (panel) edge 2 position view 0xaaab02634510, x 0, y 0 [17:07:45.172] panel type 2 inited on output DSI-1 [17:07:45.172] Usable area: 380x480+100,0 [ 216.932080] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 217.476015] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 218.020157] etnaviv-gpu 38000000.gpu: recover hung GPU! This is my problem on imx8mn Michael Michael > Best regards, > > Tim -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0010C433F5 for ; Thu, 9 Dec 2021 17:09:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C8ADC10E13F; Thu, 9 Dec 2021 17:09:28 +0000 (UTC) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA57810E13F for ; Thu, 9 Dec 2021 17:09:27 +0000 (UTC) Received: by mail-pj1-x1030.google.com with SMTP id iq11so4917144pjb.3 for ; Thu, 09 Dec 2021 09:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=X11M2TlDgjJ6Jnz85pZfgXoUvRxyk1Ep1uRScdCq8JZU3KIc8cO5QEBB/cAjCTfQc1 swVoiOjEgYcQM3REh+hW80fuK6KE+lXnItAif+OK22UB0KfXph/sZ/Y/dkDPMNf1HmpR B31RZ2iWJuzDd3YfQRhYWY/j2Vi92o3+q374Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=QLLrkYOXoixXAx8bqmaUmWQNI/i3yX8xTMfoCHizEqQSCgIMtgrtpcsPcHH41X4qFE 4f7bHzr1NteU+FHQ9mF+HJxJWFk4sl5lDwMLkKr5o7knBbB8M2qEsb38XyifPhUJmDRO tX9cuz1ceXbAJbPptyFI0q/9OZX8iHESeU21DVYiMaatSR4Ze/WzEjLy+qEnZGu8ZlXS 2lIZ5n1YxDMl777+P+SNUW5taDrtAvriLBP7lh1VdZn5ip6IlJ4fCAz5waRWl2slkd48 n1bXOWdPZILmjCrX5h/CIt75eynC5kZfCE3HJxajObHDbaTLUxOhf3JFSo9pjLYAJE3k B8cA== X-Gm-Message-State: AOAM531b2uhsAKMCiV74RpImr/t1hLIbeUMVj1Bdj4ADyiDX6sdW95Uh VDE7v9lXsy6tHDeSejcD2KayngQOPCXcAaJD8KRc2w== X-Google-Smtp-Source: ABdhPJyCX8wQ+HUvA4s6g4Ya2TOcMuKHFO5FqSEOA83hPmJ1hZu9RpPCK5Uynse9z8q6es/uaeEeJTvXzf2twhi5B5E= X-Received: by 2002:a17:90b:3758:: with SMTP id ne24mr17081019pjb.59.1639069767405; Thu, 09 Dec 2021 09:09:27 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Thu, 9 Dec 2021 18:09:15 +0100 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Tim Harvey Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , linux-arm-kernel , Neil Armstrong , linux-amarula , Krzysztof Kozlowski , Seung-Woo Kim , NXP Linux Team , dri-devel , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Jagan Teki , Daniel Vetter , Sam Ravnborg , Robert Foss , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tim On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: > > On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Tim > > > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > > > Hi Sam, > > > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > > > Hi Jagan, > > > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > > users like i.MX8MM. > > > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > > component_ops and fixing exynos specific code in order to make > > > > > > the bridge more mature to use and the same is mentioned in > > > > > > drivers TODO. > > > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > > the exynos platform? > > > > > > > > > > > > Any inputs? > > > > > > > > > > I really like where you are headign with this! > > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > > individual patches. > > > > > > > > > > I hope you find a way to move forward with this. > > > > > > > > Thanks for the response. > > > > > > > > We have found some issues with Bridge conversion on existing exynos > > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > > attach if it involves kms hotplug. kms hotplug would require drm > > > > pointer and that pointer would only available after the bind call > > > > finishes. But the bridge attach in bind call will defer till it find > > > > the attached bridge. > > > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > > component based DSI drivers which involves kms hot-plug. > > > > > > > > If you have any ideas on this, please let me know. > > > > > > > > > > Jagan, > > > > > > How is your progress on this series? Looking at your repo it looks > > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > > branch but you've got a lot of things there that are likely not > > > related to this series? > > > > I have a bit of work on those patches and tested on imx8mn. Basically: > > > > - add the dsi timing calculation > > - change few difference with samsung bridge > > - fix crashes of my dsi panels > > - compare with NXP driver the final results > > > > I found that I have one problem that gives me some instability. In the > > NXP original driver the panel needs to be > > enabled in bridge_enable before out the standby. If I understand > > correctly, our standby should be done after. > > I would like to have some feedback and help and testing on other > > boards/devices and some suggestions on how to handle > > some of the differences. Another big problem is etnavi that is not stable > > > > Michael, > > Where can I find your patches? > I will push on some tree and share > What do you mean by etnaviv not being stable? > > I did some limited testing with etnaviv on imx8mm with 5.15 + dsi > patches on an Ubuntu focal root filesystem by: > apt update > apt install gnome-session gnome-terminal > ^^^ 2D hardware acceleration appears to be working (dragging opaque > windows around) > apt install mesa-utils glmark2 > glxgears > ^^^ ~160fps on IMX8MM > glmark2 > ^^^ score of 39 on IMX8MM > > I haven't seen any updates from Jagan since Nov 24 > (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not > sure if he's been able to work through drm/exynos issues that have > been blocking his progress. I plan to push on github [17:07:42.315] Sending ready to systemd [ 214.052085] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 214.595998] etnaviv-gpu 38000000.gpu: recover hung GPU! ** (maynard:386): WARNING **: 17:07:43.874: failed to setup mixer: Success [17:07:44.175] Added surface 0xaaab02630440, app_id (null) to pending list [17:07:44.176] Added surface 0xaaab026172b0, app_id (null) to pending list ** Message: 17:07:44.289: New advertisement app id maynard ** Message: 17:07:44.290: New advertisement app id maynard [17:07:45.171] (background) position view 0xaaab0261f860, x 0, y 0, on output DSI-1 [17:07:45.171] (panel) geom.width 100, geom.height 480, geom.x 0, geom.y 0 [17:07:45.171] (panel) edge 2 position view 0xaaab02634510, x 0, y 0 [17:07:45.172] panel type 2 inited on output DSI-1 [17:07:45.172] Usable area: 380x480+100,0 [ 216.932080] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 217.476015] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 218.020157] etnaviv-gpu 38000000.gpu: recover hung GPU! This is my problem on imx8mn Michael Michael > Best regards, > > Tim -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83018C433EF for ; Thu, 9 Dec 2021 17:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MKZdwVnx41FYFzFSnEZgRtdWjF3xHSUpnrLq2AlYxXc=; b=lQB1bkyR09hk9R 551y61nIooWFc8E1gn8XmpDbyockRj3oYMrASfoQlWq2gekGc/NTcOm6H6N/LZNWXz3JuQEdr3enB GGqrzTeWE/1je9vD4yx89LmBa4d92AlhMey8ECgt5qVw6qJBniTX+Q7mdUDnJfbcqcsDbLBx78sl6 Do1UonV13cZJ+4zTMYpcyA/wbzQMRn/V1TsuH0MIdHoTSupUodFmaZtE4/nBJQsSlQytsiO9LfuCH FIZL13nibH/5g2jmy6Y+J7p9zIUgO+Vv9lkFFeUjjVPH98kbMuP7l58EdfFUD5jEGynt4lhZZfTIm y4sdXGRwkAVJOj2HH8YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvMvF-00Gsyp-HO; Thu, 09 Dec 2021 17:09:33 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvMvB-00Gsxe-1O for linux-arm-kernel@lists.infradead.org; Thu, 09 Dec 2021 17:09:31 +0000 Received: by mail-pj1-x102c.google.com with SMTP id np3so4906013pjb.4 for ; Thu, 09 Dec 2021 09:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=X11M2TlDgjJ6Jnz85pZfgXoUvRxyk1Ep1uRScdCq8JZU3KIc8cO5QEBB/cAjCTfQc1 swVoiOjEgYcQM3REh+hW80fuK6KE+lXnItAif+OK22UB0KfXph/sZ/Y/dkDPMNf1HmpR B31RZ2iWJuzDd3YfQRhYWY/j2Vi92o3+q374Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SVQ+YMlt28Ir8xyFyWE5Df0gZJmNCYigQmtRvCGp//o=; b=HTdr+p4sLBGjBLO3VxxEvZNb8Swz5v4boxPL5K3sSK0Z84AwEpqpabjIZzZFDXmB+6 kaKNID/hteK19gSHdXmfxS8Cd9eGY5oFLtbqMpL+M5IMNW2VBh7vjW/akAVnOtUQhlMY UHTZjlL5wyFfC1DDeK9nu1Dreanr2o4RwR/uoXLMbYJTK+LPG1h0l6dwuFxr61pPozVK FFyc34MxPU94jYVpG5Dtegs/5Yp8NM6FE1GVErsWjgY2SovbkYnzLlWI5BU69uQW0Y2E sx0V/eJ8GOqwwIyAYZEv5JdVqCqBILpPbrT4pfVbOq5zvHQCrzMyEdNdCrUxOWCYoHyn nVCg== X-Gm-Message-State: AOAM530aZVAhx+33mtdEY/7KZ1C4+e7IOMgE3GFsVpLaMj2HaI0LzFZ3 SpOVOiVlDIZrYNqpgIhq8egpcCF/nzMmcsMZC7/vfQ== X-Google-Smtp-Source: ABdhPJyCX8wQ+HUvA4s6g4Ya2TOcMuKHFO5FqSEOA83hPmJ1hZu9RpPCK5Uynse9z8q6es/uaeEeJTvXzf2twhi5B5E= X-Received: by 2002:a17:90b:3758:: with SMTP id ne24mr17081019pjb.59.1639069767405; Thu, 09 Dec 2021 09:09:27 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Thu, 9 Dec 2021 18:09:15 +0100 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Tim Harvey Cc: Jagan Teki , Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_090929_571875_FBB3CE28 X-CRM114-Status: GOOD ( 49.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tim On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: > > On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Tim > > > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > > > Hi Sam, > > > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > > > Hi Jagan, > > > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > > users like i.MX8MM. > > > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > > component_ops and fixing exynos specific code in order to make > > > > > > the bridge more mature to use and the same is mentioned in > > > > > > drivers TODO. > > > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > > the exynos platform? > > > > > > > > > > > > Any inputs? > > > > > > > > > > I really like where you are headign with this! > > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > > individual patches. > > > > > > > > > > I hope you find a way to move forward with this. > > > > > > > > Thanks for the response. > > > > > > > > We have found some issues with Bridge conversion on existing exynos > > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > > attach if it involves kms hotplug. kms hotplug would require drm > > > > pointer and that pointer would only available after the bind call > > > > finishes. But the bridge attach in bind call will defer till it find > > > > the attached bridge. > > > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > > component based DSI drivers which involves kms hot-plug. > > > > > > > > If you have any ideas on this, please let me know. > > > > > > > > > > Jagan, > > > > > > How is your progress on this series? Looking at your repo it looks > > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > > branch but you've got a lot of things there that are likely not > > > related to this series? > > > > I have a bit of work on those patches and tested on imx8mn. Basically: > > > > - add the dsi timing calculation > > - change few difference with samsung bridge > > - fix crashes of my dsi panels > > - compare with NXP driver the final results > > > > I found that I have one problem that gives me some instability. In the > > NXP original driver the panel needs to be > > enabled in bridge_enable before out the standby. If I understand > > correctly, our standby should be done after. > > I would like to have some feedback and help and testing on other > > boards/devices and some suggestions on how to handle > > some of the differences. Another big problem is etnavi that is not stable > > > > Michael, > > Where can I find your patches? > I will push on some tree and share > What do you mean by etnaviv not being stable? > > I did some limited testing with etnaviv on imx8mm with 5.15 + dsi > patches on an Ubuntu focal root filesystem by: > apt update > apt install gnome-session gnome-terminal > ^^^ 2D hardware acceleration appears to be working (dragging opaque > windows around) > apt install mesa-utils glmark2 > glxgears > ^^^ ~160fps on IMX8MM > glmark2 > ^^^ score of 39 on IMX8MM > > I haven't seen any updates from Jagan since Nov 24 > (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not > sure if he's been able to work through drm/exynos issues that have > been blocking his progress. I plan to push on github [17:07:42.315] Sending ready to systemd [ 214.052085] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 214.595998] etnaviv-gpu 38000000.gpu: recover hung GPU! ** (maynard:386): WARNING **: 17:07:43.874: failed to setup mixer: Success [17:07:44.175] Added surface 0xaaab02630440, app_id (null) to pending list [17:07:44.176] Added surface 0xaaab026172b0, app_id (null) to pending list ** Message: 17:07:44.289: New advertisement app id maynard ** Message: 17:07:44.290: New advertisement app id maynard [17:07:45.171] (background) position view 0xaaab0261f860, x 0, y 0, on output DSI-1 [17:07:45.171] (panel) geom.width 100, geom.height 480, geom.x 0, geom.y 0 [17:07:45.171] (panel) edge 2 position view 0xaaab02634510, x 0, y 0 [17:07:45.172] panel type 2 inited on output DSI-1 [17:07:45.172] Usable area: 380x480+100,0 [ 216.932080] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 217.476015] etnaviv-gpu 38000000.gpu: recover hung GPU! [ 218.020157] etnaviv-gpu 38000000.gpu: recover hung GPU! This is my problem on imx8mn Michael Michael > Best regards, > > Tim -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel