From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
U-Boot-Denx <u-boot@lists.denx.de>, "Peng Fan" <peng.fan@nxp.com>,
"Stefano Babic" <sbabic@denx.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Ariel D'Alessandro" <ariel.dalessandro@collabora.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Simon Glass" <sjg@chromium.org>,
"Marek Behún" <marek.behun@nic.cz>,
"Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>,
"Ricardo Salveti" <ricardo@foundries.io>,
patrick.delaunay@foss.st.com, "Tom Rini" <trini@konsulko.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Subject: Re: [PATCH V4 7/8] arm: dts: imx8m: shrink ddr firmware size to actual file size
Date: Tue, 24 May 2022 07:50:28 +0200 [thread overview]
Message-ID: <CAOf5uwm2gwHOQaHLWBSBiD4Ruwb1FL8F4F1rFp-qj3RbWB08dQ@mail.gmail.com> (raw)
In-Reply-To: <5c513376-5f99-0686-a40e-f538bae5c6df@gmail.com>
Hi
Il lun 23 mag 2022, 23:13 Alper Nebi Yasak <alpernebiyasak@gmail.com> ha
scritto:
> On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > After we switch to use BINMAN_SYMBOLS, there is no need to pad
> > the file size to 0x8000 and 0x4000. After we use BINMAN_SYMBOLS,
> > the u-boot-spl-ddr.bin shrink about 36KB with i.MX8MP-EVK.
> >
> > Tested-by: Tim Harvey <tharvey@gateworks.com> #imx8m[m,n,p]-venice
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm/dts/imx8mm-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mn-evk-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mn-venice-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mp-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mq-cm-u-boot.dtsi | 8 ++++----
> > arch/arm/dts/imx8mq-u-boot.dtsi | 8 ++++----
>
> Probably can be done for 'imx8mn-bsh-smm-s2-u-boot-common.dtsi' as well.
>
Let us test.
I did not find time
Michael
>
> > 9 files changed, 36 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi
> b/arch/arm/dts/imx8mm-u-boot.dtsi
> > index 5de55a2d80b..19a2da30f51 100644
> > --- a/arch/arm/dts/imx8mm-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi
> > @@ -41,25 +41,25 @@
> >
> > imem_1d: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_1d: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > imem_2d: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_2d: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> > };
> > diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > index eb1dd8debba..e1740fa31a6 100644
> > --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > @@ -149,22 +149,22 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> > };
> >
> > diff --git a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> > index 4d0ecb07d4f..1fe2d0fd507 100644
> > --- a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> > @@ -157,22 +157,22 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "ddr4_imem_1d_201810.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "ddr4_dmem_1d_201810.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "ddr4_imem_2d_201810.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "ddr4_dmem_2d_201810.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> > };
> >
> > diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> > index 3db46d4cbcb..4f6dcf307b2 100644
> > --- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> > @@ -38,22 +38,22 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> > };
> >
> > diff --git a/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi
> b/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi
> > index 001e725f568..32ef7929288 100644
> > --- a/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi
> > @@ -132,25 +132,25 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "ddr4_imem_1d.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "ddr4_dmem_1d.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "ddr4_imem_2d.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "ddr4_dmem_2d.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> > };
> > diff --git a/arch/arm/dts/imx8mn-venice-u-boot.dtsi
> b/arch/arm/dts/imx8mn-venice-u-boot.dtsi
> > index 67922146963..e3a0b170347 100644
> > --- a/arch/arm/dts/imx8mn-venice-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-venice-u-boot.dtsi
> > @@ -128,25 +128,25 @@
> >
> > imem_1d: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_1d: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > imem_2d: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_2d: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> > };
> > diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi
> b/arch/arm/dts/imx8mp-u-boot.dtsi
> > index 20edd90cfad..274515a010e 100644
> > --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> > @@ -63,22 +63,22 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem_202006.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem_202006.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem_202006.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem_202006.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> > };
> >
> > diff --git a/arch/arm/dts/imx8mq-cm-u-boot.dtsi
> b/arch/arm/dts/imx8mq-cm-u-boot.dtsi
> > index e2f4b0e740d..9538a04ed97 100644
> > --- a/arch/arm/dts/imx8mq-cm-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mq-cm-u-boot.dtsi
> > @@ -30,22 +30,22 @@
> >
> > blob_1: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_2: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> >
> > blob_3: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > };
> >
> > blob_4: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > };
> > };
> >
> > diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi
> b/arch/arm/dts/imx8mq-u-boot.dtsi
> > index 389414ad26f..1495869fcd2 100644
> > --- a/arch/arm/dts/imx8mq-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mq-u-boot.dtsi
> > @@ -48,25 +48,25 @@
> >
> > imem_1d: blob-ext@1 {
> > filename = "lpddr4_pmu_train_1d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_1d: blob-ext@2 {
> > filename = "lpddr4_pmu_train_1d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > imem_2d: blob-ext@3 {
> > filename = "lpddr4_pmu_train_2d_imem.bin";
> > - size = <0x8000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> >
> > dmem_2d: blob-ext@4 {
> > filename = "lpddr4_pmu_train_2d_dmem.bin";
> > - size = <0x4000>;
> > + align-end = <4>;
> > type = "blob-ext";
> > };
> > };
>
next prev parent reply other threads:[~2022-05-24 5:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 14:10 [PATCH V4 0/8] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-05-20 14:10 ` [PATCH V4 1/8] spl: guard u_boot_any with X86 Peng Fan (OSS)
2022-05-20 15:21 ` Tom Rini
2022-05-21 8:33 ` Peng Fan
2022-05-21 12:05 ` Tom Rini
2022-05-22 13:56 ` Alper Nebi Yasak
2022-05-22 14:50 ` Tom Rini
2022-05-23 21:10 ` Alper Nebi Yasak
2022-05-23 6:19 ` Peng Fan (OSS)
2022-05-23 6:28 ` Peng Fan (OSS)
2022-05-23 14:10 ` Tom Rini
2022-05-23 21:10 ` Alper Nebi Yasak
2022-05-22 13:55 ` Alper Nebi Yasak
2022-05-20 14:10 ` [PATCH V4 2/8] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-05-22 13:56 ` Alper Nebi Yasak
2022-05-23 7:01 ` Peng Fan (OSS)
2022-05-23 21:11 ` Alper Nebi Yasak
2022-05-20 14:10 ` [PATCH V4 3/8] imx: imx8mm-icore: migrate to use BINMAN Peng Fan (OSS)
2022-05-22 13:56 ` Alper Nebi Yasak
2022-05-23 7:02 ` Peng Fan (OSS)
2022-05-20 14:10 ` [PATCH V4 4/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-05-20 15:21 ` Tom Rini
2022-05-20 14:10 ` [PATCH V4 5/8] tools: binman: section: replace @ with - Peng Fan (OSS)
2022-05-22 13:57 ` Alper Nebi Yasak
2022-05-23 7:05 ` Peng Fan (OSS)
2022-05-20 14:10 ` [PATCH V4 6/8] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-05-22 13:57 ` Alper Nebi Yasak
2022-05-23 7:08 ` Peng Fan (OSS)
2022-05-20 14:10 ` [PATCH V4 7/8] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-05-23 21:12 ` Alper Nebi Yasak
2022-05-24 5:50 ` Michael Nazzareno Trimarchi [this message]
2022-05-20 14:10 ` [PATCH V4 8/8] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS Peng Fan (OSS)
2022-05-22 13:57 ` Alper Nebi Yasak
2022-05-23 7:10 ` Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOf5uwm2gwHOQaHLWBSBiD4Ruwb1FL8F4F1rFp-qj3RbWB08dQ@mail.gmail.com \
--to=michael@amarulasolutions.com \
--cc=alpernebiyasak@gmail.com \
--cc=ariel.dalessandro@collabora.com \
--cc=festevam@gmail.com \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ricardo@foundries.io \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.