From: "Munegowda, Keshava" <keshava_mgowda@ti.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: omap-ush-host: Fix build breakage
Date: Mon, 23 Apr 2012 11:47:25 +0530 [thread overview]
Message-ID: <CAP05o4JpwtERvLRitBKztrcr_9N+Kxm+SgU=yptUu9VfL3avkg@mail.gmail.com> (raw)
In-Reply-To: <1335114510-29413-1-git-send-email-agust@denx.de>
On Sun, Apr 22, 2012 at 10:38 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Commit 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 (ARM: OMAP3: USB: Fix
> the EHCI ULPI PHY reset issue) removed #include <linux/gpio.h> which
> indirectly includes 'plat/cpu.h'. This caused build breakage:
>
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'omap_rev'
> drivers/mfd/omap-usb-host.c:525:43: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)
>
> Include <plat/cpu.h> to fix it.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Keshava Munegowda <Keshava_mgowda@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index c8aae66..7e96bb2 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -25,6 +25,7 @@
> #include <linux/clk.h>
> #include <linux/dma-mapping.h>
> #include <linux/spinlock.h>
> +#include <plat/cpu.h>
> #include <plat/usb.h>
> #include <linux/pm_runtime.h>
>
> --
> 1.7.1
>
Yes, this seems correct!
But, on which config you are seeing this error?
regards
keshava
next prev parent reply other threads:[~2012-04-23 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 17:08 [PATCH] mfd: omap-ush-host: Fix build breakage Anatolij Gustschin
2012-04-23 6:17 ` Munegowda, Keshava [this message]
2012-04-23 18:45 ` Anatolij Gustschin
2012-04-24 5:42 ` Munegowda, Keshava
2012-04-28 8:54 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP05o4JpwtERvLRitBKztrcr_9N+Kxm+SgU=yptUu9VfL3avkg@mail.gmail.com' \
--to=keshava_mgowda@ti.com \
--cc=agust@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.