From: Ulf Hansson <ulf.hansson@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 4/5] mmc: sdhci: Fix error paths in sdhci_add_host()
Date: Wed, 13 Apr 2016 13:47:12 +0200 [thread overview]
Message-ID: <CAPDyKFoNMer9n8fxnZ+rqBuRcGNSKwQdYduxpH=EoeiWfQ3v=g@mail.gmail.com> (raw)
In-Reply-To: <570E3069.5010903@intel.com>
On 13 April 2016 at 13:41, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 13/04/16 14:41, Ulf Hansson wrote:
>> [...]
>>
>>>
>>> pr_info("%s: SDHCI controller on %s [%s] using %s\n",
>>> mmc_hostname(mmc), host->hw_name, dev_name(mmc_dev(mmc)),
>>> @@ -3331,15 +3337,27 @@ int sdhci_add_host(struct sdhci_host *host)
>>>
>>> return 0;
>>>
>>> +unled:
>>> #ifdef SDHCI_USE_LEDS_CLASS
>>
>> Shouldn't this ifdef be removed in the earlier patch?
>
> It gets removed in the next patch. Is that what you meant?
Ahh, yes. I reviewed them in the wrong order. :-)
Kind regards
Uffe
next prev parent reply other threads:[~2016-04-13 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 11:25 [PATCH 0/5] mmc: sdhci: Misc patches Adrian Hunter
2016-04-12 11:25 ` [PATCH 1/5] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for Broxton controllers Adrian Hunter
2016-04-12 11:25 ` [PATCH 2/5] mmc: sdhci-acpi: " Adrian Hunter
2016-04-12 11:25 ` [PATCH 3/5] mmc: sdhci: Remove redundant condition Adrian Hunter
2016-04-12 11:25 ` [PATCH 4/5] mmc: sdhci: Fix error paths in sdhci_add_host() Adrian Hunter
2016-04-13 11:41 ` Ulf Hansson
2016-04-13 11:41 ` Adrian Hunter
2016-04-13 11:47 ` Ulf Hansson [this message]
2016-04-12 11:25 ` [PATCH 5/5] mmc: sdhci: Tidy together LED code Adrian Hunter
2016-04-13 11:42 ` Ulf Hansson
2016-04-13 11:45 ` Adrian Hunter
2016-04-13 12:15 ` Ulf Hansson
2016-04-13 12:36 ` Adrian Hunter
2016-04-13 13:45 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFoNMer9n8fxnZ+rqBuRcGNSKwQdYduxpH=EoeiWfQ3v=g@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.