From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdHaKqP (ORCPT ); Thu, 31 Aug 2017 06:46:15 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:36942 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdHaKqN (ORCPT ); Thu, 31 Aug 2017 06:46:13 -0400 X-Google-Smtp-Source: ADKCNb4CuX9xjCyTeNhqKti+GqSKzyNd1MWAroc2ByiN8wG2DTsliarpCCKzXjDQ47Bt31cV6kgiC7FpY6AxHNgJECY= MIME-Version: 1.0 In-Reply-To: <7hr2vsdgj4.fsf@baylibre.com> References: <20170828142915.27020-1-jbrunet@baylibre.com> <7hr2vsdgj4.fsf@baylibre.com> From: Ulf Hansson Date: Thu, 31 Aug 2017 12:46:12 +0200 Message-ID: Subject: Re: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades To: Kevin Hilman Cc: Jerome Brunet , Carlo Caione , "linux-mmc@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 August 2017 at 21:03, Kevin Hilman wrote: > Hi Ulf, > > Ulf Hansson writes: > >> On 28 August 2017 at 16:29, Jerome Brunet wrote: >>> The patchset features several bugfixes, rework and upgrade for the >>> meson-gx MMC driver. >>> >>> The main goal is to improve readability and enable new high speed >>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> >>> SDR104 is not working with a few cards on the p200 and the >>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> of these boards, adding noise to the signal and eventually breaking >>> the communication with some cards. The same cards are working well on a >>> laptop or the nanopi-k2 at 200Mhz. >>> >>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> gxl-s905x-libretech-cc >>> >>> Changes since v2 [1]: >>> * Drop patches 1 to 3: Applied. >>> * Drop patch 4: Debug stuff which should not have been sent. >>> * Added fix to previous patch 3: >>> If the clock register is not initialized before registering the clk >>> with CCF, the framework will complain about an illegal divider value. >>> This had gone unnoticed because it was later fixed by the clock init >>> rework. >>> >>> Ulf, I know it is getting late but it would be nice if patch #1 of >>> this v3 could go with 3 patches you already applied. The rest can >>> wait for the following cycle. >> >> I decided to pick them all, so applied for next! >> > > Just to double-check, so I can plan for the DT patches > accordingly... you are queuing this for v4.14, right? Yes, correct! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades Date: Thu, 31 Aug 2017 12:46:12 +0200 Message-ID: References: <20170828142915.27020-1-jbrunet@baylibre.com> <7hr2vsdgj4.fsf@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-io0-f174.google.com ([209.85.223.174]:38101 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbdHaKqN (ORCPT ); Thu, 31 Aug 2017 06:46:13 -0400 Received: by mail-io0-f174.google.com with SMTP id 81so20220085ioj.5 for ; Thu, 31 Aug 2017 03:46:13 -0700 (PDT) In-Reply-To: <7hr2vsdgj4.fsf@baylibre.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Kevin Hilman Cc: Jerome Brunet , Carlo Caione , "linux-mmc@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On 30 August 2017 at 21:03, Kevin Hilman wrote: > Hi Ulf, > > Ulf Hansson writes: > >> On 28 August 2017 at 16:29, Jerome Brunet wrote: >>> The patchset features several bugfixes, rework and upgrade for the >>> meson-gx MMC driver. >>> >>> The main goal is to improve readability and enable new high speed >>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> >>> SDR104 is not working with a few cards on the p200 and the >>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> of these boards, adding noise to the signal and eventually breaking >>> the communication with some cards. The same cards are working well on a >>> laptop or the nanopi-k2 at 200Mhz. >>> >>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> gxl-s905x-libretech-cc >>> >>> Changes since v2 [1]: >>> * Drop patches 1 to 3: Applied. >>> * Drop patch 4: Debug stuff which should not have been sent. >>> * Added fix to previous patch 3: >>> If the clock register is not initialized before registering the clk >>> with CCF, the framework will complain about an illegal divider value. >>> This had gone unnoticed because it was later fixed by the clock init >>> rework. >>> >>> Ulf, I know it is getting late but it would be nice if patch #1 of >>> this v3 could go with 3 patches you already applied. The rest can >>> wait for the following cycle. >> >> I decided to pick them all, so applied for next! >> > > Just to double-check, so I can plan for the DT patches > accordingly... you are queuing this for v4.14, right? Yes, correct! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Thu, 31 Aug 2017 12:46:12 +0200 Subject: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades In-Reply-To: <7hr2vsdgj4.fsf@baylibre.com> References: <20170828142915.27020-1-jbrunet@baylibre.com> <7hr2vsdgj4.fsf@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30 August 2017 at 21:03, Kevin Hilman wrote: > Hi Ulf, > > Ulf Hansson writes: > >> On 28 August 2017 at 16:29, Jerome Brunet wrote: >>> The patchset features several bugfixes, rework and upgrade for the >>> meson-gx MMC driver. >>> >>> The main goal is to improve readability and enable new high speed >>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> >>> SDR104 is not working with a few cards on the p200 and the >>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> of these boards, adding noise to the signal and eventually breaking >>> the communication with some cards. The same cards are working well on a >>> laptop or the nanopi-k2 at 200Mhz. >>> >>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> gxl-s905x-libretech-cc >>> >>> Changes since v2 [1]: >>> * Drop patches 1 to 3: Applied. >>> * Drop patch 4: Debug stuff which should not have been sent. >>> * Added fix to previous patch 3: >>> If the clock register is not initialized before registering the clk >>> with CCF, the framework will complain about an illegal divider value. >>> This had gone unnoticed because it was later fixed by the clock init >>> rework. >>> >>> Ulf, I know it is getting late but it would be nice if patch #1 of >>> this v3 could go with 3 patches you already applied. The rest can >>> wait for the following cycle. >> >> I decided to pick them all, so applied for next! >> > > Just to double-check, so I can plan for the DT patches > accordingly... you are queuing this for v4.14, right? Yes, correct! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Thu, 31 Aug 2017 12:46:12 +0200 Subject: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades In-Reply-To: <7hr2vsdgj4.fsf@baylibre.com> References: <20170828142915.27020-1-jbrunet@baylibre.com> <7hr2vsdgj4.fsf@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 30 August 2017 at 21:03, Kevin Hilman wrote: > Hi Ulf, > > Ulf Hansson writes: > >> On 28 August 2017 at 16:29, Jerome Brunet wrote: >>> The patchset features several bugfixes, rework and upgrade for the >>> meson-gx MMC driver. >>> >>> The main goal is to improve readability and enable new high speed >>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> >>> SDR104 is not working with a few cards on the p200 and the >>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> of these boards, adding noise to the signal and eventually breaking >>> the communication with some cards. The same cards are working well on a >>> laptop or the nanopi-k2 at 200Mhz. >>> >>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> gxl-s905x-libretech-cc >>> >>> Changes since v2 [1]: >>> * Drop patches 1 to 3: Applied. >>> * Drop patch 4: Debug stuff which should not have been sent. >>> * Added fix to previous patch 3: >>> If the clock register is not initialized before registering the clk >>> with CCF, the framework will complain about an illegal divider value. >>> This had gone unnoticed because it was later fixed by the clock init >>> rework. >>> >>> Ulf, I know it is getting late but it would be nice if patch #1 of >>> this v3 could go with 3 patches you already applied. The rest can >>> wait for the following cycle. >> >> I decided to pick them all, so applied for next! >> > > Just to double-check, so I can plan for the DT patches > accordingly... you are queuing this for v4.14, right? Yes, correct! Kind regards Uffe