From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94FEC433E2 for ; Tue, 23 Mar 2021 19:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87657619AE for ; Tue, 23 Mar 2021 19:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233267AbhCWTNN (ORCPT ); Tue, 23 Mar 2021 15:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233029AbhCWTMo (ORCPT ); Tue, 23 Mar 2021 15:12:44 -0400 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED199C061765 for ; Tue, 23 Mar 2021 12:12:43 -0700 (PDT) Received: by mail-vs1-xe2e.google.com with SMTP id t71so2485768vst.3 for ; Tue, 23 Mar 2021 12:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NziR4wdTwbPmQRK5YhnnRmXhP9symav7D77le3H4K+M=; b=PMVJrfgoW6IO/eykiWrjsd3M2rhVX4YPMZxActq4wpEAmRKoODLJqZ5eOI8hAd3Ui/ kSzrQ3FuaOzZIBiwn4SSeTiH56nva7fJ7jwJArxrKBI9I08bC2iOW/X4AFzNtLAsNXVw fIdYVNCx+ySgZrYUG4o13ipFMssy5VH6uWnpKJyoinFpA+/8heYRsB9WTXd4ONt/Bv7O +LCu9D9LBylKYOceGf33CRSQzA3Vf9iXuF4A9rSuewX9xMRvJ+rKmskixMa6u1701MFN KAZ3CnQdmXTvVit/bpC9d7KazulRxJUeQ0HNNX5bneUJLaxYamCbK0WSNJFdJKmbm+5W bGZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NziR4wdTwbPmQRK5YhnnRmXhP9symav7D77le3H4K+M=; b=b6fzzed7UDHwkGHoYUxQDeaaGPNukshoqnPxIWKPFX2IfnPOM6f6N1mfOyMYJp9xMu uU9RwEpRrTze/RgenJ9XDWvp33k28a+YWbo5RS7TK5zCH74SgSFpB1dPAPiumG4ste8j CZUJ0vdSeBXBfu+n90fS6WYKWWTrZpbM5hr6eDPEVB9xOO8xFNV4a9EeRZBUs0748Bnf ciL0+rzZm1lxTooqArwTEoht1ws++iZd92i+AeQbHsDKyhwGI5hC19Mvq2vCNweMw0WX QWOpkUmF5MwCXzx4g/I6CUQngz5kCKvR4pFlurzNnzWNlvQ8KepntZRjr8p26IorvExm Q55A== X-Gm-Message-State: AOAM532ZT73aA/gqw8tNlcGC64i8HGCfOko5te+qUkQhwuE5LwgH6MNC bCdTTSUcDDE6jxseKnYfEQZ66dVgMYg8sGnG6kYnZA== X-Google-Smtp-Source: ABdhPJzXFydY5TcCz9J1Or2xn4GBkykV9ba3oKyGbccCBa4HxmuOl+Gv/PYBfFODfgfgi/kqTbKgrJDTOyQZhsuqwfY= X-Received: by 2002:a67:77c1:: with SMTP id s184mr4758525vsc.55.1616526762989; Tue, 23 Mar 2021 12:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <4503971.bAhddQ8uqO@pc-42> <5713463.b6Cmjs1FeV@pc-42> In-Reply-To: <5713463.b6Cmjs1FeV@pc-42> From: Ulf Hansson Date: Tue, 23 Mar 2021 20:12:06 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= Cc: linux-wireless , netdev , driverdevel , Linux Kernel Mailing List , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , DTML , Rob Herring , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 23 Mar 2021 at 18:53, J=C3=A9r=C3=B4me Pouiller wrote: > > On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote: > > On Mon, 22 Mar 2021 at 18:14, J=C3=A9r=C3=B4me Pouiller wrote: > > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller wrote: > > > > > > > > > > From: J=C3=A9r=C3=B4me Pouiller > > > > > > > > > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > > > > > --- > > > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++= ++++++ > > > > > 1 file changed, 259 insertions(+) > > > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > > > > > [...] > > > > > > > > > +static const struct sdio_device_id wfx_sdio_ids[] =3D { > > > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILAB= S_WF200) }, > > > > > + { }, > > > > > +}; > > > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > > > + > > > > > +struct sdio_driver wfx_sdio_driver =3D { > > > > > + .name =3D "wfx-sdio", > > > > > + .id_table =3D wfx_sdio_ids, > > > > > + .probe =3D wfx_sdio_probe, > > > > > + .remove =3D wfx_sdio_remove, > > > > > + .drv =3D { > > > > > + .owner =3D THIS_MODULE, > > > > > + .of_match_table =3D wfx_sdio_of_match, > > > > > > > > It's not mandatory to support power management, like system > > > > suspend/resume. However, as this looks like this is a driver for an > > > > embedded SDIO device, you probably want this. > > > > > > > > If that is the case, please assign the dev_pm_ops here and implemen= t > > > > the ->suspend|resume() callbacks. > > > > > > I have no platform to test suspend/resume, so I have only a > > > theoretical understanding of this subject. > > > > I see. > > > > > > > > I understanding is that with the current implementation, the > > > device will be powered off on suspend and then totally reset > > > (including reloading of the firmware) on resume. I am wrong? > > > > You are correct, for a *removable* SDIO card. In this case, the > > mmc/sdio core will remove the corresponding SDIO card/device and its > > corresponding SDIO func devices at system suspend. It will then be > > redetected at system resume (and the SDIO func driver re-probed). > > > > Although, as this is an embedded SDIO device, per definition it's not > > a removable card (MMC_CAP_NONREMOVABLE should be set for the > > corresponding mmc host), the SDIO card will stick around and instead > > the ->suspend|resume() callback needs to be implemented for the SDIO > > func driver. > > If I follow what has been done in other drivers I would write something > like: > > static int wfx_sdio_suspend(struct device *dev) > { > struct sdio_func *func =3D dev_to_sdio_func(dev); > struct wfx_sdio_priv *bus =3D sdio_get_drvdata(func); > > config_reg_write_bits(bus->core, CFG_IRQ_ENABLE_DATA, 0); > // Necessary to keep device firmware in RAM > return sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER); This will tell the mmc/sdio core to keep the SDIO card powered on during system suspend. Thus, it doesn't need to re-initialize it at system resume - and the firmware should not need to be re-programmed. On the other hand, if you don't plan to support system wakeups, it would probably be better to power off the card, to avoid wasting energy while the system is suspended. I assume that means you need to re-program the firmware as well. Normally, it's these kinds of things that need to be managed from a ->resume() callback. > } > > However, why not the implementation below? > > static int wfx_sdio_suspend(struct device *dev) > { > struct sdio_func *func =3D dev_to_sdio_func(dev); > > wfx_sdio_remove(func); I don't know what wfx_sdio_remove() does, but for sure you would need a ->resume() callback to make it possible to restore power/firmware. > return 0; > } > > In both cases, I worry to provide these functions without being able to > test them. Alright, let's simply leave this driver without having the PM callbacks assigned. I guess we can revisit this at some later point. The mmc core will log a message about the missing callbacks, in case someone tries to execute system suspend/resume when the driver has been probed. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D63AC433DB for ; Tue, 23 Mar 2021 19:12:48 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F34619C0 for ; Tue, 23 Mar 2021 19:12:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32F34619C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F297B83C44; Tue, 23 Mar 2021 19:12:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mxEbKDPicR69; Tue, 23 Mar 2021 19:12:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D6EC383FA8; Tue, 23 Mar 2021 19:12:46 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 658701BF841 for ; Tue, 23 Mar 2021 19:12:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 545486085B for ; Tue, 23 Mar 2021 19:12:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bm3NUdD3r6Ay for ; Tue, 23 Mar 2021 19:12:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3FE156065F for ; Tue, 23 Mar 2021 19:12:44 +0000 (UTC) Received: by mail-vs1-xe2a.google.com with SMTP id l13so9980464vst.8 for ; Tue, 23 Mar 2021 12:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NziR4wdTwbPmQRK5YhnnRmXhP9symav7D77le3H4K+M=; b=PMVJrfgoW6IO/eykiWrjsd3M2rhVX4YPMZxActq4wpEAmRKoODLJqZ5eOI8hAd3Ui/ kSzrQ3FuaOzZIBiwn4SSeTiH56nva7fJ7jwJArxrKBI9I08bC2iOW/X4AFzNtLAsNXVw fIdYVNCx+ySgZrYUG4o13ipFMssy5VH6uWnpKJyoinFpA+/8heYRsB9WTXd4ONt/Bv7O +LCu9D9LBylKYOceGf33CRSQzA3Vf9iXuF4A9rSuewX9xMRvJ+rKmskixMa6u1701MFN KAZ3CnQdmXTvVit/bpC9d7KazulRxJUeQ0HNNX5bneUJLaxYamCbK0WSNJFdJKmbm+5W bGZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NziR4wdTwbPmQRK5YhnnRmXhP9symav7D77le3H4K+M=; b=GDggEfrWm0WFdCUKGG0sd83EVwr/7rRJy+TUM3I/MEKZk0jkuID7sVxkrDN5T1S+yO RYjvPpFtHh0ADpfCPijvdNxj61VcMXZG9dmXgSDRLZOc4ADWMzX8neogQR1mMhPDqoAy 8zzz0YbKkoLpj0DyYMeugyRkxCb1NuSDsc1SVUs97gOQ8WJ815mfZ8oTIRoZkjUfP6jQ IxamSRa98FQTiE9GfN/mfjp7wzD24id87mIQeK7cbzg1f2DL82LeynDuyScDTiKHPYGo 6rUkHECSl9Qrt/MMKTKhkoEd3tAHNtxSeBYTFupC0TxliA9qIAYArpjKPXGbtEiA1277 NpiQ== X-Gm-Message-State: AOAM531Bz5artYmWr+Qs5KWzmHgL8Im8vBxgsdgqPEsOhuWgyk/6aIGv ni3Rbi2W04KsjjVUWcgLhOeV1XtK59ya5hp8oEgl4Q== X-Google-Smtp-Source: ABdhPJzXFydY5TcCz9J1Or2xn4GBkykV9ba3oKyGbccCBa4HxmuOl+Gv/PYBfFODfgfgi/kqTbKgrJDTOyQZhsuqwfY= X-Received: by 2002:a67:77c1:: with SMTP id s184mr4758525vsc.55.1616526762989; Tue, 23 Mar 2021 12:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <4503971.bAhddQ8uqO@pc-42> <5713463.b6Cmjs1FeV@pc-42> In-Reply-To: <5713463.b6Cmjs1FeV@pc-42> From: Ulf Hansson Date: Tue, 23 Mar 2021 20:12:06 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , DTML , netdev , linux-wireless , Linux Kernel Mailing List , Rob Herring , Greg Kroah-Hartman , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gVHVlLCAyMyBNYXIgMjAyMSBhdCAxODo1MywgSsOpcsO0bWUgUG91aWxsZXIKPGplcm9tZS5w b3VpbGxlckBzaWxhYnMuY29tPiB3cm90ZToKPgo+IE9uIFR1ZXNkYXkgMjMgTWFyY2ggMjAyMSAx NToxMTo1NiBDRVQgVWxmIEhhbnNzb24gd3JvdGU6Cj4gPiBPbiBNb24sIDIyIE1hciAyMDIxIGF0 IDE4OjE0LCBKw6lyw7RtZSBQb3VpbGxlciA8amVyb21lLnBvdWlsbGVyQHNpbGFicy5jb20+IHdy b3RlOgo+ID4gPiBPbiBNb25kYXkgMjIgTWFyY2ggMjAyMSAxMzoyMDozNSBDRVQgVWxmIEhhbnNz b24gd3JvdGU6Cj4gPiA+ID4gT24gTW9uLCAxNSBNYXIgMjAyMSBhdCAxNDoyNSwgSmVyb21lIFBv dWlsbGVyIDxKZXJvbWUuUG91aWxsZXJAc2lsYWJzLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4g PiA+ID4gRnJvbTogSsOpcsO0bWUgUG91aWxsZXIgPGplcm9tZS5wb3VpbGxlckBzaWxhYnMuY29t Pgo+ID4gPiA+ID4KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IErDqXLDtG1lIFBvdWlsbGVyIDxq ZXJvbWUucG91aWxsZXJAc2lsYWJzLmNvbT4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGRyaXZl cnMvbmV0L3dpcmVsZXNzL3NpbGFicy93ZngvYnVzX3NkaW8uYyB8IDI1OSArKysrKysrKysrKysr KysrKysrKysKPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjU5IGluc2VydGlvbnMoKykKPiA+ ID4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9uZXQvd2lyZWxlc3Mvc2lsYWJzL3dm eC9idXNfc2Rpby5jCj4gPiA+ID4KPiA+ID4gPiBbLi4uXQo+ID4gPiA+Cj4gPiA+ID4gPiArc3Rh dGljIGNvbnN0IHN0cnVjdCBzZGlvX2RldmljZV9pZCB3Znhfc2Rpb19pZHNbXSA9IHsKPiA+ID4g PiA+ICsgICAgICAgeyBTRElPX0RFVklDRShTRElPX1ZFTkRPUl9JRF9TSUxBQlMsIFNESU9fREVW SUNFX0lEX1NJTEFCU19XRjIwMCkgfSwKPiA+ID4gPiA+ICsgICAgICAgeyB9LAo+ID4gPiA+ID4g K307Cj4gPiA+ID4gPiArTU9EVUxFX0RFVklDRV9UQUJMRShzZGlvLCB3Znhfc2Rpb19pZHMpOwo+ ID4gPiA+ID4gKwo+ID4gPiA+ID4gK3N0cnVjdCBzZGlvX2RyaXZlciB3Znhfc2Rpb19kcml2ZXIg PSB7Cj4gPiA+ID4gPiArICAgICAgIC5uYW1lID0gIndmeC1zZGlvIiwKPiA+ID4gPiA+ICsgICAg ICAgLmlkX3RhYmxlID0gd2Z4X3NkaW9faWRzLAo+ID4gPiA+ID4gKyAgICAgICAucHJvYmUgPSB3 Znhfc2Rpb19wcm9iZSwKPiA+ID4gPiA+ICsgICAgICAgLnJlbW92ZSA9IHdmeF9zZGlvX3JlbW92 ZSwKPiA+ID4gPiA+ICsgICAgICAgLmRydiA9IHsKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAu b3duZXIgPSBUSElTX01PRFVMRSwKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAub2ZfbWF0Y2hf dGFibGUgPSB3Znhfc2Rpb19vZl9tYXRjaCwKPiA+ID4gPgo+ID4gPiA+IEl0J3Mgbm90IG1hbmRh dG9yeSB0byBzdXBwb3J0IHBvd2VyIG1hbmFnZW1lbnQsIGxpa2Ugc3lzdGVtCj4gPiA+ID4gc3Vz cGVuZC9yZXN1bWUuIEhvd2V2ZXIsIGFzIHRoaXMgbG9va3MgbGlrZSB0aGlzIGlzIGEgZHJpdmVy IGZvciBhbgo+ID4gPiA+IGVtYmVkZGVkIFNESU8gZGV2aWNlLCB5b3UgcHJvYmFibHkgd2FudCB0 aGlzLgo+ID4gPiA+Cj4gPiA+ID4gSWYgdGhhdCBpcyB0aGUgY2FzZSwgcGxlYXNlIGFzc2lnbiB0 aGUgZGV2X3BtX29wcyBoZXJlIGFuZCBpbXBsZW1lbnQKPiA+ID4gPiB0aGUgLT5zdXNwZW5kfHJl c3VtZSgpIGNhbGxiYWNrcy4KPiA+ID4KPiA+ID4gSSBoYXZlIG5vIHBsYXRmb3JtIHRvIHRlc3Qg c3VzcGVuZC9yZXN1bWUsIHNvIEkgaGF2ZSBvbmx5IGEKPiA+ID4gdGhlb3JldGljYWwgdW5kZXJz dGFuZGluZyBvZiB0aGlzIHN1YmplY3QuCj4gPgo+ID4gSSBzZWUuCj4gPgo+ID4gPgo+ID4gPiBJ IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCB3aXRoIHRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uLCB0 aGUKPiA+ID4gZGV2aWNlIHdpbGwgYmUgcG93ZXJlZCBvZmYgb24gc3VzcGVuZCBhbmQgdGhlbiB0 b3RhbGx5IHJlc2V0Cj4gPiA+IChpbmNsdWRpbmcgcmVsb2FkaW5nIG9mIHRoZSBmaXJtd2FyZSkg b24gcmVzdW1lLiBJIGFtIHdyb25nPwo+ID4KPiA+IFlvdSBhcmUgY29ycmVjdCwgZm9yIGEgKnJl bW92YWJsZSogU0RJTyBjYXJkLiBJbiB0aGlzIGNhc2UsIHRoZQo+ID4gbW1jL3NkaW8gY29yZSB3 aWxsIHJlbW92ZSB0aGUgY29ycmVzcG9uZGluZyBTRElPIGNhcmQvZGV2aWNlIGFuZCBpdHMKPiA+ IGNvcnJlc3BvbmRpbmcgU0RJTyBmdW5jIGRldmljZXMgYXQgc3lzdGVtIHN1c3BlbmQuIEl0IHdp bGwgdGhlbiBiZQo+ID4gcmVkZXRlY3RlZCBhdCBzeXN0ZW0gcmVzdW1lIChhbmQgdGhlIFNESU8g ZnVuYyBkcml2ZXIgcmUtcHJvYmVkKS4KPiA+Cj4gPiBBbHRob3VnaCwgYXMgdGhpcyBpcyBhbiBl bWJlZGRlZCBTRElPIGRldmljZSwgcGVyIGRlZmluaXRpb24gaXQncyBub3QKPiA+IGEgcmVtb3Zh YmxlIGNhcmQgKE1NQ19DQVBfTk9OUkVNT1ZBQkxFIHNob3VsZCBiZSBzZXQgZm9yIHRoZQo+ID4g Y29ycmVzcG9uZGluZyBtbWMgaG9zdCksIHRoZSBTRElPIGNhcmQgd2lsbCBzdGljayBhcm91bmQg YW5kIGluc3RlYWQKPiA+IHRoZSAtPnN1c3BlbmR8cmVzdW1lKCkgY2FsbGJhY2sgbmVlZHMgdG8g YmUgaW1wbGVtZW50ZWQgZm9yIHRoZSBTRElPCj4gPiBmdW5jIGRyaXZlci4KPgo+IElmIEkgZm9s bG93IHdoYXQgaGFzIGJlZW4gZG9uZSBpbiBvdGhlciBkcml2ZXJzIEkgd291bGQgd3JpdGUgc29t ZXRoaW5nCj4gbGlrZToKPgo+ICAgc3RhdGljIGludCB3Znhfc2Rpb19zdXNwZW5kKHN0cnVjdCBk ZXZpY2UgKmRldikKPiAgIHsKPiAgICAgICAgICAgc3RydWN0IHNkaW9fZnVuYyAqZnVuYyA9IGRl dl90b19zZGlvX2Z1bmMoZGV2KTsKPiAgICAgICAgICAgc3RydWN0IHdmeF9zZGlvX3ByaXYgKmJ1 cyA9IHNkaW9fZ2V0X2RydmRhdGEoZnVuYyk7Cj4KPiAgICAgICAgICAgY29uZmlnX3JlZ193cml0 ZV9iaXRzKGJ1cy0+Y29yZSwgQ0ZHX0lSUV9FTkFCTEVfREFUQSwgMCk7Cj4gICAgICAgICAgIC8v IE5lY2Vzc2FyeSB0byBrZWVwIGRldmljZSBmaXJtd2FyZSBpbiBSQU0KPiAgICAgICAgICAgcmV0 dXJuIHNkaW9fc2V0X2hvc3RfcG1fZmxhZ3MoZnVuYywgTU1DX1BNX0tFRVBfUE9XRVIpOwoKVGhp cyB3aWxsIHRlbGwgdGhlIG1tYy9zZGlvIGNvcmUgdG8ga2VlcCB0aGUgU0RJTyBjYXJkIHBvd2Vy ZWQgb24KZHVyaW5nIHN5c3RlbSBzdXNwZW5kLiBUaHVzLCBpdCBkb2Vzbid0IG5lZWQgdG8gcmUt aW5pdGlhbGl6ZSBpdCBhdApzeXN0ZW0gcmVzdW1lIC0gYW5kIHRoZSBmaXJtd2FyZSBzaG91bGQg bm90IG5lZWQgdG8gYmUgcmUtcHJvZ3JhbW1lZC4KCk9uIHRoZSBvdGhlciBoYW5kLCBpZiB5b3Ug ZG9uJ3QgcGxhbiB0byBzdXBwb3J0IHN5c3RlbSB3YWtldXBzLCBpdAp3b3VsZCBwcm9iYWJseSBi ZSBiZXR0ZXIgdG8gcG93ZXIgb2ZmIHRoZSBjYXJkLCB0byBhdm9pZCB3YXN0aW5nCmVuZXJneSB3 aGlsZSB0aGUgc3lzdGVtIGlzIHN1c3BlbmRlZC4gSSBhc3N1bWUgdGhhdCBtZWFucyB5b3UgbmVl ZCB0bwpyZS1wcm9ncmFtIHRoZSBmaXJtd2FyZSBhcyB3ZWxsLiBOb3JtYWxseSwgaXQncyB0aGVz ZSBraW5kcyBvZiB0aGluZ3MKdGhhdCBuZWVkIHRvIGJlIG1hbmFnZWQgZnJvbSBhIC0+cmVzdW1l KCkgY2FsbGJhY2suCgo+ICAgfQo+Cj4gSG93ZXZlciwgd2h5IG5vdCB0aGUgaW1wbGVtZW50YXRp b24gYmVsb3c/Cj4KPiAgIHN0YXRpYyBpbnQgd2Z4X3NkaW9fc3VzcGVuZChzdHJ1Y3QgZGV2aWNl ICpkZXYpCj4gICB7Cj4gICAgICAgICAgIHN0cnVjdCBzZGlvX2Z1bmMgKmZ1bmMgPSBkZXZfdG9f c2Rpb19mdW5jKGRldik7Cj4KPiAgICAgICAgICAgd2Z4X3NkaW9fcmVtb3ZlKGZ1bmMpOwoKSSBk b24ndCBrbm93IHdoYXQgd2Z4X3NkaW9fcmVtb3ZlKCkgZG9lcywgYnV0IGZvciBzdXJlIHlvdSB3 b3VsZCBuZWVkCmEgLT5yZXN1bWUoKSBjYWxsYmFjayB0byBtYWtlIGl0IHBvc3NpYmxlIHRvIHJl c3RvcmUgcG93ZXIvZmlybXdhcmUuCgo+ICAgICAgICAgICByZXR1cm4gMDsKPiAgIH0KPgo+IElu IGJvdGggY2FzZXMsIEkgd29ycnkgdG8gcHJvdmlkZSB0aGVzZSBmdW5jdGlvbnMgd2l0aG91dCBi ZWluZyBhYmxlIHRvCj4gdGVzdCB0aGVtLgoKQWxyaWdodCwgbGV0J3Mgc2ltcGx5IGxlYXZlIHRo aXMgZHJpdmVyIHdpdGhvdXQgaGF2aW5nIHRoZSBQTQpjYWxsYmFja3MgYXNzaWduZWQuIEkgZ3Vl c3Mgd2UgY2FuIHJldmlzaXQgdGhpcyBhdCBzb21lIGxhdGVyIHBvaW50LgoKVGhlIG1tYyBjb3Jl IHdpbGwgbG9nIGEgbWVzc2FnZSBhYm91dCB0aGUgbWlzc2luZyBjYWxsYmFja3MsIGluIGNhc2UK c29tZW9uZSB0cmllcyB0byBleGVjdXRlIHN5c3RlbSBzdXNwZW5kL3Jlc3VtZSB3aGVuIHRoZSBk cml2ZXIgaGFzCmJlZW4gcHJvYmVkLgoKS2luZCByZWdhcmRzClVmZmUKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVs QGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg==