From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BCFC433FE for ; Mon, 6 Sep 2021 17:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D4B860F70 for ; Mon, 6 Sep 2021 17:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243764AbhIFRL6 (ORCPT ); Mon, 6 Sep 2021 13:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243946AbhIFRL6 (ORCPT ); Mon, 6 Sep 2021 13:11:58 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F85BC061757 for ; Mon, 6 Sep 2021 10:10:53 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id j12so12288614ljg.10 for ; Mon, 06 Sep 2021 10:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4mmRqWH9FmfPYxUKvRbn5V1v9mP3NzsGHd5mH5mhOcM=; b=csHzkOvc+wtXwzCLGIGf5fcuc8ANBD823C9xk5KWC5dK+FbKg8vk83BWBEeSrxrllI jzOL5RfckAvDaToS2aF019YLAXyGWQwc2eym1nc0JvJyPoHhWiiZ0md5USZXavRrtT1c awnroW8kr+zHdfkoJ6LW/asKjprklqV+FZyuZDG8we6hQaP1NtJrIFWI2Iz14aHFRPq2 srfx4UDITI1QgOu2GJQG6APK4ex6BM7dmLG+o44Ri8cl18Y7Dxy23u6+IK3tYTGMYoJd mLtsoLdLM3W0ZwhVMB+/dIG6nF/CqRyR1BRGPCAY17gJc3/iHBYuWPrYAiuhd6dCDW/n uxPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4mmRqWH9FmfPYxUKvRbn5V1v9mP3NzsGHd5mH5mhOcM=; b=lNZ+3x+3KLamGYcPLyQftFrbHefk6NvL9oD40or05DRl7Uk25PpuFTAW4Q0FbKJBdy O01pUMOwT8UYSAKKbgZ5RBpDT7yZovwMX0Eyh9os37kOOv+QzXpojL1hbhWle7jApwd3 Gf+NzxBasjqmJcqQpx5K4YykmysxcSR0N2zqpFxKyqRI7CM/iVv+FeK/fMQdGBj4Wv8P wN5/Ta9oFf/9bTVsmyvA1M1o5LS1dnZf1+4j9/tncOAnYszc+Yf1uvkyqk0PyPh7+fIW Po4ZItk/YL0WXoaUcTMND3qivUZOCU4WNzcpKTdSibfoVjAt8Ec23Myu0mFKJxK8iB/L yuMA== X-Gm-Message-State: AOAM5323og7Fh3LJA8pNg/x6w2dMbEyUU0YQscPQHI6yVg+SiaT3l6vr h38NrmZaVPMS5ftUciFf1Z0Nuw38Xsrq3fQYaLoebQ== X-Google-Smtp-Source: ABdhPJysVoEfhX4+GoPgW0jucP/iP8OeiLdfs2kPS3Ae8x/doisyNjE0me2SwVWUxd5suoycyqfgomRweBFiACxh0lk= X-Received: by 2002:a2e:b610:: with SMTP id r16mr11493045ljn.367.1630948251396; Mon, 06 Sep 2021 10:10:51 -0700 (PDT) MIME-Version: 1.0 References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-31-maxime@cerno.tech> In-Reply-To: <20210901091852.479202-31-maxime@cerno.tech> From: Ulf Hansson Date: Mon, 6 Sep 2021 19:10:15 +0200 Message-ID: Subject: Re: [PATCH v2 30/52] dt-bindings: mmc: Convert MMC Card binding to a schema To: Maxime Ripard Cc: DTML , Rob Herring , Frank Rowand , Chen-Yu Tsai , =?UTF-8?Q?Jernej_=C5=A0krabec?= , Linux ARM , linux-sunxi , linux-mmc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 1 Sept 2021 at 11:19, Maxime Ripard wrote: > > MMC Cards can have an optional Device Tree binding to add > non-discoverable properties. > > Now that we have the DT validation in place, let's convert the device > tree bindings for that driver over to a YAML schema. > > Some of these properties were already described in the MMC controller > binding, even though they are not generic and do not apply to any > device, so we took the occasion to fix this. > > Cc: linux-mmc@vger.kernel.org > Cc: Ulf Hansson > Signed-off-by: Maxime Ripard > Queued for v5.16 on the temporary devel branch, thanks! Kind regards Uffe > --- > > Changes from v1: > - Fixed additionalProperties > --- > .../devicetree/bindings/mmc/mmc-card.txt | 30 ------------ > .../devicetree/bindings/mmc/mmc-card.yaml | 48 +++++++++++++++++++ > .../bindings/mmc/mmc-controller.yaml | 6 --- > 3 files changed, 48 insertions(+), 36 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.txt > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.txt b/Documentation/devicetree/bindings/mmc/mmc-card.txt > deleted file mode 100644 > index 8d2d71758907..000000000000 > --- a/Documentation/devicetree/bindings/mmc/mmc-card.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -mmc-card / eMMC bindings > ------------------------- > - > -This documents describes the devicetree bindings for a mmc-host controller > -child node describing a mmc-card / an eMMC, see "Use of Function subnodes" > -in mmc.txt > - > -Required properties: > --compatible : Must be "mmc-card" > --reg : Must be <0> > - > -Optional properties: > --broken-hpi : Use this to indicate that the mmc-card has a broken hpi > - implementation, and that hpi should not be used > - > -Example: > - > -&mmc2 { > - pinctrl-names = "default"; > - pinctrl-0 = <&mmc2_pins_a>; > - vmmc-supply = <®_vcc3v3>; > - bus-width = <8>; > - non-removable; > - > - mmccard: mmccard@0 { > - reg = <0>; > - compatible = "mmc-card"; > - broken-hpi; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.yaml b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > new file mode 100644 > index 000000000000..b17d454442b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mmc-card.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MMC Card / eMMC Generic Device Tree Bindings > + > +maintainers: > + - Ulf Hansson > + > +description: | > + This documents describes the devicetree bindings for a mmc-host controller > + child node describing a mmc-card / an eMMC. > + > +properties: > + compatible: > + const: mmc-card > + > + reg: > + const: 0 > + > + broken-hpi: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Use this to indicate that the mmc-card has a broken hpi > + implementation, and that hpi should not be used. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + mmc { > + #address-cells = <1>; > + #size-cells = <0>; > + > + card@0 { > + compatible = "mmc-card"; > + reg = <0>; > + broken-hpi; > + }; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index 25ac8e200970..513f3c8758aa 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -333,12 +333,6 @@ patternProperties: > subnode describes. A value of 0 denotes the memory SD > function, values from 1 to 7 denote the SDIO functions. > > - broken-hpi: > - $ref: /schemas/types.yaml#/definitions/flag > - description: > - Use this to indicate that the mmc-card has a broken hpi > - implementation, and that hpi should not be used. > - > required: > - reg > > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4A5C433F5 for ; Mon, 6 Sep 2021 17:12:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCD5D60FBF for ; Mon, 6 Sep 2021 17:12:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CCD5D60FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GjnXNIzTurKrViKcJDTe+/5zjjryxfrDFrC/9nIaamo=; b=bigREM5eaoa7AY N4cQbm+1HQx3PO3asQMEO3Kk4TuHAp1uII38XVdc208j1OZEGyi/xmVEqA86KLq8PVoFj6lih1GaK jiQd/ABQnTgSpCWbfXwHlaK+lRWJuhak++A7tXchjn1gmoZRgVFg9ycIXKRpJUzCcrFe436DkHg2e yj+l5QY4YcmY4POlOMwFmOqowxWybLq8uJ08Qo68YPK5TGixJtIY0f81pFZfl1pMMbeW6CN0SC9xB sXU4g6s7DVrnoRa56gL/Jdp9tT7vQyOAp1VVNC7oZ0Q3A7c9jyhChOxNCY1KUSW00OtnWuT+6axhY 4xWJyr8kZHb33bfQjotQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNI9T-001OsN-Gw; Mon, 06 Sep 2021 17:11:23 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNI8z-001Ofo-CM for linux-arm-kernel@lists.infradead.org; Mon, 06 Sep 2021 17:10:55 +0000 Received: by mail-lj1-x22a.google.com with SMTP id g14so12307507ljk.5 for ; Mon, 06 Sep 2021 10:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4mmRqWH9FmfPYxUKvRbn5V1v9mP3NzsGHd5mH5mhOcM=; b=csHzkOvc+wtXwzCLGIGf5fcuc8ANBD823C9xk5KWC5dK+FbKg8vk83BWBEeSrxrllI jzOL5RfckAvDaToS2aF019YLAXyGWQwc2eym1nc0JvJyPoHhWiiZ0md5USZXavRrtT1c awnroW8kr+zHdfkoJ6LW/asKjprklqV+FZyuZDG8we6hQaP1NtJrIFWI2Iz14aHFRPq2 srfx4UDITI1QgOu2GJQG6APK4ex6BM7dmLG+o44Ri8cl18Y7Dxy23u6+IK3tYTGMYoJd mLtsoLdLM3W0ZwhVMB+/dIG6nF/CqRyR1BRGPCAY17gJc3/iHBYuWPrYAiuhd6dCDW/n uxPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4mmRqWH9FmfPYxUKvRbn5V1v9mP3NzsGHd5mH5mhOcM=; b=hfBEewV6vfSVJAjw5UoqVqQA3/ExXFqh9ndSjzSa2eeKOHVZParnL7QvZ4FKLlcIuU 8WJvJWPxNLHYqztsHc2Y1RMD36gUwL3eMtsqX9h6sSRwfhotlctMzSc+zn4vzD3qEbdJ GeQdX8bLfysjjnzbFJurFD5wD2wVF3Yk1vR9i3onNyho6jXQnhS1vPnyTXvcykrHOb8k N7rGGWlnvF7pH1N0soY87Jw3CwYnwCJpHsXtDV8V58BBNHmB4bFSKDo6OoOYRPgRmBp8 p3vKkiHEG/DADg+PhP/iLrUlgiImWIm4lFWq4ojEVlREy5N5s5F1qwOXAv3xAKsn+B82 +58Q== X-Gm-Message-State: AOAM533a73jRFZokYXQlJm8vEWNdpHg70YdtyhV/4HRHUVUm53k92N8g PeIQotvUBpXMrSq1p/e/KmD3TDqPsjmMqR44GqEsPw== X-Google-Smtp-Source: ABdhPJysVoEfhX4+GoPgW0jucP/iP8OeiLdfs2kPS3Ae8x/doisyNjE0me2SwVWUxd5suoycyqfgomRweBFiACxh0lk= X-Received: by 2002:a2e:b610:: with SMTP id r16mr11493045ljn.367.1630948251396; Mon, 06 Sep 2021 10:10:51 -0700 (PDT) MIME-Version: 1.0 References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-31-maxime@cerno.tech> In-Reply-To: <20210901091852.479202-31-maxime@cerno.tech> From: Ulf Hansson Date: Mon, 6 Sep 2021 19:10:15 +0200 Message-ID: Subject: Re: [PATCH v2 30/52] dt-bindings: mmc: Convert MMC Card binding to a schema To: Maxime Ripard Cc: DTML , Rob Herring , Frank Rowand , Chen-Yu Tsai , =?UTF-8?Q?Jernej_=C5=A0krabec?= , Linux ARM , linux-sunxi , linux-mmc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_101053_467765_A78E14C0 X-CRM114-Status: GOOD ( 28.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 1 Sept 2021 at 11:19, Maxime Ripard wrote: > > MMC Cards can have an optional Device Tree binding to add > non-discoverable properties. > > Now that we have the DT validation in place, let's convert the device > tree bindings for that driver over to a YAML schema. > > Some of these properties were already described in the MMC controller > binding, even though they are not generic and do not apply to any > device, so we took the occasion to fix this. > > Cc: linux-mmc@vger.kernel.org > Cc: Ulf Hansson > Signed-off-by: Maxime Ripard > Queued for v5.16 on the temporary devel branch, thanks! Kind regards Uffe > --- > > Changes from v1: > - Fixed additionalProperties > --- > .../devicetree/bindings/mmc/mmc-card.txt | 30 ------------ > .../devicetree/bindings/mmc/mmc-card.yaml | 48 +++++++++++++++++++ > .../bindings/mmc/mmc-controller.yaml | 6 --- > 3 files changed, 48 insertions(+), 36 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.txt > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.txt b/Documentation/devicetree/bindings/mmc/mmc-card.txt > deleted file mode 100644 > index 8d2d71758907..000000000000 > --- a/Documentation/devicetree/bindings/mmc/mmc-card.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -mmc-card / eMMC bindings > ------------------------- > - > -This documents describes the devicetree bindings for a mmc-host controller > -child node describing a mmc-card / an eMMC, see "Use of Function subnodes" > -in mmc.txt > - > -Required properties: > --compatible : Must be "mmc-card" > --reg : Must be <0> > - > -Optional properties: > --broken-hpi : Use this to indicate that the mmc-card has a broken hpi > - implementation, and that hpi should not be used > - > -Example: > - > -&mmc2 { > - pinctrl-names = "default"; > - pinctrl-0 = <&mmc2_pins_a>; > - vmmc-supply = <®_vcc3v3>; > - bus-width = <8>; > - non-removable; > - > - mmccard: mmccard@0 { > - reg = <0>; > - compatible = "mmc-card"; > - broken-hpi; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.yaml b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > new file mode 100644 > index 000000000000..b17d454442b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mmc-card.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MMC Card / eMMC Generic Device Tree Bindings > + > +maintainers: > + - Ulf Hansson > + > +description: | > + This documents describes the devicetree bindings for a mmc-host controller > + child node describing a mmc-card / an eMMC. > + > +properties: > + compatible: > + const: mmc-card > + > + reg: > + const: 0 > + > + broken-hpi: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Use this to indicate that the mmc-card has a broken hpi > + implementation, and that hpi should not be used. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + mmc { > + #address-cells = <1>; > + #size-cells = <0>; > + > + card@0 { > + compatible = "mmc-card"; > + reg = <0>; > + broken-hpi; > + }; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index 25ac8e200970..513f3c8758aa 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -333,12 +333,6 @@ patternProperties: > subnode describes. A value of 0 denotes the memory SD > function, values from 1 to 7 denote the SDIO functions. > > - broken-hpi: > - $ref: /schemas/types.yaml#/definitions/flag > - description: > - Use this to indicate that the mmc-card has a broken hpi > - implementation, and that hpi should not be used. > - > required: > - reg > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel