From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE51FC432BE for ; Tue, 3 Aug 2021 12:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A42AB60F58 for ; Tue, 3 Aug 2021 12:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236045AbhHCM7C (ORCPT ); Tue, 3 Aug 2021 08:59:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235895AbhHCM7B (ORCPT ); Tue, 3 Aug 2021 08:59:01 -0400 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C9EFC061798 for ; Tue, 3 Aug 2021 05:58:50 -0700 (PDT) Received: by mail-ua1-x92e.google.com with SMTP id t25so6275505uar.13 for ; Tue, 03 Aug 2021 05:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZNSRpZlFlkmyaZcGeRCdqzNpmwaM/CsxmQZTU5Q+xqI=; b=JTvNoxAfXZ9vd1+wTKKiK81cryvFYXUGiGJWt11dtugSKCRZzRqEhcPYJix7xbxCp3 YKo8vQZvgq9xZzfTHfarl0LQRITIaB4flkRr46M/PM11DUdJZCYJj4JHzB1m4bqx5bK8 EtJobyfZ5hYhOHAmCcTk1L77+1UWYJBdyJGjdJ30Ntetl239/qIi+Fiv0aETt/cPMddI ms9C8NsZJic+woCQWggmqJrKuEW+FhJ3tl1PWC1C8h6wEZIajpUf5wuiwiZo6WQaNEmA JlftDOWGep6h0KpoD8jIiUEJIHA707wXiVqyP72XfW2jJC1M40uKyybpRAtzIlzWGXYI vljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZNSRpZlFlkmyaZcGeRCdqzNpmwaM/CsxmQZTU5Q+xqI=; b=EoE7hnhjfW1hrTwUieOJVNpiGDwNKNssX8sk0gDeu7ujulaBvee+70Y9+reNcmeF3X pkjk6kkK8K/T8cnNATlBXobWlAJq/tvyVVladm94V1/nqvH6i9VNAjBh8rGvHIm8xPvQ t9GCxkSsR+Su9tfZ86t35oTymFDXWk9IyJ3A//U81XVSebYuJDnOuCdLMF/2U+XtELic 9HWgR35QA6R11ZhgBCful9/4hrV4yB2ThgoPMDe+6rlvaFTZ9JsVz/V7wYkXpAxayWp4 U6hY4N2asuxA9D0HM1NGUapRbkx4C3cmp3VsTmnIBjMdhqvz02UqFogt/7qXFReKHYg4 O9pg== X-Gm-Message-State: AOAM533JKHG2S4/b1Cd+ByFILBzBsRHLuHbXuxx1gUEl03tXWKollpYE qsJ0f5rasmR4BN85fFRyAd0+AVowCn4M35JPcsnCQw== X-Google-Smtp-Source: ABdhPJwmT+9f8+SVTRLGGJ8jMXd1p1owMfyXKEFiXfIxd5UXzXpXp2cbHPwsCzFyYJ/B7mnJE2eGb95SBJDpnGdNpVs= X-Received: by 2002:ab0:6f4b:: with SMTP id r11mr4698819uat.104.1627995529623; Tue, 03 Aug 2021 05:58:49 -0700 (PDT) MIME-Version: 1.0 References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-12-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Tue, 3 Aug 2021 15:58:38 +0300 Message-ID: Subject: Re: [PATCH 11/12] dt-bindings: interrupt-controller: Add IRQ constants for Exynos850 To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, 31 Jul 2021 at 11:45, Krzysztof Kozlowski wrote: > > On 30/07/2021 16:49, Sam Protsenko wrote: > > Add external GIC interrupt constants for SPI[479:0] for Exynos850 SoC. > > Interrupt names were taken from TRM without change, hence double > > underscore in const namings. > > I am not sure what is the benefit of defining these in header. Unlike > other DT consts (e.g. clock IDs) drivers do not us them at all. Using > them in DT does not reduce chance of mistakes in numbers - instead of in > DTS you can make a mistake here in header file. In the same time, they > grow the interrupt property in DTS making it more difficult to read. > > I also did not see anyone else using this approach, so it's not only me > (Marc also find it confusing). > > If vendor kernel did similar, it's not an argument. Samsung LSI /. > vendor kernel has terrible code quality so usually it is not a good example. > Agreed. I'll use IRQ numbers in dts directly, in v2. I probably thought that IRQ header might replace missing public TRM, but that's a poor substitute anyway. > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C375CC4338F for ; Tue, 3 Aug 2021 13:17:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 819B260C41 for ; Tue, 3 Aug 2021 13:17:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 819B260C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gMwqJMCDo/YbROQOi7Nq7DHs+xcpmK0Jcr8egZnWAhs=; b=q02wC82uHdwx2Z Wb7OZaBaroOO7AS3FIJU/FiFIYbUBla/5eXQKw40bboYzUqkfMJlWptQbsOLFrJfDvUEaO7o3F7U7 LzfJG2P+cp4DcZf9dUa3D4AB4IeHy7MAUTFNPUjCCAOv4/ErsSbYPXCxNoVKDC/UAc/JLM1aQ5q9v iC2j5dNMXXFtGKvjWHr/ceY1FUvMS3yilzx8c2oLz7Ukv71NSXITa4aJE5U9bAlB0wYnVrm/4CO8B Aog+aFuBugA0+sfoxrQF3w1ePEeE/q9/HZjnCxjETMmLn9YM+ccG5jAe7vePq/BdgDJWT9n7balm5 7nMcbDc7wf1LiS2SJVEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAuFg-002v8s-Qk; Tue, 03 Aug 2021 13:14:38 +0000 Received: from mail-ua1-x936.google.com ([2607:f8b0:4864:20::936]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAu0R-002nsO-2C for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 12:58:52 +0000 Received: by mail-ua1-x936.google.com with SMTP id n15so8139748uao.6 for ; Tue, 03 Aug 2021 05:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZNSRpZlFlkmyaZcGeRCdqzNpmwaM/CsxmQZTU5Q+xqI=; b=JTvNoxAfXZ9vd1+wTKKiK81cryvFYXUGiGJWt11dtugSKCRZzRqEhcPYJix7xbxCp3 YKo8vQZvgq9xZzfTHfarl0LQRITIaB4flkRr46M/PM11DUdJZCYJj4JHzB1m4bqx5bK8 EtJobyfZ5hYhOHAmCcTk1L77+1UWYJBdyJGjdJ30Ntetl239/qIi+Fiv0aETt/cPMddI ms9C8NsZJic+woCQWggmqJrKuEW+FhJ3tl1PWC1C8h6wEZIajpUf5wuiwiZo6WQaNEmA JlftDOWGep6h0KpoD8jIiUEJIHA707wXiVqyP72XfW2jJC1M40uKyybpRAtzIlzWGXYI vljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZNSRpZlFlkmyaZcGeRCdqzNpmwaM/CsxmQZTU5Q+xqI=; b=Oln4nPmTnMHTxfFMKwbi8v7kW4caXYh3qIFFuRPt9+pPOxB+K+muwbfMuiggYSjzHV nXoCR2y+Q4H/uPN3fZ5YVEpTU5NiUH2LE1dYD9VmS9uJUIz/ogy1+RCCb4myWV5EjyiC oevXuc1sUwAto6siuLFuFj5KFVl2A2LDZyXv71TvFoCxzTS48tEWumHe0Bpr0moP2lYc +4bLlR/IFHPnMu7Y0/mxZK6/0d2HXN4+I0XJG99NUjP3c2zSELB4EYh/EBRIq6QvnF9w XWYEyjXGOZiGu5Mva0u2jYvZmlHZ4esO+JPGlqcYC+dGggxYIrzh2GW72LqJqqilEUSB tONw== X-Gm-Message-State: AOAM533ncS05B2sAs3x9YAJTf9KsAfNqpaN9DLZpvRwH2cz+xA36HrNo mmWUXyN+yY69RjZtoCT/75iGoEpX5NKHMLSZe4wOkw== X-Google-Smtp-Source: ABdhPJwmT+9f8+SVTRLGGJ8jMXd1p1owMfyXKEFiXfIxd5UXzXpXp2cbHPwsCzFyYJ/B7mnJE2eGb95SBJDpnGdNpVs= X-Received: by 2002:ab0:6f4b:: with SMTP id r11mr4698819uat.104.1627995529623; Tue, 03 Aug 2021 05:58:49 -0700 (PDT) MIME-Version: 1.0 References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-12-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Tue, 3 Aug 2021 15:58:38 +0300 Message-ID: Subject: Re: [PATCH 11/12] dt-bindings: interrupt-controller: Add IRQ constants for Exynos850 To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_055851_195515_E0998E38 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 31 Jul 2021 at 11:45, Krzysztof Kozlowski wrote: > > On 30/07/2021 16:49, Sam Protsenko wrote: > > Add external GIC interrupt constants for SPI[479:0] for Exynos850 SoC. > > Interrupt names were taken from TRM without change, hence double > > underscore in const namings. > > I am not sure what is the benefit of defining these in header. Unlike > other DT consts (e.g. clock IDs) drivers do not us them at all. Using > them in DT does not reduce chance of mistakes in numbers - instead of in > DTS you can make a mistake here in header file. In the same time, they > grow the interrupt property in DTS making it more difficult to read. > > I also did not see anyone else using this approach, so it's not only me > (Marc also find it confusing). > > If vendor kernel did similar, it's not an argument. Samsung LSI /. > vendor kernel has terrible code quality so usually it is not a good example. > Agreed. I'll use IRQ numbers in dts directly, in v2. I probably thought that IRQ header might replace missing public TRM, but that's a poor substitute anyway. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel