From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org>
Subject: Re: [PATCH v3 08/15] argo: implement the unregister op
Date: Thu, 10 Jan 2019 12:40:43 +0100
Message-ID: <CAPLaKK6WL6uz__RsTyafVAowLGQ1otcgcSf_DLTLp8-7eJvktg@mail.gmail.com>
References: <1546846968-7372-1-git-send-email-christopher.w.clark@gmail.com>
 <1546846968-7372-9-git-send-email-christopher.w.clark@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6])
 by lists.xenproject.org with esmtp (Exim 4.89)
 (envelope-from <SRS0=5H7G=PS=gmail.com=royger@srs-us1.protection.inumbo.net>)
 id 1ghYhk-00053q-Fb
 for xen-devel@lists.xenproject.org; Thu, 10 Jan 2019 11:40:56 +0000
Received: by mail-ot1-f65.google.com with SMTP id e12so9649839otl.5
 for <xen-devel@lists.xenproject.org>; Thu, 10 Jan 2019 03:40:55 -0800 (PST)
In-Reply-To: <1546846968-7372-9-git-send-email-christopher.w.clark@gmail.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Christopher Clark <christopher.w.clark@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Ross Philipson <ross.philipson@gmail.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Jason Andryuk <jandryuk@gmail.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Julien Grall <julien.grall@arm.com>, Tim Deegan <tim@xen.org>, Daniel Smith <dpsmith@apertussolutions.com>, Rich Persaud <persaur@gmail.com>, Paul Durrant <paul.durrant@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>, James McKenzie <james@bromium.com>, Eric Chanudet <eric.chanudet@gmail.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gTW9uLCBKYW4gNywgMjAxOSBhdCA4OjQ0IEFNIENocmlzdG9waGVyIENsYXJrCjxjaHJpc3Rv
cGhlci53LmNsYXJrQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBUYWtlcyBhIHNpbmdsZSBhcmd1bWVu
dDogYSBoYW5kbGUgdG8gdGhlIHJpbmcgdW5yZWdpc3RyYXRpb24gc3RydWN0LAo+IHdoaWNoIHNw
ZWNpZmllcyB0aGUgcG9ydCBhbmQgcGFydG5lciBkb21haW4gaWQgb3Igd2lsZGNhcmQuCj4KPiBU
aGUgcmluZydzIGVudHJ5IGlzIHJlbW92ZWQgZnJvbSB0aGUgaGFzaHRhYmxlIG9mIHJlZ2lzdGVy
ZWQgcmluZ3M7Cj4gYW55IGVudHJpZXMgZm9yIHBlbmRpbmcgbm90aWZpY2F0aW9ucyBhcmUgcmVt
b3ZlZDsgYW5kIHRoZSByaW5nIGlzCj4gdW5tYXBwZWQgZnJvbSBYZW4ncyBhZGRyZXNzIHNwYWNl
Lgo+Cj4gSWYgdGhlIHJpbmcgaGFkIGJlZW4gcmVnaXN0ZXJlZCB0byBjb21tdW5pY2F0ZSB3aXRo
IGEgc2luZ2xlIHNwZWNpZmllZAo+IGRvbWFpbiAoaWUuIGEgbm9uLXdpbGRjYXJkIHJpbmcpIHRo
ZW4gdGhlIHBhcnRuZXIgZG9tYWluIHN0YXRlIGlzIHJlbW92ZWQKPiBmcm9tIHRoZSBwYXJ0bmVy
IGRvbWFpbidzIGFyZ28gc2VuZF9pbmZvIGhhc2ggdGFibGUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBD
aHJpc3RvcGhlciBDbGFyayA8Y2hyaXN0b3BoZXIuY2xhcms2QGJhZXN5c3RlbXMuY29tPgo+IC0t
LQo+IHYyIGZlZWRiYWNrIEphbjogZHJvcCBjb29raWUsIGltcGxlbWVudCB0ZWFyZG93bgo+IHYy
IGZlZWRiYWNrIEphbjogZHJvcCBtZXNzYWdlIGZyb20gYXJnb19tZXNzYWdlX29wCj4gdjIgc2Vs
ZjogT1ZFUkhBVUwKPiB2MiBzZWxmOiByZW9yZGVyIGxvZ2ljIHRvIHNob3J0ZW4gY3JpdGljYWwg
c2VjdGlvbgo+IHYxICMxMyBmZWVkYmFjayBKYW46IHJldmlzZSB1c2Ugb2YgZ3Vlc3RfaGFuZGxl
X29rYXkgdnMgX19jb3B5IG9wcwo+IHYxIGZlZWRiYWNrIFJvZ2VyLCBKYW46IGRyb3AgYXJnbyBw
cmVmaXggb24gc3RhdGljIGZ1bmN0aW9ucwo+IHYxLDIgZmVlZGJhY2sgSmFuL1JvZ2VyL1BhdWw6
IGRyb3AgZXJybm8gcmV0dXJuaW5nIGd1ZXN0IGFjY2VzcyBmdW5jdGlvbnMKPiB2MSAjNSAoIzE0
KSBmZWVkYmFjayBQYXVsOiB1c2UgY3VycmQgaW4gZG9fYXJnb19tZXNzYWdlX29wCj4gdjEgIzUg
KCMxNCkgZmVlZGJhY2sgUGF1bDogZnVsbCB1c2UgY3VycmQgaW4gYXJnb191bnJlZ2lzdGVyX3Jp
bmcKPiB2MSAjMTMgKCMxNCkgZmVlZGJhY2sgUGF1bDogcmVwbGFjZSBkby93aGlsZSB3aXRoIGdv
dG87IHJlaW5kZW50Cj4gdjEgc2VsZjogYWRkIGJsYW5rIGxpbmVzIGluIHVucmVnaXN0ZXIgY2Fz
ZSBpbiBkb19hcmdvX21lc3NhZ2Vfb3AKPiB2MTogIzEzIGZlZWRiYWNrIEphbjogcHVibGljIG5h
bWVzcGFjZTogcHJlZml4IHdpdGggeGVuCj4gdjE6ICMxMyBmZWVkYmFjayBKYW46IGJsYW5rIGxp
bmUgYWZ0ZXIgb3AgY2FzZSBpbiBkb19hcmdvX21lc3NhZ2Vfb3AKPiB2MTogIzE0IGZlZWRiYWNr
IEphbjogcmVwbGFjZSBkb21haW4gaWQgb3ZlcnJpZGUgd2l0aCB2YWxpZGF0aW9uCj4gdjE6ICMx
OCBmZWVkYmFjayBKYW46IG1lbGQgdGhlIHJpbmcgY291bnQgbGltaXQgaW50byB0aGUgc2VyaWVz
Cj4gdjE6IGZlZWRiYWNrICMxNSBKYW46IHZlcmlmeSB6ZXJvIGluIHVudXNlZCBoeXBlcmNhbGwg
YXJncwo+Cj4gIHhlbi9jb21tb24vYXJnby5jICAgICAgICAgfCAxMTUgKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICB4ZW4vaW5jbHVkZS9wdWJsaWMvYXJn
by5oIHwgIDE5ICsrKysrKysrCj4gIHhlbi9pbmNsdWRlL3hsYXQubHN0ICAgICAgfCAgIDEgKwo+
ICAzIGZpbGVzIGNoYW5nZWQsIDEzNSBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEveGVu
L2NvbW1vbi9hcmdvLmMgYi94ZW4vY29tbW9uL2FyZ28uYwo+IGluZGV4IDExOTg4ZTcuLjU5Y2U4
YzQgMTAwNjQ0Cj4gLS0tIGEveGVuL2NvbW1vbi9hcmdvLmMKPiArKysgYi94ZW4vY29tbW9uL2Fy
Z28uYwo+IEBAIC0zNyw2ICszNyw3IEBAIERFRklORV9YRU5fR1VFU1RfSEFORExFKHhlbl9hcmdv
X2FkZHJfdCk7Cj4gIERFRklORV9YRU5fR1VFU1RfSEFORExFKHhlbl9hcmdvX3BhZ2VfZGVzY3Jf
dCk7Cj4gIERFRklORV9YRU5fR1VFU1RfSEFORExFKHhlbl9hcmdvX3JlZ2lzdGVyX3JpbmdfdCk7
Cj4gIERFRklORV9YRU5fR1VFU1RfSEFORExFKHhlbl9hcmdvX3JpbmdfdCk7Cj4gK0RFRklORV9Y
RU5fR1VFU1RfSEFORExFKHhlbl9hcmdvX3VucmVnaXN0ZXJfcmluZ190KTsKPgo+ICAvKiBYZW4g
Y29tbWFuZCBsaW5lIG9wdGlvbiB0byBlbmFibGUgYXJnbyAqLwo+ICBzdGF0aWMgYm9vbCBfX3Jl
YWRfbW9zdGx5IG9wdF9hcmdvX2VuYWJsZWQ7Cj4gQEAgLTY2Niw2ICs2NjcsMTA1IEBAIHJpbmdf
ZmluZF9pbmZvKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsIGNvbnN0IHN0cnVjdCBhcmdvX3Jpbmdf
aWQgKmlkKQo+ICAgICAgcmV0dXJuIE5VTEw7Cj4gIH0KPgo+ICtzdGF0aWMgc3RydWN0IGFyZ29f
c2VuZF9pbmZvICoKPiArc2VuZF9maW5kX2luZm8oY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgY29u
c3Qgc3RydWN0IGFyZ29fcmluZ19pZCAqaWQpCj4gK3sKPiArICAgIHN0cnVjdCBobGlzdF9ub2Rl
ICpub2RlOwo+ICsgICAgc3RydWN0IGFyZ29fc2VuZF9pbmZvICpzZW5kX2luZm87Cj4gKwo+ICsg
ICAgaGxpc3RfZm9yX2VhY2hfZW50cnkoc2VuZF9pbmZvLCBub2RlLCAmZC0+YXJnby0+c2VuZF9o
YXNoW2hhc2hfaW5kZXgoaWQpXSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUpCj4g
KyAgICB7Cj4gKyAgICAgICAgc3RydWN0IGFyZ29fcmluZ19pZCAqY21waWQgPSAmc2VuZF9pbmZv
LT5pZDsKCkNvbnN0LgoKPiArCj4gKyAgICAgICAgaWYgKCBjbXBpZC0+cG9ydCA9PSBpZC0+cG9y
dCAmJgo+ICsgICAgICAgICAgICAgY21waWQtPmRvbWFpbl9pZCA9PSBpZC0+ZG9tYWluX2lkICYm
Cj4gKyAgICAgICAgICAgICBjbXBpZC0+cGFydG5lcl9pZCA9PSBpZC0+cGFydG5lcl9pZCApCj4g
KyAgICAgICAgewo+ICsgICAgICAgICAgICBhcmdvX2RwcmludGsoInNlbmRfaW5mbz0lcFxuIiwg
c2VuZF9pbmZvKTsKPiArICAgICAgICAgICAgcmV0dXJuIHNlbmRfaW5mbzsKPiArICAgICAgICB9
Cj4gKyAgICB9Cj4gKyAgICBhcmdvX2RwcmludGsoIm5vIHNlbmRfaW5mbyBmb3VuZFxuIik7CgpJ
cyB0aGlzIG1lc3NhZ2UgYWN0dWFsbHkgaGVscGZ1bCB3aXRob3V0IHByaW50aW5nIGFueSBvZiB0
aGUKcGFyYW1ldGVycyBwcm92aWRlZCB0byB0aGUgZnVuY3Rpb24/Cgo+ICsKPiArICAgIHJldHVy
biBOVUxMOwo+ICt9Cj4gKwo+ICtzdGF0aWMgbG9uZwo+ICt1bnJlZ2lzdGVyX3Jpbmcoc3RydWN0
IGRvbWFpbiAqY3VycmQsCgpTYW1lIGFzIHRoZSBjb21tZW50IG1hZGUgb24gdGhlIG90aGVyIHBh
dGNoLCBpZiB0aGlzIHBhcmFtZXRlciBpcyB0aGUKY3VycmVudCBkb21haW4gdGhlcmUncyBubyBu
ZWVkIHRvIHBhc3MgaXQgYXJvdW5kLCBvciBlbHNlIGl0IHNob3VsZCBiZQpuYW1lZCBkIGluc3Rl
YWQgb2YgY3VycmQuCgo+ICsgICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4
ZW5fYXJnb191bnJlZ2lzdGVyX3JpbmdfdCkgdW5yZWdfaG5kKQo+ICt7Cj4gKyAgICB4ZW5fYXJn
b191bnJlZ2lzdGVyX3JpbmdfdCB1bnJlZzsKPiArICAgIHN0cnVjdCBhcmdvX3JpbmdfaWQgcmlu
Z19pZDsKPiArICAgIHN0cnVjdCBhcmdvX3JpbmdfaW5mbyAqcmluZ19pbmZvOwo+ICsgICAgc3Ry
dWN0IGFyZ29fc2VuZF9pbmZvICpzZW5kX2luZm87Cj4gKyAgICBzdHJ1Y3QgZG9tYWluICpkc3Rf
ZCA9IE5VTEw7Cj4gKyAgICBpbnQgcmV0Owo+ICsKPiArICAgIHJldCA9IGNvcHlfZnJvbV9ndWVz
dCgmdW5yZWcsIHVucmVnX2huZCwgMSkgPyAtRUZBVUxUIDogMDsKPiArICAgIGlmICggcmV0ICkK
PiArICAgICAgICBnb3RvIG91dDsKPiArCj4gKyAgICByZXQgPSB1bnJlZy5wYWQgPyAtRUlOVkFM
IDogMDsKPiArICAgIGlmICggcmV0ICkKPiArICAgICAgICBnb3RvIG91dDsKCkkgZG9uJ3Qgc2Vl
IHRoZSBwb2ludCBpbiB0aGUgb3V0IGxhYmVsIHdoZW4geW91IGNvdWxkIGp1c3QgdXNlICdyZXR1
cm4KLUVJTlZBTCcgb3IgLUVGQVVMVCBkaXJlY3RseSBoZXJlIGFuZCBhYm92ZS4KClRoYW5rcywg
Um9nZXIuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY
ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw
czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs