From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 28/50] drm: Remove DRM_WAIT_ON from all drivers Date: Wed, 18 Dec 2013 11:39:27 +1000 Message-ID: References: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch> <1386758111-3446-29-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 02C84FD73B for ; Tue, 17 Dec 2013 17:39:27 -0800 (PST) Received: by mail-ee0-f43.google.com with SMTP id c13so3195316eek.16 for ; Tue, 17 Dec 2013 17:39:27 -0800 (PST) In-Reply-To: <1386758111-3446-29-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 11, 2013 at 8:34 PM, Daniel Vetter wrote: > Since this is all old ums stuff (including the one in the radeon > driver) I've just tried to perfectly replicate the existing semantics. > > Reinventing wait queue code with semantics that differ from all the > standard linux wait functions is just hairy, so now we can get rid of > this and so make sure it'll never again be used. > > Oh and: via futexes ... *shudder* This one worries me, I've had numerous attempts to rip this out in the past and they always changed semantics on some devices and broke stuff. The sneaky timeout is essential for a lot of the hardware http://marc.info/?l=dri-devel&m=111383274225047&w=1 So I think I'd like a few more people to review this one before I go near it again :-) Dave.