From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7B47F2194D3AE for ; Fri, 28 Sep 2018 10:46:32 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id y81-v6so6123290oia.6 for ; Fri, 28 Sep 2018 10:46:32 -0700 (PDT) MIME-Version: 1.0 References: <20180926214433.13512.30289.stgit@localhost.localdomain> <20180926215201.13512.55945.stgit@localhost.localdomain> In-Reply-To: <20180926215201.13512.55945.stgit@localhost.localdomain> From: Dan Williams Date: Fri, 28 Sep 2018 10:46:20 -0700 Message-ID: Subject: Re: [RFC workqueue/driver-core PATCH 5/5] nvdimm: Schedule device registration on node local to the device List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: alexander.h.duyck@linux.intel.com Cc: "Brown, Len" , Linux-pm mailing list , Greg KH , linux-nvdimm , jiangshanlai@gmail.com, Linux Kernel Mailing List , zwisler@kernel.org, Pavel Machek , Tejun Heo , Andrew Morton , "Rafael J. Wysocki" List-ID: On Wed, Sep 26, 2018 at 2:52 PM Alexander Duyck wrote: > > This patch is meant to force the device registration for nvdimm devices to > be closer to the actual device. This is achieved by using either the NUMA > node ID of the region, or of the parent. By doing this we can have > everything above the region based on the region, and everything below the > region based on the nvdimm bus. > > By guaranteeing NUMA locality I see an improvement of as high as 25% for > per-node init of a system with 12TB of persistent memory. > > Signed-off-by: Alexander Duyck Looks good to me. This does have a dependency on the current contents of libnvdimm development tree. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE41C43382 for ; Fri, 28 Sep 2018 17:46:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F7DC20685 for ; Fri, 28 Sep 2018 17:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="yzl2AJ6G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F7DC20685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbeI2ALX (ORCPT ); Fri, 28 Sep 2018 20:11:23 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:43106 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbeI2ALX (ORCPT ); Fri, 28 Sep 2018 20:11:23 -0400 Received: by mail-oi1-f196.google.com with SMTP id s69-v6so6105255oie.10 for ; Fri, 28 Sep 2018 10:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ilgNc6a8XgOReujnZrboH821Vl49z2OUd72qlpAXZhE=; b=yzl2AJ6GE7owhX/ixCGDKqtlefjGHnWSzhlCHTn1BaOfz6v4m687gcYPG5oVkA+1oM 9hBor+LVefDkbKY19H0oEi09EircWaQiuTSNn2pdbkM1d5rhhHYSVZZzLeHmIUUk++M1 MVVZjpQuYOD38vvsfKthTln81DdJp/fniCMNV762zBcXU4VhcO4gfgttymb+bWxp5/av U5VENL68vzGrbXLACoS8DdHj1hqD5V2XKjhYeYqjOBZRdOXu1bYZXYCfKABsGBRNMc/I WmKycjl/QlyPRclZoN/Td+5pPTt+OCsDISqGtJb2W/XWOXcgKHPN+g8NSOQXBlOro+9u i62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ilgNc6a8XgOReujnZrboH821Vl49z2OUd72qlpAXZhE=; b=UZ0XAXXRo5r3abauLdLjYfefDYEsXgGtp3ESVrMxE4HFS3a/EG9HR/SO/w5s7g+W03 r3icIbkU6SsVyDx2oKxGlRiuPMBAL/AJFmOUbmNIbvOH24GyA4oxlDDVlL99AXTlhdex lrQes9F3jGWtJGHGDPKS07207dzmdEtzcfHI0M1+b7OszS/gUKarDg3m471qeHHNd6TX 6q+XrvE6yPYCYuJoLHaZ0APza/iZ1V48LxfKYlNb9a1bUH/KIpRtI5429CYumtGcxlci ockfmUjNIzczllFYerhj5LHVRh0mYlByXW3H1bopCVe+aRizrQdEA6rTeGUmNUNkxqNI bgqw== X-Gm-Message-State: ABuFfoh9Zgh3iTf48VCk8Tx6ejJD7OCBRFgHRrGhMiDHJ5Ripp29TEnx w9IRbJSOjE6NiHY93wu0aCDhmOqJGAUljAOh0NdNNw== X-Google-Smtp-Source: ACcGV63Wh1knkDtbvGIJQDcOFq8y3E4cJvIThpF2sWpbi6dnYJYcI6k8E3HPsKOt5LkpDpR4F/9+UrT4TeKpTra1aIk= X-Received: by 2002:aca:4792:: with SMTP id u140-v6mr6661318oia.215.1538156791809; Fri, 28 Sep 2018 10:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20180926214433.13512.30289.stgit@localhost.localdomain> <20180926215201.13512.55945.stgit@localhost.localdomain> In-Reply-To: <20180926215201.13512.55945.stgit@localhost.localdomain> From: Dan Williams Date: Fri, 28 Sep 2018 10:46:20 -0700 Message-ID: Subject: Re: [RFC workqueue/driver-core PATCH 5/5] nvdimm: Schedule device registration on node local to the device To: alexander.h.duyck@linux.intel.com Cc: linux-nvdimm , Greg KH , Linux-pm mailing list , Linux Kernel Mailing List , Tejun Heo , Andrew Morton , "Brown, Len" , Dave Jiang , "Rafael J. Wysocki" , Vishal L Verma , jiangshanlai@gmail.com, Pavel Machek , zwisler@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 2:52 PM Alexander Duyck wrote: > > This patch is meant to force the device registration for nvdimm devices to > be closer to the actual device. This is achieved by using either the NUMA > node ID of the region, or of the parent. By doing this we can have > everything above the region based on the region, and everything below the > region based on the nvdimm bus. > > By guaranteeing NUMA locality I see an improvement of as high as 25% for > per-node init of a system with 12TB of persistent memory. > > Signed-off-by: Alexander Duyck Looks good to me. This does have a dependency on the current contents of libnvdimm development tree.