From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1401C433E4 for ; Thu, 16 Jul 2020 16:01:03 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 772882064B for ; Thu, 16 Jul 2020 16:01:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="PmM7BFqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 772882064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6E5C811C340FB; Thu, 16 Jul 2020 09:01:03 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::642; helo=mail-ej1-x642.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C782011C32CCB for ; Thu, 16 Jul 2020 09:01:00 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id n26so7144392ejx.0 for ; Thu, 16 Jul 2020 09:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=PmM7BFqw2PSR4FOOXVxXhA2f6W9m437kj4FNos9CDP3AJplZthVDkyvWlsqXdsVzAW IM0jY8Aj2cjRUyQ5//pe2xP0Djmun92aIvQU+RkGKuprB7WpZ6t9y8XW97H8aPkZsSws LauGKXBWtxn+z294PiF58zpqTAMdaJnRkNRZDJaoBHdyv0iIexU9jpq+lDfX70zSDlM/ uuwpQMBzj+gyc/2Gi9ptBI+nur9z9JdfUf8q8QbPcre4pqAcb3Yf2Q8Tt35VJ37cGQ76 IoN3YCs7xA0vUYw1/o3x6BLHfCW/Hf3I81JzZNOwPjM+60sb/ZQZu+tFvmc25pLG3/oe slkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=OoJc18GlIqHt7IsUX3bRI4sGpiEo9y4bYEt08yC4ZUga3tQ/MZ1iPR60XSNrC5Mad+ 4f/IFitzGdHXxS5QZN7WhxOVSB64ZOwvCwkKSSjx9bIiJTwKFSizcOwiOgnwkcjAAobJ jALRmP+AoYraJSeSvAiRcU/xzfyVgqQ6yT/ivJK3njOPtw6KdVQH+wgw6ZPXMo6pGPYM PoKPyw6pGEUzSib6gVf5s7zKCv+8WUe3H/Wt+ThpEZ9/DiQhMsSiGYAXq5zcNnIyfApR Qrjq43rWjq7p7zG0WJ5hGXKOMrNmMNQBUV982f6QAnCgtUcNL8VfcX/Dt1oAVJz3h8k1 SzlA== X-Gm-Message-State: AOAM532tNAlDNKkwDu/bv8BVtKBkj6zyXqh2Vt6doFRYeHjezNNsN9WM 8gjiY5VTocyUzn3UoyaT+tOmSVpSWUvZRwU3sJS++w== X-Google-Smtp-Source: ABdhPJw6daMW61UwPNGt9t0xFJ7BOFzJkc2Eqyf8Rfj0dreUEGgSjFtNL4bh/7oZZRDtti8BDS586JUwVYpyjV4FRCo= X-Received: by 2002:a17:906:6d56:: with SMTP id a22mr4585391ejt.440.1594915258725; Thu, 16 Jul 2020 09:00:58 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457128462.754248.10443613927921016089.stgit@dwillia2-desk3.amr.corp.intel.com> <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> In-Reply-To: <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> From: Dan Williams Date: Thu, 16 Jul 2020 09:00:47 -0700 Message-ID: Subject: Re: [PATCH v2 22/22] device-dax: Introduce 'mapping' devices To: Joao Martins Message-ID-Hash: LLAPE3JDDX6HAV464INEMLBJHPLJKUVI X-Message-ID-Hash: LLAPE3JDDX6HAV464INEMLBJHPLJKUVI X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm , Peter Zijlstra , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jul 16, 2020 at 6:19 AM Joao Martins wrote: > > On 7/12/20 5:28 PM, Dan Williams wrote: > > In support of interrogating the physical address layout of a device with > > dis-contiguous ranges, introduce a sysfs directory with 'start', 'end', > > and 'page_offset' attributes. The alternative is trying to parse > > /proc/iomem, and that file will not reflect the extent layout until the > > device is enabled. > > > > Cc: Vishal Verma > > Signed-off-by: Dan Williams > > --- > > drivers/dax/bus.c | 191 +++++++++++++++++++++++++++++++++++++++++++++ > > drivers/dax/dax-private.h | 14 +++ > > 2 files changed, 203 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > > index f342e36c69a1..8b6c4ddc5f42 100644 > > --- a/drivers/dax/bus.c > > +++ b/drivers/dax/bus.c > > @@ -579,6 +579,167 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id, > > } > > EXPORT_SYMBOL_GPL(alloc_dax_region); > > > > +static void dax_mapping_release(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + > > + ida_free(&dev_dax->ida, mapping->id); > > + kfree(mapping); > > +} > > + > > +static void unregister_dax_mapping(void *data) > > +{ > > + struct device *dev = data; > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + dev_dbg(dev, "%s\n", __func__); > > + > > + device_lock_assert(dax_region->dev); > > + > > + dev_dax->ranges[mapping->range_id].mapping = NULL; > > + mapping->range_id = -1; > > + > > + device_del(dev); > > + put_device(dev); > > +} > > + > > +static struct dev_dax_range *get_dax_range(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + device_lock(dax_region->dev); > > + if (mapping->range_id < 1) { > ^^^^^^^^^^^^^^^^^^^^^ it's 'mapping->range_id < 0' > > Otherwise 'mapping0' sysfs entries won't work. > Disabled ranges use id -1. Whoops, yes. Needs a unit test. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D948AC433DF for ; Thu, 16 Jul 2020 16:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2B902065D for ; Thu, 16 Jul 2020 16:01:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="PmM7BFqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729017AbgGPQBB (ORCPT ); Thu, 16 Jul 2020 12:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728126AbgGPQBA (ORCPT ); Thu, 16 Jul 2020 12:01:00 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1521EC061755 for ; Thu, 16 Jul 2020 09:01:00 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id dp18so7082139ejc.8 for ; Thu, 16 Jul 2020 09:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=PmM7BFqw2PSR4FOOXVxXhA2f6W9m437kj4FNos9CDP3AJplZthVDkyvWlsqXdsVzAW IM0jY8Aj2cjRUyQ5//pe2xP0Djmun92aIvQU+RkGKuprB7WpZ6t9y8XW97H8aPkZsSws LauGKXBWtxn+z294PiF58zpqTAMdaJnRkNRZDJaoBHdyv0iIexU9jpq+lDfX70zSDlM/ uuwpQMBzj+gyc/2Gi9ptBI+nur9z9JdfUf8q8QbPcre4pqAcb3Yf2Q8Tt35VJ37cGQ76 IoN3YCs7xA0vUYw1/o3x6BLHfCW/Hf3I81JzZNOwPjM+60sb/ZQZu+tFvmc25pLG3/oe slkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=BBEr5lcZvh6mVCW5DUQ8BSYv6R/B/vRO2R6ByzAJjJuFuYGPR+RPkdeEfUXdPLgVIU Pv8vRUpAgnda0G7l4G+ADs4OAGb1Z9JyBjL6Uox9Uwm0RJJnwOovqxVv8hQMt0kHYKVQ t6XVPjZiyK0QEjYxNs8quudrd2Zdws1Cm2lNXjJZ1J6BR9uFQtxDIh4m3XabePUIbvxZ yR018c/sYvkqZW0ffaMu2dMQJb9C6BgD+onUe4Uwx9jE4XKuDqUc824WHj05BMmUzy9Q hPRj/fRnGVVzYr3FZMuZmVee+cJQzN5JuGc5yTtbRecIL/lkapCIdP+l2ZYuD7bDLMM7 8x9A== X-Gm-Message-State: AOAM53003jrRr0iZtLudCExO+JTobTfrgYeis97N3b/pminqp/Ly7D5I mpSMfZsS42YhqOm3a6LHo9Fkt+fQaI1SsT94/fSqmA== X-Google-Smtp-Source: ABdhPJw6daMW61UwPNGt9t0xFJ7BOFzJkc2Eqyf8Rfj0dreUEGgSjFtNL4bh/7oZZRDtti8BDS586JUwVYpyjV4FRCo= X-Received: by 2002:a17:906:6d56:: with SMTP id a22mr4585391ejt.440.1594915258725; Thu, 16 Jul 2020 09:00:58 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457128462.754248.10443613927921016089.stgit@dwillia2-desk3.amr.corp.intel.com> <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> In-Reply-To: <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> From: Dan Williams Date: Thu, 16 Jul 2020 09:00:47 -0700 Message-ID: Subject: Re: [PATCH v2 22/22] device-dax: Introduce 'mapping' devices To: Joao Martins Cc: linux-nvdimm , Vishal Verma , Peter Zijlstra , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jul 16, 2020 at 6:19 AM Joao Martins wrote: > > On 7/12/20 5:28 PM, Dan Williams wrote: > > In support of interrogating the physical address layout of a device with > > dis-contiguous ranges, introduce a sysfs directory with 'start', 'end', > > and 'page_offset' attributes. The alternative is trying to parse > > /proc/iomem, and that file will not reflect the extent layout until the > > device is enabled. > > > > Cc: Vishal Verma > > Signed-off-by: Dan Williams > > --- > > drivers/dax/bus.c | 191 +++++++++++++++++++++++++++++++++++++++++++++ > > drivers/dax/dax-private.h | 14 +++ > > 2 files changed, 203 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > > index f342e36c69a1..8b6c4ddc5f42 100644 > > --- a/drivers/dax/bus.c > > +++ b/drivers/dax/bus.c > > @@ -579,6 +579,167 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id, > > } > > EXPORT_SYMBOL_GPL(alloc_dax_region); > > > > +static void dax_mapping_release(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + > > + ida_free(&dev_dax->ida, mapping->id); > > + kfree(mapping); > > +} > > + > > +static void unregister_dax_mapping(void *data) > > +{ > > + struct device *dev = data; > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + dev_dbg(dev, "%s\n", __func__); > > + > > + device_lock_assert(dax_region->dev); > > + > > + dev_dax->ranges[mapping->range_id].mapping = NULL; > > + mapping->range_id = -1; > > + > > + device_del(dev); > > + put_device(dev); > > +} > > + > > +static struct dev_dax_range *get_dax_range(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + device_lock(dax_region->dev); > > + if (mapping->range_id < 1) { > ^^^^^^^^^^^^^^^^^^^^^ it's 'mapping->range_id < 0' > > Otherwise 'mapping0' sysfs entries won't work. > Disabled ranges use id -1. Whoops, yes. Needs a unit test. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33319C433E0 for ; Thu, 16 Jul 2020 16:01:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB03C2065D for ; Thu, 16 Jul 2020 16:01:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="PmM7BFqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB03C2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 682928D001F; Thu, 16 Jul 2020 12:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60A088D0016; Thu, 16 Jul 2020 12:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D1BC8D001F; Thu, 16 Jul 2020 12:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 3384A8D0016 for ; Thu, 16 Jul 2020 12:01:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E3DA51EF1 for ; Thu, 16 Jul 2020 16:01:00 +0000 (UTC) X-FDA: 77044402680.08.bean48_080eae426f03 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id AC6021819E76C for ; Thu, 16 Jul 2020 16:01:00 +0000 (UTC) X-HE-Tag: bean48_080eae426f03 X-Filterd-Recvd-Size: 5563 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 16:01:00 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id f12so7097394eja.9 for ; Thu, 16 Jul 2020 09:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=PmM7BFqw2PSR4FOOXVxXhA2f6W9m437kj4FNos9CDP3AJplZthVDkyvWlsqXdsVzAW IM0jY8Aj2cjRUyQ5//pe2xP0Djmun92aIvQU+RkGKuprB7WpZ6t9y8XW97H8aPkZsSws LauGKXBWtxn+z294PiF58zpqTAMdaJnRkNRZDJaoBHdyv0iIexU9jpq+lDfX70zSDlM/ uuwpQMBzj+gyc/2Gi9ptBI+nur9z9JdfUf8q8QbPcre4pqAcb3Yf2Q8Tt35VJ37cGQ76 IoN3YCs7xA0vUYw1/o3x6BLHfCW/Hf3I81JzZNOwPjM+60sb/ZQZu+tFvmc25pLG3/oe slkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yV3LwwP/SEpzaIEmeMBzbOghkFrbv+sk/VN9onw9N4c=; b=pXGZXN7ENc5Q65fGO6kFC2SrGpVg7LU4U7F8WBSwzKHc3TotszVIBx9SbKB9iiA+Zn 8de15d1RSkHsXz+jM94AJwkzDYNqfUDLwOClMkob0pprUlE+drkb9kMWaZ+PcI5qBqSe aJ+nxxjogZbAVUzVylmLs/jTDz1N9XmsBeTZoF2uKeHQbnEqUnXyjrE8FkP0+rpt4RiB I6va6QI3jMwUNypeSjkCa+0Ma0rsrPULn7Syv3Eu5471REAZ0PlIJnjbqCwvtyKTQOEl MfxsJqee2hgWucHD1O9bWufjnSF71bHd3BcmGhj9URDxr0uzbGn5A7Ft3riDv7j/s0d0 ZlQA== X-Gm-Message-State: AOAM532bvRZoAJZEUiHcAxPdT806l6hv69nI+0LIfZ9nXjJH0R3dDZIl ehWj/GDLXYy0d/RGg3hGppne/g0TCS6PurfzaVZ8Zw== X-Google-Smtp-Source: ABdhPJw6daMW61UwPNGt9t0xFJ7BOFzJkc2Eqyf8Rfj0dreUEGgSjFtNL4bh/7oZZRDtti8BDS586JUwVYpyjV4FRCo= X-Received: by 2002:a17:906:6d56:: with SMTP id a22mr4585391ejt.440.1594915258725; Thu, 16 Jul 2020 09:00:58 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457128462.754248.10443613927921016089.stgit@dwillia2-desk3.amr.corp.intel.com> <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> In-Reply-To: <7ecd1b82-06ab-be49-4b92-ac42caab146c@oracle.com> From: Dan Williams Date: Thu, 16 Jul 2020 09:00:47 -0700 Message-ID: Subject: Re: [PATCH v2 22/22] device-dax: Introduce 'mapping' devices To: Joao Martins Cc: linux-nvdimm , Vishal Verma , Peter Zijlstra , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: AC6021819E76C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 16, 2020 at 6:19 AM Joao Martins wrote: > > On 7/12/20 5:28 PM, Dan Williams wrote: > > In support of interrogating the physical address layout of a device with > > dis-contiguous ranges, introduce a sysfs directory with 'start', 'end', > > and 'page_offset' attributes. The alternative is trying to parse > > /proc/iomem, and that file will not reflect the extent layout until the > > device is enabled. > > > > Cc: Vishal Verma > > Signed-off-by: Dan Williams > > --- > > drivers/dax/bus.c | 191 +++++++++++++++++++++++++++++++++++++++++++++ > > drivers/dax/dax-private.h | 14 +++ > > 2 files changed, 203 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > > index f342e36c69a1..8b6c4ddc5f42 100644 > > --- a/drivers/dax/bus.c > > +++ b/drivers/dax/bus.c > > @@ -579,6 +579,167 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id, > > } > > EXPORT_SYMBOL_GPL(alloc_dax_region); > > > > +static void dax_mapping_release(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + > > + ida_free(&dev_dax->ida, mapping->id); > > + kfree(mapping); > > +} > > + > > +static void unregister_dax_mapping(void *data) > > +{ > > + struct device *dev = data; > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + dev_dbg(dev, "%s\n", __func__); > > + > > + device_lock_assert(dax_region->dev); > > + > > + dev_dax->ranges[mapping->range_id].mapping = NULL; > > + mapping->range_id = -1; > > + > > + device_del(dev); > > + put_device(dev); > > +} > > + > > +static struct dev_dax_range *get_dax_range(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + device_lock(dax_region->dev); > > + if (mapping->range_id < 1) { > ^^^^^^^^^^^^^^^^^^^^^ it's 'mapping->range_id < 0' > > Otherwise 'mapping0' sysfs entries won't work. > Disabled ranges use id -1. Whoops, yes. Needs a unit test.