All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Julian Gindi <juliangindi@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] CodingGuidelines: updating 'rough' rule count
Date: Sun, 12 Apr 2015 20:04:04 -0400	[thread overview]
Message-ID: <CAPig+cS=xBoe-hr5Kwm0N9hBUy4bzN1NoXTcDEwz_4ZwrrXPXA@mail.gmail.com> (raw)
In-Reply-To: <20150412234720.GA37658@Serenity.local>

On Sun, Apr 12, 2015 at 7:47 PM, Julian Gindi <juliangindi@gmail.com> wrote:
> Changed inaccurate count of "rough rules" from three to four.
>
> Signed-off-by: Julian Gindi <juliangindi@gmail.com>
> ---
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 0f8cccf..c422ecd 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -1,5 +1,5 @@
>  Like other projects, we also have some guidelines to keep to the
> -code.  For Git in general, three rough rules are:
> +code.  For Git in general, four rough rules are:

Although this change is technically accurate, this sentence is still a
potential maintenance burden. How about taking a more generic
approach, and saying something like:

    For Git, in general, the rough rules are:

?

>   - Most importantly, we never say "It's in POSIX; we'll happily
>     ignore your needs should your system not conform to it."
> --
> 2.3.5

  reply	other threads:[~2015-04-13  0:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 23:47 [PATCH] CodingGuidelines: updating 'rough' rule count Julian Gindi
2015-04-13  0:04 ` Eric Sunshine [this message]
2015-04-13  4:26   ` [PATCH v2] " Julian Gindi
2015-04-13  5:00     ` Eric Sunshine
2015-04-13  5:04       ` Eric Sunshine
2015-04-13 12:54         ` [PATCH v3] CodingGuidelines: update " Julian Gindi
2015-04-13 17:30           ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cS=xBoe-hr5Kwm0N9hBUy4bzN1NoXTcDEwz_4ZwrrXPXA@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=juliangindi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.