From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0418C433F5 for ; Tue, 12 Apr 2022 11:31:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4663C10E214; Tue, 12 Apr 2022 11:31:01 +0000 (UTC) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7198F10E214 for ; Tue, 12 Apr 2022 11:30:59 +0000 (UTC) Received: by mail-yb1-xb2a.google.com with SMTP id x200so8821202ybe.13 for ; Tue, 12 Apr 2022 04:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=SUoVFIXk4pDqXz8Tq1K1xwH2XlZWTHANCuN+6KitrpI3nIKG2d0pu7xkhSg3nBrfI1 xVAsTmxL6vqGZiOkavmCI6X3wsKyuvOWGmaVW/5JeMpyFInytcQCF0+0d3TOJ8s8cWs+ DmhJpIgUZaoR1eoFXp+Wx000g1S4y1ogcfs+LUkGiRk/HbbCK6L7bNdGtnaToRIBcqnv 77YlMyPmmeMDT8v5adrU7oLY65D6kKA2h4gXNcN+2tRNM9EBaCux4UH8aRvls9E4W1Fp vNd63tq9B6dDowT6+YHjNQ5t+wBQHDRsbRxaQrNy4PZC4Rca7YV8JlIqyFVgjpL3/c4+ ILUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=n2q7QjmImmWZsveDN6jW5LghPFZMGp4yTOZkfz1FlUjCUgWs3C6cZn0ximAHDhBNCg jze9Z2YYnaAa8oy+F3dzOKdsNdZdSMr4U6IOoTLsKJ0O4IKjuwocVzcsSVBAHYz9tfuf Cw4n6Z5EtsPuznT4nDHM9EE1jva7kTeocVo9p7k5pwBRCcrrN+xrdQ7EjyV3kyVfKn/C AwMmuGMmZAzEnl0DSfDriP9cxu8AhsrrHWZ/HsjIHIy83beH6ykPWQ1u8WayBSMJhGc9 HoxFAZ5RpkIPSPoEqO4ZDs5IMkXbnh82nHt9eTQWaZNlxe7moMR0DUUVE0hOcxi/16h+ bKQg== X-Gm-Message-State: AOAM5330yKEJevb7mZPbsv5enCIKPszCfRGkkQP4WTtoz58ZkxpMhcvL ZtoumPZHnJlGbTgO3L2Tg03ZvWwIoK/bB5Qog9/64A== X-Google-Smtp-Source: ABdhPJzaCS5ELmQS0Du4Km9AA/DbhyZFWNBRY9Z4RZEpdJfWE7QMeMYVpX+cQLO72zcuzJ6OCR7NHEZH7VJR/v4kpAU= X-Received: by 2002:a25:b7c8:0:b0:633:5650:781e with SMTP id u8-20020a25b7c8000000b006335650781emr25046546ybj.466.1649763058611; Tue, 12 Apr 2022 04:30:58 -0700 (PDT) MIME-Version: 1.0 References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <5420D26D-34FD-4637-B602-F6271E38BB8D@gmail.com> <20220408080748.GA2387@pengutronix.de> <20220408120021.GO4012@pengutronix.de> <20220411090800.GR4012@pengutronix.de> <5929E7A7-776E-4BCB-92C8-A1CE05774FE3@gmail.com> <20220412075034.GS4012@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Tue, 12 Apr 2022 12:30:46 +0100 Message-ID: Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support To: Piotr Oniszczuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , kernel@pengutronix.de, Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Lucas Stach , Michael Riesch , Peter Geis , Andy Yan , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 12 Apr 2022 at 11:14, Piotr Oniszczuk w= rote: > > Wiadomo=C5=9B=C4=87 napisana przez Lucas Stach = w dniu 12.04.2022, o godz. 10:10: > > 1. The application feeds a wrong modifier list to the GBM > > implementation, as it may have queried another plane in the assumption > > that supported modifiers are uniform across all planes. > > This will be cardinal design error. > (keeping in mind we have multiple producers (GPU/video decoder) and multi= ple consumers (base & overlay DRM planes) > > > > 2. The GBM implementation (Panfrost) actually allocates a surface > > instead of failing the allocation, even if it does not support any > > combination of the provided format and modifier list. > > Testing Sacha patch (see today's email from Sascha) i'm getting > > Qt: EGL Error : Could not create the egl surface: error =3D 0x3009 > > i'm reading this as: Qt tries allocate EGL surface and EGL returns error. > or i'm wrong? Correct, that's EGL_BAD_MATCH. There are very few ways that can happen; by far the most likely is that Qt has chosen an EGLConfig which does not correctly correspond to the format. (If it was an impossible format/modifier combination, then this would be already caught when allocating the gbm_surface.) Either way, it seems quite clear that the VOP2 driver is totally fine here, and that you have a Qt (likely) or Mesa (tbh less likely) issue to debug to get the app working. Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCECEC433F5 for ; Tue, 12 Apr 2022 11:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xdQpBAa7TYIKEFx/aNe2RoGmhcNkYvTEMBHG8AnNu+0=; b=uAYSyNncOqD8E2 rykZRt3mX6zylxuSi+tJlJ6dWbIAc8NhZ86HLvqkYdLykubs8/VEMt3HgybsBXWWTJd+qYUwK0/b3 sBfCgf+9CtbRXc1pwCrzM6WI+ut54gIsvF+2OuUwmAXyJUtURvqcTJtOCjED5qTrLBBZcGOTsOhN3 ca71ibenBAG9VHw64gEwOfUNihCvO8+r+bHhxxZLLTyREn7G9d/2oweAJKQfAoRck2eK05h+rOb5x veK92b5yvWRWQ7KxIQhvLUrBEhOLGUYimSQQmYI1T0xfnQtVed4gBVrh8sS+EcD08aPxQgoR4lpxO e65GgH0pAQdtb/YJQosQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neExm-00DoJ8-3l; Tue, 12 Apr 2022 11:45:38 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEje-00DhmL-Qg for linux-rockchip@lists.infradead.org; Tue, 12 Apr 2022 11:31:09 +0000 Received: by mail-yb1-xb32.google.com with SMTP id h8so2095059ybj.11 for ; Tue, 12 Apr 2022 04:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=SUoVFIXk4pDqXz8Tq1K1xwH2XlZWTHANCuN+6KitrpI3nIKG2d0pu7xkhSg3nBrfI1 xVAsTmxL6vqGZiOkavmCI6X3wsKyuvOWGmaVW/5JeMpyFInytcQCF0+0d3TOJ8s8cWs+ DmhJpIgUZaoR1eoFXp+Wx000g1S4y1ogcfs+LUkGiRk/HbbCK6L7bNdGtnaToRIBcqnv 77YlMyPmmeMDT8v5adrU7oLY65D6kKA2h4gXNcN+2tRNM9EBaCux4UH8aRvls9E4W1Fp vNd63tq9B6dDowT6+YHjNQ5t+wBQHDRsbRxaQrNy4PZC4Rca7YV8JlIqyFVgjpL3/c4+ ILUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=t9GfJSeXxJcYSYX9irsLlxVoQiRpBQGwbtu4dZzFamai28qX9suOGP/b9XjIPw/dVj XlEg1clx0KdhiCnwbCjivl8D537cEb6TI/2xax5Fw1LJE0/K6ctQR1pWqgwxkUpl+ng/ hDUEWalHaepg3vqTrkkpyjsUWD12p5LFMzQBRvGtcYsGpvZwoKxI8WGfy1QVfq6JGc4s 1sQ/8sB2/yNXVooL4Y5bUyy86S8Ey89jK13QJ/+WwUcK8a+NDDlpacXnndLjrP8BR4QX CVG3AtQJCX2ZI4HG0zN3F1hWFzj6eg3/wk+S290qaKT+5gLxtkGWaL8sSYTNCeMM5xP/ fGXQ== X-Gm-Message-State: AOAM531FLvDeqsg3/S72Y8kEKDLtXi+2bPUupNzNuUduvIVynJOoZnzG eRLZIJXrtWpu1FCoP7DyDbwWcyZDsK/jn1Es4OM+yA== X-Google-Smtp-Source: ABdhPJzaCS5ELmQS0Du4Km9AA/DbhyZFWNBRY9Z4RZEpdJfWE7QMeMYVpX+cQLO72zcuzJ6OCR7NHEZH7VJR/v4kpAU= X-Received: by 2002:a25:b7c8:0:b0:633:5650:781e with SMTP id u8-20020a25b7c8000000b006335650781emr25046546ybj.466.1649763058611; Tue, 12 Apr 2022 04:30:58 -0700 (PDT) MIME-Version: 1.0 References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <5420D26D-34FD-4637-B602-F6271E38BB8D@gmail.com> <20220408080748.GA2387@pengutronix.de> <20220408120021.GO4012@pengutronix.de> <20220411090800.GR4012@pengutronix.de> <5929E7A7-776E-4BCB-92C8-A1CE05774FE3@gmail.com> <20220412075034.GS4012@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Tue, 12 Apr 2022 12:30:46 +0100 Message-ID: Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support To: Piotr Oniszczuk Cc: Lucas Stach , "devicetree@vger.kernel.org" , Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Lucas Stach , Michael Riesch , kernel@pengutronix.de, Andy Yan , "linux-arm-kernel@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_043103_056496_14CB6E2D X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMiBBcHIgMjAyMiBhdCAxMToxNCwgUGlvdHIgT25pc3pjenVrIDxwaW90ci5vbmlz emN6dWtAZ21haWwuY29tPiB3cm90ZToKPiA+IFdpYWRvbW/Fm8SHIG5hcGlzYW5hIHByemV6IEx1 Y2FzIFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPiB3IGRuaXUgMTIuMDQuMjAyMiwgbyBn b2R6LiAxMDoxMDoKPiA+IDEuIFRoZSBhcHBsaWNhdGlvbiBmZWVkcyBhIHdyb25nIG1vZGlmaWVy IGxpc3QgdG8gdGhlIEdCTQo+ID4gaW1wbGVtZW50YXRpb24sIGFzIGl0IG1heSBoYXZlIHF1ZXJp ZWQgYW5vdGhlciBwbGFuZSBpbiB0aGUgYXNzdW1wdGlvbgo+ID4gdGhhdCBzdXBwb3J0ZWQgbW9k aWZpZXJzIGFyZSB1bmlmb3JtIGFjcm9zcyBhbGwgcGxhbmVzLgo+Cj4gVGhpcyB3aWxsIGJlIGNh cmRpbmFsIGRlc2lnbiBlcnJvci4KPiAoa2VlcGluZyBpbiBtaW5kIHdlIGhhdmUgbXVsdGlwbGUg cHJvZHVjZXJzIChHUFUvdmlkZW8gZGVjb2RlcikgYW5kIG11bHRpcGxlIGNvbnN1bWVycyAoYmFz ZSAmIG92ZXJsYXkgRFJNIHBsYW5lcykKPgo+Cj4gPiAyLiBUaGUgR0JNIGltcGxlbWVudGF0aW9u IChQYW5mcm9zdCkgYWN0dWFsbHkgYWxsb2NhdGVzIGEgc3VyZmFjZQo+ID4gaW5zdGVhZCBvZiBm YWlsaW5nIHRoZSBhbGxvY2F0aW9uLCBldmVuIGlmIGl0IGRvZXMgbm90IHN1cHBvcnQgYW55Cj4g PiBjb21iaW5hdGlvbiBvZiB0aGUgcHJvdmlkZWQgZm9ybWF0IGFuZCBtb2RpZmllciBsaXN0Lgo+ Cj4gVGVzdGluZyBTYWNoYSBwYXRjaCAoc2VlIHRvZGF5J3MgZW1haWwgZnJvbSBTYXNjaGEpIGkn bSBnZXR0aW5nCj4KPiBRdDogRUdMIEVycm9yIDogQ291bGQgbm90IGNyZWF0ZSB0aGUgZWdsIHN1 cmZhY2U6IGVycm9yID0gMHgzMDA5Cj4KPiBpJ20gcmVhZGluZyB0aGlzIGFzOiBRdCB0cmllcyBh bGxvY2F0ZSBFR0wgc3VyZmFjZSBhbmQgRUdMIHJldHVybnMgZXJyb3IuCj4gb3IgaSdtIHdyb25n PwoKQ29ycmVjdCwgdGhhdCdzIEVHTF9CQURfTUFUQ0guIFRoZXJlIGFyZSB2ZXJ5IGZldyB3YXlz IHRoYXQgY2FuCmhhcHBlbjsgYnkgZmFyIHRoZSBtb3N0IGxpa2VseSBpcyB0aGF0IFF0IGhhcyBj aG9zZW4gYW4gRUdMQ29uZmlnCndoaWNoIGRvZXMgbm90IGNvcnJlY3RseSBjb3JyZXNwb25kIHRv IHRoZSBmb3JtYXQuIChJZiBpdCB3YXMgYW4KaW1wb3NzaWJsZSBmb3JtYXQvbW9kaWZpZXIgY29t YmluYXRpb24sIHRoZW4gdGhpcyB3b3VsZCBiZSBhbHJlYWR5CmNhdWdodCB3aGVuIGFsbG9jYXRp bmcgdGhlIGdibV9zdXJmYWNlLikKCkVpdGhlciB3YXksIGl0IHNlZW1zIHF1aXRlIGNsZWFyIHRo YXQgdGhlIFZPUDIgZHJpdmVyIGlzIHRvdGFsbHkgZmluZQpoZXJlLCBhbmQgdGhhdCB5b3UgaGF2 ZSBhIFF0IChsaWtlbHkpIG9yIE1lc2EgKHRiaCBsZXNzIGxpa2VseSkgaXNzdWUKdG8gZGVidWcg dG8gZ2V0IHRoZSBhcHAgd29ya2luZy4KCkNoZWVycywKRGFuaWVsCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxp c3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94A86C433F5 for ; Tue, 12 Apr 2022 11:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r2SbuGtjAyIyzI+Omnvv0OLNxwYuRVxIRqEznnt/fBA=; b=tf+YAXaYotvKY8 v0LuFtb3NGhG+fmDdNa2jEtqTuzNxXcibdZGMyYjqhwDKyaF9WtZDPFNh12C7mdXEC0ZX23py3p8d dZvRbM81YoRGAUeYQ+5h8mA7TF431r8Vtp3zJ/u1yUlHz1PDTGd2zUmluOsqn03KIGbW2dc2pfS0i lsPiGDquQkZtoWWQHiQMvucPuFkd0lw8zoqKbiQEnoSowfA5yKz14SuLRv286Gful+8XY8l6gC/tm e5b+keOqXsiE5RKYaCqxjPzlLi3Fo8X7GwBCIZK3CfcjUd+p8bgbD4210x/AmhMsvQylBot7CsC1R YY/4lch3k0ctYi1Y3GvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEwu-00DnxJ-Fp; Tue, 12 Apr 2022 11:44:45 +0000 Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEje-00DhmK-NY for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 11:31:09 +0000 Received: by mail-yb1-xb35.google.com with SMTP id v77so14433563ybi.12 for ; Tue, 12 Apr 2022 04:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=SUoVFIXk4pDqXz8Tq1K1xwH2XlZWTHANCuN+6KitrpI3nIKG2d0pu7xkhSg3nBrfI1 xVAsTmxL6vqGZiOkavmCI6X3wsKyuvOWGmaVW/5JeMpyFInytcQCF0+0d3TOJ8s8cWs+ DmhJpIgUZaoR1eoFXp+Wx000g1S4y1ogcfs+LUkGiRk/HbbCK6L7bNdGtnaToRIBcqnv 77YlMyPmmeMDT8v5adrU7oLY65D6kKA2h4gXNcN+2tRNM9EBaCux4UH8aRvls9E4W1Fp vNd63tq9B6dDowT6+YHjNQ5t+wBQHDRsbRxaQrNy4PZC4Rca7YV8JlIqyFVgjpL3/c4+ ILUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=W908PGWJZ7DLia5huLQc4PX1xBY094T4U0juVXJ15rLte6OpZKnywc1FlKyZjl9M7K HrLgFotlEvx72xjUFBpspOARP6C+QCtNL8SvxdBEjNLCciFSF+oyk7cgHYqOv4d0+Rw/ CGPS0pKuL7nm8Fx/vc49I1tsOEm25cMJYnlNRZC0ENAwJ0rwuquX9Py1PgEJhcMaWKsf b0RoGy0kLMTZN+K7RI4ZdCi5wus/hDdpKk0NAXBrNuWlKaAlRP7E5M6InZETdMvR9e5o LqaHdEQzfl+PNYFR77l1mgMUUpDNdxSOZQSnGjMfXBReqogyTokjZWAtH1S0um4rlTiL OF3A== X-Gm-Message-State: AOAM530/xqcJoMdRGDj5M7TSZxoKPsVJfRzFE6FixQ31MzC1EJVt+5fr tBr3XOR9WeeJlkbyrqgOJi/l4Of39nY+aCiJwuAv7g== X-Google-Smtp-Source: ABdhPJzaCS5ELmQS0Du4Km9AA/DbhyZFWNBRY9Z4RZEpdJfWE7QMeMYVpX+cQLO72zcuzJ6OCR7NHEZH7VJR/v4kpAU= X-Received: by 2002:a25:b7c8:0:b0:633:5650:781e with SMTP id u8-20020a25b7c8000000b006335650781emr25046546ybj.466.1649763058611; Tue, 12 Apr 2022 04:30:58 -0700 (PDT) MIME-Version: 1.0 References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <5420D26D-34FD-4637-B602-F6271E38BB8D@gmail.com> <20220408080748.GA2387@pengutronix.de> <20220408120021.GO4012@pengutronix.de> <20220411090800.GR4012@pengutronix.de> <5929E7A7-776E-4BCB-92C8-A1CE05774FE3@gmail.com> <20220412075034.GS4012@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Tue, 12 Apr 2022 12:30:46 +0100 Message-ID: Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support To: Piotr Oniszczuk Cc: Lucas Stach , "devicetree@vger.kernel.org" , Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Lucas Stach , Michael Riesch , kernel@pengutronix.de, Andy Yan , "linux-arm-kernel@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_043103_054471_E606D93F X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMiBBcHIgMjAyMiBhdCAxMToxNCwgUGlvdHIgT25pc3pjenVrIDxwaW90ci5vbmlz emN6dWtAZ21haWwuY29tPiB3cm90ZToKPiA+IFdpYWRvbW/Fm8SHIG5hcGlzYW5hIHByemV6IEx1 Y2FzIFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPiB3IGRuaXUgMTIuMDQuMjAyMiwgbyBn b2R6LiAxMDoxMDoKPiA+IDEuIFRoZSBhcHBsaWNhdGlvbiBmZWVkcyBhIHdyb25nIG1vZGlmaWVy IGxpc3QgdG8gdGhlIEdCTQo+ID4gaW1wbGVtZW50YXRpb24sIGFzIGl0IG1heSBoYXZlIHF1ZXJp ZWQgYW5vdGhlciBwbGFuZSBpbiB0aGUgYXNzdW1wdGlvbgo+ID4gdGhhdCBzdXBwb3J0ZWQgbW9k aWZpZXJzIGFyZSB1bmlmb3JtIGFjcm9zcyBhbGwgcGxhbmVzLgo+Cj4gVGhpcyB3aWxsIGJlIGNh cmRpbmFsIGRlc2lnbiBlcnJvci4KPiAoa2VlcGluZyBpbiBtaW5kIHdlIGhhdmUgbXVsdGlwbGUg cHJvZHVjZXJzIChHUFUvdmlkZW8gZGVjb2RlcikgYW5kIG11bHRpcGxlIGNvbnN1bWVycyAoYmFz ZSAmIG92ZXJsYXkgRFJNIHBsYW5lcykKPgo+Cj4gPiAyLiBUaGUgR0JNIGltcGxlbWVudGF0aW9u IChQYW5mcm9zdCkgYWN0dWFsbHkgYWxsb2NhdGVzIGEgc3VyZmFjZQo+ID4gaW5zdGVhZCBvZiBm YWlsaW5nIHRoZSBhbGxvY2F0aW9uLCBldmVuIGlmIGl0IGRvZXMgbm90IHN1cHBvcnQgYW55Cj4g PiBjb21iaW5hdGlvbiBvZiB0aGUgcHJvdmlkZWQgZm9ybWF0IGFuZCBtb2RpZmllciBsaXN0Lgo+ Cj4gVGVzdGluZyBTYWNoYSBwYXRjaCAoc2VlIHRvZGF5J3MgZW1haWwgZnJvbSBTYXNjaGEpIGkn bSBnZXR0aW5nCj4KPiBRdDogRUdMIEVycm9yIDogQ291bGQgbm90IGNyZWF0ZSB0aGUgZWdsIHN1 cmZhY2U6IGVycm9yID0gMHgzMDA5Cj4KPiBpJ20gcmVhZGluZyB0aGlzIGFzOiBRdCB0cmllcyBh bGxvY2F0ZSBFR0wgc3VyZmFjZSBhbmQgRUdMIHJldHVybnMgZXJyb3IuCj4gb3IgaSdtIHdyb25n PwoKQ29ycmVjdCwgdGhhdCdzIEVHTF9CQURfTUFUQ0guIFRoZXJlIGFyZSB2ZXJ5IGZldyB3YXlz IHRoYXQgY2FuCmhhcHBlbjsgYnkgZmFyIHRoZSBtb3N0IGxpa2VseSBpcyB0aGF0IFF0IGhhcyBj aG9zZW4gYW4gRUdMQ29uZmlnCndoaWNoIGRvZXMgbm90IGNvcnJlY3RseSBjb3JyZXNwb25kIHRv IHRoZSBmb3JtYXQuIChJZiBpdCB3YXMgYW4KaW1wb3NzaWJsZSBmb3JtYXQvbW9kaWZpZXIgY29t YmluYXRpb24sIHRoZW4gdGhpcyB3b3VsZCBiZSBhbHJlYWR5CmNhdWdodCB3aGVuIGFsbG9jYXRp bmcgdGhlIGdibV9zdXJmYWNlLikKCkVpdGhlciB3YXksIGl0IHNlZW1zIHF1aXRlIGNsZWFyIHRo YXQgdGhlIFZPUDIgZHJpdmVyIGlzIHRvdGFsbHkgZmluZQpoZXJlLCBhbmQgdGhhdCB5b3UgaGF2 ZSBhIFF0IChsaWtlbHkpIG9yIE1lc2EgKHRiaCBsZXNzIGxpa2VseSkgaXNzdWUKdG8gZGVidWcg dG8gZ2V0IHRoZSBhcHAgd29ya2luZy4KCkNoZWVycywKRGFuaWVsCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561DAC433F5 for ; Tue, 12 Apr 2022 12:23:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351307AbiDLMZQ (ORCPT ); Tue, 12 Apr 2022 08:25:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349476AbiDLMZH (ORCPT ); Tue, 12 Apr 2022 08:25:07 -0400 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7330474852 for ; Tue, 12 Apr 2022 04:30:59 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id i20so11375157ybj.7 for ; Tue, 12 Apr 2022 04:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=SUoVFIXk4pDqXz8Tq1K1xwH2XlZWTHANCuN+6KitrpI3nIKG2d0pu7xkhSg3nBrfI1 xVAsTmxL6vqGZiOkavmCI6X3wsKyuvOWGmaVW/5JeMpyFInytcQCF0+0d3TOJ8s8cWs+ DmhJpIgUZaoR1eoFXp+Wx000g1S4y1ogcfs+LUkGiRk/HbbCK6L7bNdGtnaToRIBcqnv 77YlMyPmmeMDT8v5adrU7oLY65D6kKA2h4gXNcN+2tRNM9EBaCux4UH8aRvls9E4W1Fp vNd63tq9B6dDowT6+YHjNQ5t+wBQHDRsbRxaQrNy4PZC4Rca7YV8JlIqyFVgjpL3/c4+ ILUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNFVKn/6sR+qJy1xjZwLhojWhMEBJZkIZm88XzONGOA=; b=3Q2ExXQUxiery1wGr2ohAWQkI+vWRM4qrkZreWdLxgagrVPQk5VTFIaECCTh/7lIeD 1TRGlvrDryyFuCuskYTNsZUPOMM3EDMe3mKODHxxvZYJPfk3pBHMTspiZl+DDEoNk03z ErxGEXW/rYBjEICRPaEC7rYy2J8jOM1M+3iNpl7gkUJV8qudsFGUEcMBQYTcaZrewbiq NA1Io6qXuTlaMm34Q9i7OTPn8/YZjr3MDRXhbXcREfn6dDq7KniwnO7cyeQxedxkcjRL aIqzg+ZcnjH/VikBVba6tIZWymQGU5OkM+OaNs63MH2i2g0iDNFg5Slt7ktxle0pwpGp wL7g== X-Gm-Message-State: AOAM530X9fVequXWTyO3KTC6UJ2E7bQ3qVhDD9uDSXQaooRbEpt2YJf1 blSeCjn7PtzLDLVVUalyXV/WhAb+Jj1N6g77pqB+Jw== X-Google-Smtp-Source: ABdhPJzaCS5ELmQS0Du4Km9AA/DbhyZFWNBRY9Z4RZEpdJfWE7QMeMYVpX+cQLO72zcuzJ6OCR7NHEZH7VJR/v4kpAU= X-Received: by 2002:a25:b7c8:0:b0:633:5650:781e with SMTP id u8-20020a25b7c8000000b006335650781emr25046546ybj.466.1649763058611; Tue, 12 Apr 2022 04:30:58 -0700 (PDT) MIME-Version: 1.0 References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <5420D26D-34FD-4637-B602-F6271E38BB8D@gmail.com> <20220408080748.GA2387@pengutronix.de> <20220408120021.GO4012@pengutronix.de> <20220411090800.GR4012@pengutronix.de> <5929E7A7-776E-4BCB-92C8-A1CE05774FE3@gmail.com> <20220412075034.GS4012@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Tue, 12 Apr 2022 12:30:46 +0100 Message-ID: Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support To: Piotr Oniszczuk Cc: Lucas Stach , "devicetree@vger.kernel.org" , Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Lucas Stach , Michael Riesch , kernel@pengutronix.de, Andy Yan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 12 Apr 2022 at 11:14, Piotr Oniszczuk w= rote: > > Wiadomo=C5=9B=C4=87 napisana przez Lucas Stach = w dniu 12.04.2022, o godz. 10:10: > > 1. The application feeds a wrong modifier list to the GBM > > implementation, as it may have queried another plane in the assumption > > that supported modifiers are uniform across all planes. > > This will be cardinal design error. > (keeping in mind we have multiple producers (GPU/video decoder) and multi= ple consumers (base & overlay DRM planes) > > > > 2. The GBM implementation (Panfrost) actually allocates a surface > > instead of failing the allocation, even if it does not support any > > combination of the provided format and modifier list. > > Testing Sacha patch (see today's email from Sascha) i'm getting > > Qt: EGL Error : Could not create the egl surface: error =3D 0x3009 > > i'm reading this as: Qt tries allocate EGL surface and EGL returns error. > or i'm wrong? Correct, that's EGL_BAD_MATCH. There are very few ways that can happen; by far the most likely is that Qt has chosen an EGLConfig which does not correctly correspond to the format. (If it was an impossible format/modifier combination, then this would be already caught when allocating the gbm_surface.) Either way, it seems quite clear that the VOP2 driver is totally fine here, and that you have a Qt (likely) or Mesa (tbh less likely) issue to debug to get the app working. Cheers, Daniel