From: Himadri Pandya <himadri18.07@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: driverdev-devel@linuxdriverproject.org
Subject: Re: rtl8192e: need help with variable naming convention
Date: Sat, 12 Jan 2019 22:26:55 -0800 [thread overview]
Message-ID: <CAPnhUpaMyR8tWt+OGqnUUB0kH__tMf5SFE6eTLfJRCH8MCW_NQ@mail.gmail.com> (raw)
In-Reply-To: <20190107105214.GA31559@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
Tried but it resulted in a compilation error. So renaming it with a
different name (channel_array[ ]) instead.
Thank you.
- Himadri
On Mon, Jan 7, 2019 at 2:52 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote:
> > Hello,
> >
> > I'm getting started with device drivers. And as a starter, I'm working on
> > some clean-up patches. I'm particularly targeting to rename a structure
> > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning
> "Avoid
> > CamelCase". According to the coding style, it should be converted to
> > "channel_plan". But the code contains a function argument with the same
> > name "channel_plan". Should I then rename the array to something like
> > "channel_name_"? I'm sorry for asking such a silly question. But I want
> to
> > know if renaming it in such a ways fits in the convention before I make
> the
> > change.
>
> A structure name is different from a function name, so odds are you can
> just do this with no problems. Try it and find out!
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 1610 bytes --]
prev parent reply other threads:[~2019-01-13 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 10:34 rtl8192e: need help with variable naming convention Himadri Pandya
2019-01-07 10:45 ` Himadri Pandya
2019-01-07 10:52 ` Greg KH
2019-01-07 13:03 ` Dan Carpenter
2019-01-13 6:31 ` Himadri Pandya
2019-01-14 10:51 ` Dan Carpenter
2019-01-14 12:09 ` Himadri Pandya
2019-01-14 12:37 ` Dan Carpenter
2019-01-15 8:03 ` Himadri Pandya
2019-01-13 6:26 ` Himadri Pandya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnhUpaMyR8tWt+OGqnUUB0kH__tMf5SFE6eTLfJRCH8MCW_NQ@mail.gmail.com \
--to=himadri18.07@gmail.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.