From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 19 Mar 2017 20:30:04 -0600 Subject: [U-Boot] [PATCH v1] mmc: sdhci: SDHCI controllers also need power In-Reply-To: <20170315182521.4359-1-andriy.shevchenko@linux.intel.com> References: <20170315182521.4359-1-andriy.shevchenko@linux.intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy, On 15 March 2017 at 12:25, Andy Shevchenko wrote: > On some systems SDHCI controllers may be powered off and it's required > to bring them on before accessing. > > SDHCI generic driver currently lacks any mean of doing it. Call the same > board_power_mmc_init() at sdhci_init() stage. > > Signed-off-by: Andy Shevchenko > --- > drivers/mmc/sdhci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index 93cefd89cd..54a7e379ff 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -469,6 +469,8 @@ static int sdhci_init(struct mmc *mmc) > { > struct sdhci_host *host = mmc->priv; > > + board_mmc_power_init(); You should be using driver model for this (CONFIG_DM_MMC*). So either get the power supply from the device tree and enable it, or do this in the board code. > + > sdhci_reset(host, SDHCI_RESET_ALL); > > if ((host->quirks & SDHCI_QUIRK_32BIT_DMA_ADDR) && !aligned_buffer) { > -- > 2.11.0 > Regards, Simon