All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] spl: rk3399: disable DDR security regions for SPL (for DMA in dw_mmc)
Date: Fri, 31 Mar 2017 22:23:38 -0600	[thread overview]
Message-ID: <CAPnjgZ0Tc1+bhNKr_mjd=YoMvXtCbxASyibpVwF0sitf-96o-w@mail.gmail.com> (raw)
In-Reply-To: <1490815229-40730-1-git-send-email-philipp.tomsich@theobroma-systems.com>

On 29 March 2017 at 13:20, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> The RK3399 hangs during DMA of the Designware MMC controller, when
> performing DMA-based transactions in SPL due to the DDR security settings
> left behind by the BootROM (i.e. accesses to the first MB of DRAM are
> restricted... however, the DMA is likely to target this first MB, as it
> transfers from/to the stack).
>
> System security is not affected, as the final security configuration is
> performed by the ATF, which is executed after the SPL stage.
>
> With this fix in place, we can now drop 'fifo-mode' in the DTS for the
> RK3399-Q7 (Puma).
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
> Changes in v3:
> - replaces the work-around (i.e. falling back to fifo-mode in SPL) with
>   a permanent fix
>
>  arch/arm/mach-rockchip/rk3399-board-spl.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Acked-by: Simon Glass <sjg@chromium.org>

  parent reply	other threads:[~2017-04-01  4:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 19:20 [U-Boot] [PATCH v3 1/2] spl: rk3399: disable DDR security regions for SPL (for DMA in dw_mmc) Philipp Tomsich
2017-03-29 19:20 ` [U-Boot] [PATCH v3 2/2] dts: rk3399-puma: disable 'fifo-mode' in sdmmc Philipp Tomsich
2017-04-01  4:23   ` Simon Glass
2017-04-14 10:15     ` Simon Glass
2017-03-30  3:22 ` [U-Boot] [PATCH v3 1/2] spl: rk3399: disable DDR security regions for SPL (for DMA in dw_mmc) Kever Yang
2017-04-01  4:23 ` Simon Glass [this message]
2017-04-14 10:15   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0Tc1+bhNKr_mjd=YoMvXtCbxASyibpVwF0sitf-96o-w@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.