From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A277C4338F for ; Mon, 2 Aug 2021 19:22:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EFE0604D7 for ; Mon, 2 Aug 2021 19:22:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0EFE0604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDDA483403; Mon, 2 Aug 2021 21:22:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FfYQ8KMX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D2B078343B; Mon, 2 Aug 2021 21:22:14 +0200 (CEST) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE84C83434 for ; Mon, 2 Aug 2021 21:22:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x32b.google.com with SMTP id l4-20020a05600c1d04b02902506f89ad2dso529860wms.1 for ; Mon, 02 Aug 2021 12:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QtZFYQFbqD8oTHtxWAUjrZA9clVpzKFef8ctBeAulXY=; b=FfYQ8KMXvt/L7lg6pGQEBjJhHjbeVSoCSUowCVqMdyk0xr0d/1jZUcdIa3E6owE7Dr er1VDOyeVTSp1e+/OgP1XlJ3A3VKjNVP7wv+sg2LtE8Hsi+GhdHrZZ6dolD01L3aHLEh IvE2kfQulU7tvjPonuWXYZQUFE6IHgrA6HveI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QtZFYQFbqD8oTHtxWAUjrZA9clVpzKFef8ctBeAulXY=; b=UKB1Myea7Kmh+9aC76RkWoUZpyIzWDk7Nlv2RklByv5po50H2iYRrsEsk9j7dRGy9B xW7Svpt0sHHb+x8LEh75DE1fzh45jIPXjv3YETPtHS9HX+MZkPksuG79PPkiVMngNTed s5//brYrCriTG0JPSWGO7hc395ROXRgcw/1KM1V9tyffrtuHFF3eD2aZwPwxC/nNpgq5 8QwWmA5kT0sQLUQxn7oq5/TnU4KUY9sflCDx7yQEjtvFma0PADmthB8weYpSxTXVrgbd iYITLFu9OhzUEXjx2B0pwQT8WaCSIkjsEJ1XhcamcN7uJotlY+gN3EO3V8tlMnFMd75p GNHg== X-Gm-Message-State: AOAM533nb2as6EUXGgRShBRKFnrhsyAezoSYe/ukA6ihwTgg4/bTBPae 5sjFrkaWrU/H+ikajylxtAgO44Ru00bkIB90E9xoFg== X-Google-Smtp-Source: ABdhPJw6cLjx575cneZiRedIP4gpgqFt4euapFqT4Q+kuX0f7zWsNxSYnXtLLkaM9+nufdTEEYbQUE5Zr6Q/CK346Lc= X-Received: by 2002:a1c:7515:: with SMTP id o21mr426964wmc.65.1627932130157; Mon, 02 Aug 2021 12:22:10 -0700 (PDT) MIME-Version: 1.0 References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> In-Reply-To: <20210802131838.21097-12-pali@kernel.org> From: Simon Glass Date: Mon, 2 Aug 2021 13:21:58 -0600 Message-ID: Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Tom Rini , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Mon, 2 Aug 2021 at 07:20, Pali Roh=C3=A1r wrote: > > Header file version.h does not use anything from timestamp.h. Including o= f > timestamp.h has side effect which cause recompiling object file at every > make run because timestamp.h changes at every run. > > So remove timestamp.h from version.h and include timestamp.h in files > which needs it. > > This change reduce recompilation time of final U-Boot binary when U-Boot > source files were not changed as less source files needs to be recompiled= . > > Signed-off-by: Pali Roh=C3=A1r > --- > arch/arm/mach-rockchip/tpl.c | 4 ++++ > board/work-microwave/work_92105/work_92105_display.c | 1 + > cmd/version.c | 1 + > common/spl/spl.c | 4 ++++ > drivers/rtc/emul_rtc.c | 2 +- > include/version.h | 2 -- > 6 files changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass I assume we do actually want to regenerate the timestamp when U-Boot builds, even if nothing has changed. Is that right? It could be confusing otherwise, as people cannot 'update' the banner without making a trivial change. Regards, SImon