From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Mon, 21 Oct 2019 16:53:58 -0600
Subject: [U-Boot] [PATCH v3 104/108] x86: apollolake: Add P2SB driver
In-Reply-To: <CAHp75Vev7kKyVbi_=eBL8fXu1POEZZTxP4pHiVAJY2TvBsH4Kw@mail.gmail.com>
References: <20191021033913.220758-22-sjg@chromium.org>
 <20191021033913.220758-99-sjg@chromium.org>
 <CAHp75Vev7kKyVbi_=eBL8fXu1POEZZTxP4pHiVAJY2TvBsH4Kw@mail.gmail.com>
Message-ID: <CAPnjgZ1CKcB1-37Lq2B2CopbOPJ4cjpjSbGSQubtjkzc3gHHdQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Andy,

On Mon, 21 Oct 2019 at 02:49, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Mon, Oct 21, 2019 at 7:14 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Adds a driver for the apollolake Primary-to-sideband bus. This supports
> > various child devices. It supposed both device tree and of-platdata.
>
> > +static int apl_p2sb_probe(struct udevice *dev)
> > +{
> > +       if (spl_phase() == PHASE_TPL)
> > +               return apl_p2sb_early_init(dev);
>
> > +       else if (spl_phase() == PHASE_SPL)
>
> Redundant 'else' (recommended to check for a such in the entire series)

This is a style thing. I like the else so that it is clear that we
have two options. I could use a switch() but then it needs to have a
'default' which is ugly.
>
> > +               return apl_p2sb_spl_init(dev);
> > +
> > +       return 0;
> > +}

Regards,
Simon