From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Tue, 19 Mar 2019 09:22:48 +0800
Subject: [U-Boot] [PATCH] misc: fs_loader: Replace label with DT phandle
In-Reply-To: <1552278507.10151.1.camel@intel.com>
References: <1550212526-30510-1-git-send-email-tien.fong.chee@intel.com>
 <1551184624.11124.2.camel@intel.com>
 <CAPnjgZ1Uechr+s+LoHrrokm7BJ=QgGUYv_A=kPYrxwac_HsQ2Q@mail.gmail.com>
 <1552278507.10151.1.camel@intel.com>
Message-ID: <CAPnjgZ1j06hyGM0NBqjX2_ru6Bh=Q7tWwiKaqMr=5c3+2wX=Qg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tien Fong,

On Mon, 11 Mar 2019 at 12:28, Chee, Tien Fong <tien.fong.chee@intel.com> wrote:
>
> On Sun, 2019-03-10 at 15:51 -0600, Simon Glass wrote:
> > Hi Tien Fong,
> >
> > On Tue, 26 Feb 2019 at 05:37, Chee, Tien Fong <tien.fong.chee@intel.c
> > om> wrote:
> > >
> > >
> > > On Fri, 2019-02-15 at 14:35 +0800, tien.fong.chee at intel.com wrote:
> > > >
> > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > >
> > > > In previously label which will be expanded to the node's full
> > > > path
> > > > was
> > > > used, and now replacing label with most commonly used DT phandle.
> > > > The
> > > > codes were changed accordingly to the use of DT phandle and
> > > > supporting
> > > > multiple instances.
> > > >
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > ---
> > > >  doc/driver-model/fs_firmware_loader.txt |   58
> > > > +++++++++++++++++++++++++------
> > > >  drivers/misc/fs_loader.c                |   36 ++++++++---------
> > > > --
> > > >  2 files changed, 62 insertions(+), 32 deletions(-)
> > This seems OK to me, but I think this feature needs a test.
> Yes, i have ran the test passed with FPGA driver.

No I mean that you should add a test in test/py/tests

Regards,
Simon