From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62380C4167B for ; Wed, 9 Dec 2020 16:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E06F23C41 for ; Wed, 9 Dec 2020 16:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730461AbgLIQmO (ORCPT ); Wed, 9 Dec 2020 11:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729877AbgLIQmB (ORCPT ); Wed, 9 Dec 2020 11:42:01 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55934C061794 for ; Wed, 9 Dec 2020 08:41:21 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id y17so2440172wrr.10 for ; Wed, 09 Dec 2020 08:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G7EU11PHgFsJFA5nDKbU03Fk+7GyGqDKScGIXgeNQqU=; b=eG+oWcIvbvjeSujB8w9rC9FysPL6rBXwMAfVo+NMk/6Vn5Myb8MwqqPgOooFPsZ/uV F3mZu/o6uqakiRyeYYzyVDrlewRY41v1pg/KMxL2jGhKoZO8r32FikNzZL9F7NnxW2xT WtfBARKMIm2z1zU5M6Bvhn4czPwUeXdSJm0Xg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G7EU11PHgFsJFA5nDKbU03Fk+7GyGqDKScGIXgeNQqU=; b=NpKvJBhZ1tFs7xvttZkvOy1Xhs3fXtktUpkQ2gokfOhALZNDMXoLN0VcXC5NA7Hi1P RsrqfJ3fdDxLWEaRtOIy6hkE4NpZpSnFMaTzIPqodt/U52gKUymEmTUZGit64/EqbOGy qNtoOLzPPB9ZT8XkC3tlEFuMicPtT3kfc79N1kgu31ym4hrrjNhDvTTmwJhNSUZedXZj rL4LHm49cz9d9SXdCaDP40rjP0tlUS7KInHZoKaPMjkViQR6GDPMg62ATMTTqLGkNi3i MF0rTpxYS3ehD+I9bJQq4Eft5Mrx/rr26BBpdgzNU0JeLdmr+eNHVGT97jpGLIOFlHOd DPHA== X-Gm-Message-State: AOAM531eAlssMFGxgETT0U24vDEyR06J590zQucrVCuZt9uSni3thHHs nEbvY8/NCkK9a0eV96RdiMBO1z7WuL7v0UO/MU0iLA== X-Google-Smtp-Source: ABdhPJxEl7OMQ/htwgbOiYGTRVp2/9MuAsCc5a1dKA3v6HasSTKSz48ecmPqg7FmN5ROLORNuwCpkQnYAmtTmfvAthU= X-Received: by 2002:adf:82c8:: with SMTP id 66mr3598316wrc.420.1607532079884; Wed, 09 Dec 2020 08:41:19 -0800 (PST) MIME-Version: 1.0 References: <20201204193540.3047030-1-swboyd@chromium.org> <20201204193540.3047030-2-swboyd@chromium.org> In-Reply-To: <20201204193540.3047030-2-swboyd@chromium.org> From: Simon Glass Date: Wed, 9 Dec 2020 09:41:08 -0700 Message-ID: Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_spi: Don't overwrite spi::mode To: Stephen Boyd Cc: Mark Brown , lk , linux-spi@vger.kernel.org, Benson Leung , linux-arm-msm@vger.kernel.org, Enric Balletbo i Serra , Gwendal Grignou , Douglas Anderson , Alexandru M Stan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 4 Dec 2020 at 12:35, Stephen Boyd wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly > SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle > when the device is probed when it shouldn't change, confusing the driver > and making it fail to probe. Drop the assignment and let the spi core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass > Cc: Gwendal Grignou > Reviewed-by: Douglas Anderson > Tested-by: Douglas Anderson > Acked-by: Enric Balletbo i Serra > Cc: Alexandru M Stan > Signed-off-by: Stephen Boyd > --- > drivers/platform/chrome/cros_ec_spi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass > > > diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c > index dfa1f816a45f..f9df218fc2bb 100644 > --- a/drivers/platform/chrome/cros_ec_spi.c > +++ b/drivers/platform/chrome/cros_ec_spi.c > @@ -742,7 +742,6 @@ static int cros_ec_spi_probe(struct spi_device *spi) > int err; > > spi->bits_per_word = 8; > - spi->mode = SPI_MODE_0; > spi->rt = true; > err = spi_setup(spi); > if (err < 0) > -- > https://chromeos.dev >