All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c
Date: Mon, 26 Sep 2011 12:13:50 -0700	[thread overview]
Message-ID: <CAPnjgZ2dPOcB5Aa=GGHJyO09uLADGtrLLNek2=Ts-AB+EOvr0Q@mail.gmail.com> (raw)
In-Reply-To: <201109262110.14195.marek.vasut@gmail.com>

Hi Marek,

On Mon, Sep 26, 2011 at 12:10 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Monday, September 26, 2011 09:01:16 PM Simon Glass wrote:
>> Hi Marek,
>>
>>
>> The assignment to i I was referring to is here:
>>
>> ? ? ? if (length == 1) {
>> ? ? ? ? ? ? ? if (size == 4) {
>> ? ? ? ? ? ? ? ? ? ? ? longp = (uint *)addr;
>> ? ? ? ? ? ? ? ? ? ? ? for (;;)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? i = *longp;
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ^^^ this line
>>
>> ? ? ? ? ? ? ? }
>> ? ? ? ? ? ? ? if (size == 2) {
>> ? ? ? ? ? ? ? ? ? ? ? shortp = (ushort *)addr;
>> ? ? ? ? ? ? ? ? ? ? ? for (;;)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? i = *shortp;
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ^^^ this line
>>
>> ? ? ? ? ? ? ? }
>> ? ? ? ? ? ? ? cp = (u_char *)addr;
>> ? ? ? ? ? ? ? for (;;)
>> ? ? ? ? ? ? ? ? ? ? ? i = *cp;
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ^^^ this line
>>
>> ? ? ? }
>>
>> I was wondering if we need to assign to i? The output code appears
>> unchanged with my compiler if the 'i =' is removed.
>
> Oh, right ... this can be removed. That code seems quite legacy and in a urgent
> need of cleanup. Shall we wrap this change into this patch or do a subsequent
> one ?

I'm sure you know better than me, but it feels like a separate commit
if only because your commit msg is about GCC 4.6 warnings.

Regards,
Simon

>
> Cheers

  reply	other threads:[~2011-09-26 19:13 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  0:26 [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-26  0:26 ` [U-Boot] [PATCH 2/7 RESEND] GCC4.6: Remove unused "port" variable in cmd_usb.c Marek Vasut
2011-09-26  3:40   ` Mike Frysinger
2011-09-26  0:26 ` [U-Boot] [PATCH 3/7] GCC4.6: Squash warning in cmd_flash.c Marek Vasut
2011-10-01 21:25   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 4/7] GCC4.6: Squash warning in cmd_nvedit.c Marek Vasut
2011-09-26  3:39   ` Mike Frysinger
2011-09-26  3:40   ` Mike Frysinger
2011-09-26 18:15   ` Simon Glass
2011-10-01 21:26   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 5/7] GCC4.6: Squash warnings in lcd.c Marek Vasut
2011-10-01 21:26   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 6/7] GCC4.6: Squash warnings in ipu_disp.c Marek Vasut
2011-10-01 21:27   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c Marek Vasut
2011-09-26  3:41   ` Mike Frysinger
2011-09-26  7:25     ` Wolfgang Denk
2011-09-26  9:03       ` Marek Vasut
2011-09-26 16:10         ` Mike Frysinger
2011-09-26 17:31           ` Marek Vasut
2011-09-26 18:03             ` Wolfgang Denk
2011-09-26 18:29               ` Marek Vasut
2011-09-26 18:49                 ` Wolfgang Denk
2011-09-26 19:52                 ` Mike Frysinger
2011-09-26 18:05   ` Simon Glass
2011-09-26 18:24     ` Marek Vasut
2011-09-26 18:29       ` Simon Glass
2011-09-26 18:34         ` Marek Vasut
2011-09-26 19:01           ` Simon Glass
2011-09-26 19:10             ` Marek Vasut
2011-09-26 19:13               ` Simon Glass [this message]
2011-10-01 21:27   ` Wolfgang Denk
2011-09-26  2:39 ` [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Fabio Estevam
2011-09-26  9:04   ` Marek Vasut
2011-09-26 11:28     ` Wolfgang Denk
2011-09-26  3:41 ` Mike Frysinger
2011-09-26 17:36 ` [U-Boot] [PATCH 1/7 V3] " Marek Vasut
2011-10-01 21:20   ` Wolfgang Denk
2011-10-02 18:36     ` Wolfgang Denk
2011-10-02 19:08       ` Marek Vasut
2011-10-02 22:50         ` Marek Vasut
2011-10-03 18:32 ` [U-Boot] [PATCH 1/7 V2] " Marek Vasut
2011-10-03 18:36   ` Wolfgang Denk
2011-10-03 18:42     ` Marek Vasut
2011-10-03 22:58       ` Marek Vasut
2011-10-04 12:18     ` Marek Vasut
2011-10-04 19:06       ` Marek Vasut
2011-10-04 19:23         ` Wolfgang Denk
2011-10-04 19:46         ` Mike Frysinger
2011-10-04 20:44           ` Wolfgang Denk
2011-10-04 20:58             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2dPOcB5Aa=GGHJyO09uLADGtrLLNek2=Ts-AB+EOvr0Q@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.