From: Simon Glass <sjg@chromium.org>
To: Wolfgang Denk <wd@denx.de>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var
Date: Sun, 24 Oct 2021 13:53:43 -0600 [thread overview]
Message-ID: <CAPnjgZ2jSD_ZWnEQjLRcHkNVdW8qkMCd3ssQjPv8-M1AvUcbDw@mail.gmail.com> (raw)
In-Reply-To: <3343692.1634309144@gemini.denx.de>
Hi Wolfgang,
On Fri, 15 Oct 2021 at 08:45, Wolfgang Denk <wd@denx.de> wrote:
>
> Dear Simon Glass,
>
> In message <20211014182257.468649-6-sjg@chromium.org> you wrote:
> > This has different semantics in different places. Go with the bootm method
> > and put it in a common function so that the behaviour is consistent in
> > U-Boot. Update the docs.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Suggested-by: Wolfgang Denk <wd@denx.de>
>
> It should be noted that this commit changes the behaviour of U-Boot
> for "autostart" users, thus it has the potential of breaking
> existent systems.
>
> The problematic cases are in do_bootelf() [cmd/elf.c] and
> do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this
> is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change.
>
> Or am I missing something?
Just to reply here, I sent an updated patch explaining that this does
in fact change behaviour, but only in a case that seems safe enough.
Regards,
Simon
prev parent reply other threads:[~2021-10-24 19:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:22 [PATCH v6 0/7] env: Allow environment in text files Simon Glass
2021-10-14 18:22 ` [PATCH v6 1/7] binman: Allow timeout to occur in the image or its section Simon Glass
2021-10-14 18:22 ` [PATCH v6 2/7] sandbox: Drop distro_boot Simon Glass
2021-10-14 18:22 ` [PATCH v6 3/7] doc: Move environment documentation to rST Simon Glass
2021-10-14 18:22 ` [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-15 14:32 ` Wolfgang Denk
2021-10-15 15:15 ` Simon Glass
2021-10-18 11:58 ` Wolfgang Denk
2021-10-18 13:37 ` Tom Rini
2021-10-18 14:10 ` Wolfgang Denk
2021-10-18 14:24 ` Tom Rini
2021-10-19 10:33 ` Wolfgang Denk
2021-10-18 18:12 ` Simon Glass
2021-10-19 10:38 ` Wolfgang Denk
2021-10-18 18:12 ` Simon Glass
2021-10-19 10:46 ` Wolfgang Denk
2021-10-19 14:11 ` Simon Glass
2021-10-19 16:09 ` Wolfgang Denk
2021-10-19 16:14 ` Simon Glass
2021-10-14 18:22 ` [PATCH v6 5/7] sandbox: Use a text-based environment Simon Glass
2021-10-14 18:22 ` [PATCH v6 6/7] doc: Improve environment documentation Simon Glass
2021-10-14 18:22 ` [PATCH v6 7/7] bootm: Tidy up use of autostart env var Simon Glass
2021-10-15 14:45 ` Wolfgang Denk
2021-10-24 19:53 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ2jSD_ZWnEQjLRcHkNVdW8qkMCd3ssQjPv8-M1AvUcbDw@mail.gmail.com \
--to=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.