From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8963DC433F5 for ; Thu, 21 Oct 2021 20:17:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A732360FC1 for ; Thu, 21 Oct 2021 20:17:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A732360FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6AEFD83458; Thu, 21 Oct 2021 22:17:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="UQG5JOoS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5477283311; Thu, 21 Oct 2021 22:17:31 +0200 (CEST) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81AD7831D3 for ; Thu, 21 Oct 2021 22:17:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x929.google.com with SMTP id r22so3513364uat.11 for ; Thu, 21 Oct 2021 13:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=USstL3ifdpQ4vtqk8ybNrN2UCni3LCCJ74yzvANnArk=; b=UQG5JOoSx9uPnSS51FLn22yIIJJkdGMFxh/StVuHZ4YXcufvznJs1y93mgvHe/OVNE cXPNzDgE38sV75mfFrWEfw0A/bUce/hBURpglGhcNiP7UxD0jG812AqcUmlMGqAcTxQ9 wNXQotbUZWNA03OYWgxiqYPDTNxANZ8TN4kOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=USstL3ifdpQ4vtqk8ybNrN2UCni3LCCJ74yzvANnArk=; b=ceAIGz49v3Qx6cT8j9AmnytMOxAHLJgwGxhNOzlUEo8KSlWOwqTJAPAR0gzBOUmogx aO2Fh6LNaPoZhibpVFAG8HJotZEXvrmfoM8x5wPWr1OSMQHcPmW/yDcljwfb8JvgJGv6 o4rjUwExnuuonWuY/4thDCzuV0MHBdTkhmUkGAqbxGxhuA3hrmvOizyiL6fCXU+qb17M 9BsKtJclg1vxO2sN0xlKqJI41IizG/EEQ4a5LctoiSwvrwASwsbEAjyu2CU2GkI0ZaHR IuhYRBY+7h7+ZSFUsf4njtL0m/z7K5COmbKg6aN9S0l+zZPgyDcbZobDN+jv+OOLSxv/ i66w== X-Gm-Message-State: AOAM5335i8GbydyCbLvyMhTbZvgCpJ6OWNmgTgUOwp12DNQMfC8tjrED NEWiZocMu+O4lKCXqwAAjYzrxCq7qBVmQQB0+3MHpQ== X-Google-Smtp-Source: ABdhPJzOGZIJ2I2K/IFFb+Vwz/+caI7a31tng/G6NlcXf3wfyGVe+8rTRMKmfSoS8367qmtSCMP3Whz5/c9KYItTjpo= X-Received: by 2002:a05:6102:3577:: with SMTP id bh23mr9451342vsb.8.1634847445993; Thu, 21 Oct 2021 13:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20210819034033.1617201-1-sjg@chromium.org> <20210818214022.10.I42087e8088f8d9fb704821d73f17d7ae246a2e69@changeid> <20210916184039.GA2826@bill-the-cat> <20210918131628.GL8579@bill-the-cat> In-Reply-To: From: Simon Glass Date: Thu, 21 Oct 2021 14:17:14 -0600 Message-ID: Subject: Re: [PATCH 10/11] sandbox: mmc: Support a backing file To: Tom Rini Cc: U-Boot Mailing List , Jaehoon Chung , Peng Fan Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Sun, 19 Sept 2021 at 21:18, Simon Glass wrote: > > Hi Tom, > > On Sat, 18 Sept 2021 at 10:31, Simon Glass wrote: > > > > Hi Tom, > > > > On Sat, 18 Sept 2021 at 07:16, Tom Rini wrote: > > > > > > On Sat, Sep 18, 2021 at 03:34:54AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu, 16 Sept 2021 at 12:40, Tom Rini wrote: > > > > > > > > > > On Wed, Aug 18, 2021 at 09:40:32PM -0600, Simon Glass wrote: > > > > > > > > > > > Provide a way for sandbox MMC to present data from a backing file. This > > > > > > allows a filesystem to be created on the host and easily served via an > > > > > > emulated mmc device. > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > Reviewed-by: Jaehoon Chung > > > > > > --- > > > > > > > > > > > > doc/device-tree-bindings/mmc/sandbox,mmc.txt | 18 ++++++++ > > > > > > drivers/mmc/sandbox_mmc.c | 46 ++++++++++++++++---- > > > > > > 2 files changed, 55 insertions(+), 9 deletions(-) > > > > > > create mode 100644 doc/device-tree-bindings/mmc/sandbox,mmc.txt > > > > > > > > > > As is, this breaks how I've always run pytests on sandbox. > > > > > > > > How does it break it? Do you get an error? The feature is supposed to > > > > be optional. > > > > > > Without doing anything to enable it, a few of the mmc unit tests failed. > > > I don't have the logs handy right now (I made that sometimes bad > > > decision to test 2 series at once, and now I'm waiting a bit more on > > > final feedback on the changes the timestamp cleanup needed before I push > > > that + the rest of this series). > > > > Oh dear, I will take a look and see what is going on there. > > The problem seems to me something going wrong with malloc(). I'm not > really sure what but I have seen it before. Basically the mallinfo > struct becomes corrupted somehow and from there everything goes > haywire. It actually happens today in normal operation, but somehow it > doesn't cause problems. I looked at it a while back and did not make > progress. > > Anyway I will see if I can dig into it again. Actually i did figure this out. Partly is was a calculation issue but mostly it was not unmapping the memory after running, which causes problems when it is 25MB each time. Regards, Simon