From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 512A6C433F5 for ; Thu, 25 Nov 2021 00:16:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D489E837A5; Thu, 25 Nov 2021 01:14:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="iPlaHToS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2D83282FDE; Thu, 25 Nov 2021 01:13:09 +0100 (CET) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E60B382F89 for ; Thu, 25 Nov 2021 01:13:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x234.google.com with SMTP id bj13so8782137oib.4 for ; Wed, 24 Nov 2021 16:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDybKptpj61YxX7KfT0rQiHlWY93p6Cg5UGhHYxRTko=; b=iPlaHToS7DUbZqBNCVaJMzbUl1d6tO2YiPEbQmy+41nycS6DIW8xzQru4tA06IhVXg xmvV5NN6NS42gxlTk+Tq2emUibsqNnvJcSwh/1IIGROHGjRV+fGFtBFEwLSWU2mhYFIg PRetxQiENhaVAFhZ+R+kt36Sb+3JgGpA7brHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDybKptpj61YxX7KfT0rQiHlWY93p6Cg5UGhHYxRTko=; b=q1p4kaXf+EiOes6VozGbFZmCq5o4+GpjH0to3Lse2ckqXyhFem7JyRiuyj/SU/YbV3 VJRHW8f+wfFjhUwm08Vc2Nt+WEk0f54e3SupZXmeCQkmiVzeIrs0VD0DoRXDvCBl3eot ugPD3G3E27tUn3YCS7fsexRC6wavw3ZAwf7j5DDBpN53buX/DC1l0lMptFDqKpYbM67Z 4SpdikmVmW+y9+TOJL0Q5dDB+qrnvG4uyRSOABt35pGSEb66m+7rhYuHHOSR+395GebM WRp59oAN95WF0Ala0ULa/GmvQdcaWjxWxKFcdijiC6gTspxnNE9LJ5/vjxxVZ6eaBoyF 6HiA== X-Gm-Message-State: AOAM533xfpkW6Fzwn3J2O6fSNa//OeT8FupnTZ1q1Ne1wdiqkHZMoawf 2AlN3/07yNDWf2JcBAi7Ma3KF34kH/pi9skII9loJw== X-Google-Smtp-Source: ABdhPJyHW3KAWfw9IXSSN37Hj45tTwNEV8NfTsPnuz/FBfKocculqPQ6k1WwlLSFyElJwvk7yqdHO2xtZRKcWTuwRHA= X-Received: by 2002:a05:6808:3a3:: with SMTP id n3mr10884300oie.81.1637799182285; Wed, 24 Nov 2021 16:13:02 -0800 (PST) MIME-Version: 1.0 References: <20211117175215.24262-1-philippe.reynes@softathome.com> <20211117175215.24262-2-philippe.reynes@softathome.com> In-Reply-To: <20211117175215.24262-2-philippe.reynes@softathome.com> From: Simon Glass Date: Wed, 24 Nov 2021 17:12:49 -0700 Message-ID: Subject: Re: [RFC PATCH v3 1/8] lib: allow to build asn1 decoder and oid registry in SPL To: Philippe Reynes Cc: mr.nuke.me@gmail.com, joel.peshkin@broadcom.com, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Philippe, On Wed, 17 Nov 2021 at 10:52, Philippe Reynes wrote: > > This commit adds the options: > - SPL_ASN1_DECODER > - SPL_OID_REGISTRY > > Signed-off-by: Philippe Reynes > --- > lib/Kconfig | 6 ++++++ > lib/Makefile | 7 +++++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 70bf8e7a46..ebff84f113 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -758,11 +758,17 @@ config ASN1_DECODER > help > Enable asn1 decoder library. > > +config SPL_ASN1_DECODER > + bool Please add help. While you are here could you fix up the help above? It is pretty useless. It should mention what ASN stands for, what the library allows and a link to some information. > + > config OID_REGISTRY > bool > help > Enable fast lookup object identifier registry. > > +config SPL_OID_REGISTRY > + bool help Again that help is not very useful, please expand. [..] Regards, SImon