From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1043C433FE for ; Wed, 9 Dec 2020 16:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 648CC23C8E for ; Wed, 9 Dec 2020 16:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729877AbgLIQmO (ORCPT ); Wed, 9 Dec 2020 11:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732111AbgLIQl7 (ORCPT ); Wed, 9 Dec 2020 11:41:59 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61481C0613CF for ; Wed, 9 Dec 2020 08:41:19 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id x6so2436729wro.11 for ; Wed, 09 Dec 2020 08:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZtyuRdRz8sBuacydQZ1U8sV8ePK6VljMJ9YQuTchpwE=; b=SGRrDcXx7kpNQT8MctEfTnNV6tsVPXc+l1wPopGzlWU4Bryx5Upueed8qDVEzdrVs8 GUP3ovO4MBPcAd81XrTibO5WDjJMDmALAps7mLG2kRr/coRbR7IDRt6qbOcXvaN1VCtH j22C1KQ1P8v5mmfS7Wt6KQ/FNoZ6QsUZ8zcrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZtyuRdRz8sBuacydQZ1U8sV8ePK6VljMJ9YQuTchpwE=; b=BXrYrzKPhurNTlmZo0r9SWZj48+3Ni2yoLC1eR/cByfLI9Vq3r2J8fTOkV5PUIxnun oCb1Jj/EUWDbAjyrh6tF8ho/uCJBntrI5mz9JdZQEhaRxUGVk3XyuxGPl9RmBJVJRe/6 20SYtzixcxqhJnYD5V0Fx+KVYvOXXo/gkZNKdN4UHwhnsl+dfhqsPRs3BXZJqvR+ZoA3 MVoJCpat0jQzlgG0pD/K58UYEl4JL4mo4EmN8cG6jeJV1ckdsNWIVXpHyTtZwUEm1QUB FGOB9MDgkmF5zE53ekOMRTubkGEskjQH/uWxI7f9PX0r6LvBGeaRB3dmykE8AfvzNSRm aLIw== X-Gm-Message-State: AOAM532cEnAJBmaNRY359s80eBa0Xv+8j/y/GGZP3WrJem/ZGeGSqq+u aSkbm6CbQTfQXcOCMGYd2VGTCYYKXMWAt93BXvngQQ== X-Google-Smtp-Source: ABdhPJwEg372av2KNxoGuDDVEL4uVw1qajfMrJ17k9OJ6CGdKJDuSuYJ/scAeKBtFnzbgJfJw2ScvoDjE6gpSjHwQ+A= X-Received: by 2002:a5d:5146:: with SMTP id u6mr3839567wrt.66.1607532077897; Wed, 09 Dec 2020 08:41:17 -0800 (PST) MIME-Version: 1.0 References: <20201204193540.3047030-1-swboyd@chromium.org> <20201204193540.3047030-3-swboyd@chromium.org> In-Reply-To: <20201204193540.3047030-3-swboyd@chromium.org> From: Simon Glass Date: Wed, 9 Dec 2020 09:41:06 -0700 Message-ID: Subject: Re: [PATCH 2/3] platform/chrome: cros_ec_spi: Drop bits_per_word assignment To: Stephen Boyd Cc: Mark Brown , lk , linux-spi@vger.kernel.org, Benson Leung , linux-arm-msm@vger.kernel.org, Enric Balletbo i Serra , Gwendal Grignou , Douglas Anderson , Alexandru M Stan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 4 Dec 2020 at 12:35, Stephen Boyd wrote: > > This is already handed by default in spi_setup() if the bits_per_word is > 0, so just drop it to shave off a line. > > Cc: Simon Glass > Cc: Gwendal Grignou > Reviewed-by: Douglas Anderson > Tested-by: Douglas Anderson > Acked-by: Enric Balletbo i Serra > Cc: Alexandru M Stan > Signed-off-by: Stephen Boyd > --- > drivers/platform/chrome/cros_ec_spi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass > > diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c > index f9df218fc2bb..14c4046fa04d 100644 > --- a/drivers/platform/chrome/cros_ec_spi.c > +++ b/drivers/platform/chrome/cros_ec_spi.c > @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi) > struct cros_ec_spi *ec_spi; > int err; > > - spi->bits_per_word = 8; > spi->rt = true; > err = spi_setup(spi); > if (err < 0) > -- > https://chromeos.dev >