All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Why is ns16550 guarded by !OF_PLATDATA ?
Date: Wed, 22 Mar 2017 07:05:47 -0600	[thread overview]
Message-ID: <CAPnjgZ3vw=cTb3ED=cPkkQ0FtTJMBg4J1CeeVdGLbxOyuUat0A@mail.gmail.com> (raw)
In-Reply-To: <901f1d0a-604e-ec8a-a3ad-c06fb9901dfc@adaptrum.com>

Hi,

On 16 March 2017 at 15:00, Alexandru Gagniuc <alex.g@adaptrum.com> wrote:
> I'm trying to use the ns16550 DM driver in a platform where havind a dtb in
> SPL is not plausible, so we're using platdata.
>
> Now for ns16550 The U_BOOT_DRIVER is guarded by !OF_PLATDATA, so the driver
> is not compiled in SPL. This seems inconsistent with other U_BOOT_DRIVERs.
> This was introduced in the following commit [1]:
>
> * b2927fb dm: serial: ns16550: Update to support of-platdata
>
> The reasoning was that the platdata structure is unknown, but one would have
> to provide a 'struct ns16550_platdata' when using platdata, and that is the
> case with the boards that use this driver with platdata.
>
> Is this a misguided change, or am I missing something deeper? I can prepare
> a patch to resolve this, if this is the consensus.

You could take it out of the #ifdef, but be careful not to call and
fdt functions when OF_PLATDATA is defined. You'll have to drop the
of_match and compatible strings too.

>
> Alex
>
> [1] https://lists.denx.de/pipermail/u-boot/2016-July/259744.html

Regards,
Simon

  reply	other threads:[~2017-03-22 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 21:00 [U-Boot] Why is ns16550 guarded by !OF_PLATDATA ? Alexandru Gagniuc
2017-03-22 13:05 ` Simon Glass [this message]
2017-03-27 19:54   ` [U-Boot] [PATCH] serial: ns16550: Link in the DM driver when when using platdata Alexandru Gagniuc
2017-04-01  4:23     ` Simon Glass
2017-04-13 21:16       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3vw=cTb3ED=cPkkQ0FtTJMBg4J1CeeVdGLbxOyuUat0A@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.