All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jon Mason" <jdmason@kudzu.us>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH v4 6/6] tunes/armv8: move to a new location
Date: Tue, 29 Sep 2020 20:38:10 -0400	[thread overview]
Message-ID: <CAPoiz9w4iYci=mQPSEveAymTPDwLwspM22KQNH+wsLO0NC_7ew@mail.gmail.com> (raw)
In-Reply-To: <CAMKF1spUKBY8ff3zphQ--H_9__jTKgs=hkHH7maMVJ4ZktjsHw@mail.gmail.com>

On Tue, Sep 29, 2020 at 5:58 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> Lets not do it. For couple of reasons,
>
> There are BSPs including these include files which are using same
> branch across multiple yocto releases, this will break them
> files under include/<ARCH> are common at arch level, this moved the
> CPU implementation ( cortex* ) under it, seems odd and even more odd
> when you consider arm32 tunes.

There are so many specific files and I'm about to add even more
(cortex-m).  I agree that it should be done uniformly, instead of
doing just the armv8 ones.  So, let's drop this patch (not the
series), and I'll address it after the gatesgarth release.

Thanks,
Jon


>
> On Mon, Sep 28, 2020 at 6:06 AM Jon Mason <jdmason@kudzu.us> wrote:
> >
> > Move the ARMv8a tunes into a separate location (per generation).  This
> > should help reduce the number of tunes in the more generic location.
> >
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > ---
> >  meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa55.inc | 0
> >  meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65.inc | 0
> >  .../machine/include/{ => arm/armv8-2a}/tune-cortexa65ae.inc     | 0
> >  .../include/{ => arm/armv8-2a}/tune-cortexa75-cortexa55.inc     | 0
> >  meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75.inc | 0
> >  .../include/{ => arm/armv8-2a}/tune-cortexa76-cortexa55.inc     | 0
> >  meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76.inc | 0
> >  .../machine/include/{ => arm/armv8-2a}/tune-cortexa76ae.inc     | 0
> >  meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa77.inc | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa32.inc   | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa34.inc   | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa35.inc   | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa53.inc   | 0
> >  .../include/{ => arm/armv8a}/tune-cortexa57-cortexa53.inc       | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57.inc   | 0
> >  .../include/{ => arm/armv8a}/tune-cortexa72-cortexa53.inc       | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72.inc   | 0
> >  .../include/{ => arm/armv8a}/tune-cortexa73-cortexa35.inc       | 0
> >  .../include/{ => arm/armv8a}/tune-cortexa73-cortexa53.inc       | 0
> >  meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73.inc   | 0
> >  meta/conf/machine/qemuarm64.conf                                | 2 +-
> >  21 files changed, 1 insertion(+), 1 deletion(-)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa55.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65ae.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75-cortexa55.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76-cortexa55.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76ae.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa77.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa32.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa34.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa35.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa53.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57-cortexa53.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72-cortexa53.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73-cortexa35.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73-cortexa53.inc (100%)
> >  rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73.inc (100%)
> >
> > diff --git a/meta/conf/machine/include/tune-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa55.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa55.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa55.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa65.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa65.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa65ae.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65ae.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa65ae.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa65ae.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa75-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa75-cortexa55.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa75-cortexa55.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa75-cortexa55.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa75.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa75.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa75.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa75.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa76-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76-cortexa55.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa76-cortexa55.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76-cortexa55.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa76.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa76.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa76ae.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76ae.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa76ae.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76ae.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa77.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa77.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa77.inc
> > rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa77.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa32.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa34.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa34.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa34.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa34.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa35.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa35.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa35.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa35.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa53.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa53.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa53.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa57-cortexa53.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa57-cortexa53.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa57-cortexa53.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa57.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa57.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa57.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa57.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72-cortexa53.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa72-cortexa53.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa72.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa73-cortexa35.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa35.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa73-cortexa35.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa35.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa73-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa53.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa73-cortexa53.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa53.inc
> > diff --git a/meta/conf/machine/include/tune-cortexa73.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73.inc
> > similarity index 100%
> > rename from meta/conf/machine/include/tune-cortexa73.inc
> > rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73.inc
> > diff --git a/meta/conf/machine/qemuarm64.conf b/meta/conf/machine/qemuarm64.conf
> > index 2f61eb0aed5f..c4096d0eeea4 100644
> > --- a/meta/conf/machine/qemuarm64.conf
> > +++ b/meta/conf/machine/qemuarm64.conf
> > @@ -2,7 +2,7 @@
> >  #@NAME: QEMU ARMv8 machine
> >  #@DESCRIPTION: Machine configuration for running an ARMv8 system on QEMU
> >
> > -require conf/machine/include/tune-cortexa57.inc
> > +require conf/machine/include/arm/armv8a/tune-cortexa57.inc
> >  require conf/machine/include/qemu.inc
> >
> >  KERNEL_IMAGETYPE = "Image"
> > --
> > 2.20.1
> >
> >
> > 
> >

  reply	other threads:[~2020-09-30  0:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 13:05 [meta-oe][PATCH v4 0/6] ARMv8 Tune add and reorg Jon Mason
2020-09-28 13:05 ` [meta-oe][PATCH v4 1/6] Space-comma Cleanups Jon Mason
2020-09-28 13:05 ` [meta-oe][PATCH v4 2/6] armv8/tunes: Move TUNECONFLICTS Jon Mason
2020-09-28 13:05 ` [meta-oe][PATCH v4 3/6] armv8/tunes: reference parent's TUNE_FEATURES Jon Mason
2020-09-28 13:05 ` [meta-oe][PATCH v4 4/6] armv8/tunes: Add tunes for supported ARMv8a cores Jon Mason
2020-09-28 13:05 ` [meta-oe][PATCH v4 5/6] armv8/tunes: Add tunes for supported ARMv8.2a cores Jon Mason
2020-10-12 23:45   ` [OE-core] " Martin Jansa
2020-09-28 13:05 ` [meta-oe][PATCH v4 6/6] tunes/armv8: move to a new location Jon Mason
2020-09-29 21:58   ` [OE-core] " Khem Raj
2020-09-30  0:38     ` Jon Mason [this message]
2020-09-30  2:46       ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPoiz9w4iYci=mQPSEveAymTPDwLwspM22KQNH+wsLO0NC_7ew@mail.gmail.com' \
    --to=jdmason@kudzu.us \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.