From: Daire Byrne <daire@dneg.com>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH/rfc v2] NFS: introduce NFS namespaces.
Date: Wed, 7 Jul 2021 23:21:28 +0100 [thread overview]
Message-ID: <CAPt2mGPSeK6YHPQ8r6Z0UJv4mJnRAcEEc4VmLaENo91-K8P=fQ@mail.gmail.com> (raw)
In-Reply-To: <162569314954.31036.11087071768390664533@noble.neil.brown.name>
On Wed, 7 Jul 2021 at 22:25, NeilBrown <neilb@suse.de> wrote:
>
> On Wed, 07 Jul 2021, Daire Byrne wrote:
> > I stripped out all my patches so it's just this one on top of 5.13-rc7
> > and I can still reproduce it.
> >
> > I can only trigger it by mounting the same export (RHEL7 server) using
> > two different namespaces and performing a heavy IO benchmark to either
> > mount (leaving one idle). Part of the benchmark walks thousands of
> > dirs with files (hence the readdirs).
> >
> > If I mount the same server twice with no (same) namespaces, even with
> > the patch applied, it works fine without any crash.
>
> That's pretty solid evidence!
>
> I just realized that the stack trace you reported mentions
> "kfree_const()".
> My latest patch doesn't include that, and nfs doesn't use it at all.
> Might you still be using the older patch?
>
> NeilBrown
Oh... the last stack trace, the readdir one? I don't see kfree_const
myself but I may have a case of word blindness. The first one I
reported definitely has kfree_const but after your latest patch, this
last one around readdir doesn't seem to?
I'm pretty sure I have your latest patch (with kfree instead of
kfree_const) correctly applied. Though, I will double check that the
correct kernel and modules were then installed properly on my test VM.
Daire
next prev parent reply other threads:[~2021-07-07 22:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 1:32 [PATCH/rfc] NFS: introduce NFS namespaces NeilBrown
2021-06-25 13:07 ` kernel test robot
2021-06-25 13:37 ` Dan Carpenter
2021-06-28 0:14 ` NeilBrown
2021-06-28 6:35 ` Dan Carpenter
2021-06-28 6:35 ` Dan Carpenter
2021-07-01 0:54 ` [PATCH/rfc v2] " NeilBrown
2021-07-01 9:32 ` Daire Byrne
2021-07-01 11:39 ` NeilBrown
2021-07-03 12:45 ` Daire Byrne
2021-07-03 23:03 ` NeilBrown
2021-07-06 16:22 ` Daire Byrne
2021-07-07 1:12 ` NeilBrown
2021-07-07 10:57 ` Daire Byrne
2021-07-07 21:25 ` NeilBrown
2021-07-07 22:21 ` Daire Byrne [this message]
2021-07-07 23:18 ` NeilBrown
2021-07-13 12:27 ` Daire Byrne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPt2mGPSeK6YHPQ8r6Z0UJv4mJnRAcEEc4VmLaENo91-K8P=fQ@mail.gmail.com' \
--to=daire@dneg.com \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.