All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Kurt Cancemi <kurt@x64architecture.com>
Cc: netdev <netdev@vger.kernel.org>, "Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface
Date: Tue, 29 Jun 2021 01:01:30 +0200	[thread overview]
Message-ID: <CAPv3WKfcHZ642S1SczFNMruq64H9E6x0KD5+bYWHcs3uu058cQ@mail.gmail.com> (raw)
In-Reply-To: <20210629004958.40f3b98c@thinkpad>

Hi Kurt,


wt., 29 cze 2021 o 00:50 Marek Behún <kabel@kernel.org> napisał(a):
>
> On Mon, 28 Jun 2021 15:28:26 -0400
> Kurt Cancemi <kurt@x64architecture.com> wrote:
>
> > This patch changes the default behavior to enable RX and TX delays for
> > the PHY_INTERFACE_MODE_RGMII case by default.
>
> And why would we want that? I was under the impression that we have the
> _ID variants for enabling these delays.
>

+1

From Documentation/devicetree/bindings/net/ethernet-controller.yaml

      # RGMII with internal RX and TX delays provided by the PHY,
      # the MAC should not add the RX or TX delays in this case
      - rgmii-id

I guess you should rather fix the hardware description of your board,
i.e. use `phy-mode = "rgmii-id"` instead of tweaking the PHY driver
itself.

Best regards,
Marcin

  reply	other threads:[~2021-06-28 23:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 19:28 [PATCH 0/1] Possible Issue Setting the Delay Flags in the Marvell Net PHY Driver Kurt Cancemi
2021-06-28 19:28 ` [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface Kurt Cancemi
2021-06-28 22:49   ` Marek Behún
2021-06-28 23:01     ` Marcin Wojtas [this message]
2021-06-29  0:05       ` Kurt Cancemi
2021-06-29  0:21         ` Marek Behún
     [not found]     ` <CADujJWWoWRyW3S+f3F_Zhq9H90QZ1W4eu=5dyad3DeMLHFp2TA@mail.gmail.com>
2021-06-29  0:23       ` Marek Behún
2021-06-29  1:12         ` Kurt Cancemi
2021-06-29 10:52           ` Marek Behún
2021-06-29 15:08             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPv3WKfcHZ642S1SczFNMruq64H9E6x0KD5+bYWHcs3uu058cQ@mail.gmail.com \
    --to=mw@semihalf.com \
    --cc=kabel@kernel.org \
    --cc=kurt@x64architecture.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.