From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbdIUPUi convert rfc822-to-8bit (ORCPT ); Thu, 21 Sep 2017 11:20:38 -0400 Received: from hermes.aosc.io ([199.195.250.187]:56936 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdIUPUg (ORCPT ); Thu, 21 Sep 2017 11:20:36 -0400 Date: Thu, 21 Sep 2017 23:20:11 +0800 In-Reply-To: <20170921154621.0000328d@huawei.com> References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support To: linux-arm-kernel@lists.infradead.org, Jonathan Cameron CC: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Quentin Schulz , Chen-Yu Tsai , Maxime Ripard , Lee Jones , Jonathan Cameron From: Icenowy Zheng Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2017年9月21日 GMT+08:00 下午10:46:21, Jonathan Cameron 写到: >On Wed, 20 Sep 2017 23:18:07 +0800 >Icenowy Zheng wrote: > >> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power >inputs: >> AC, USB and Battery. >> >> This patchset adds support for the AC and Battery supplies, which is >useful >> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, >Pinebook). >> >> The USB supply is not yet supported in this patchset because it's not >> present on Pine series boards. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXs. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXP803. > >I'll go with the obvious question... > >Why an RFC rather than a standard patch submission? I'm not immediately >seeing what is controversial! Oh I am just not confident about this patchset, especially the IIO part. > >Jonathan > >> >> Icenowy Zheng (7): >> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >> iio: adc: axp20x-adc: allow to skip ADC rate setup now >> iio: adc: axp20x-adc: add support for AXP803 >> power: supply: axp20x-battery: support AXP803 >> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >> arm64: allwinner: a64: enable AC and Battery for Pine64 >> >> .../bindings/power/supply/axp20x_battery.txt | 1 + >> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >> drivers/iio/adc/axp20x_adc.c | 114 >++++++++++++++++++++- >> drivers/mfd/axp20x.c | 11 ++ >> drivers/power/supply/axp20x_battery.c | 88 >++++++++++++++-- >> 7 files changed, 226 insertions(+), 12 deletions(-) >> > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support Date: Thu, 21 Sep 2017 23:20:11 +0800 Message-ID: References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20170921154621.0000328d-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jonathan Cameron Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Quentin Schulz , Chen-Yu Tsai , Maxime Ripard , Lee Jones , Jonathan Cameron List-Id: devicetree@vger.kernel.org 于 2017年9月21日 GMT+08:00 下午10:46:21, Jonathan Cameron 写到: >On Wed, 20 Sep 2017 23:18:07 +0800 >Icenowy Zheng wrote: > >> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power >inputs: >> AC, USB and Battery. >> >> This patchset adds support for the AC and Battery supplies, which is >useful >> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, >Pinebook). >> >> The USB supply is not yet supported in this patchset because it's not >> present on Pine series boards. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXs. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXP803. > >I'll go with the obvious question... > >Why an RFC rather than a standard patch submission? I'm not immediately >seeing what is controversial! Oh I am just not confident about this patchset, especially the IIO part. > >Jonathan > >> >> Icenowy Zheng (7): >> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >> iio: adc: axp20x-adc: allow to skip ADC rate setup now >> iio: adc: axp20x-adc: add support for AXP803 >> power: supply: axp20x-battery: support AXP803 >> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >> arm64: allwinner: a64: enable AC and Battery for Pine64 >> >> .../bindings/power/supply/axp20x_battery.txt | 1 + >> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >> drivers/iio/adc/axp20x_adc.c | 114 >++++++++++++++++++++- >> drivers/mfd/axp20x.c | 11 ++ >> drivers/power/supply/axp20x_battery.c | 88 >++++++++++++++-- >> 7 files changed, 226 insertions(+), 12 deletions(-) >> > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io (Icenowy Zheng) Date: Thu, 21 Sep 2017 23:20:11 +0800 Subject: [RFC PATCH 0/7] AXP803 AC/Battery support In-Reply-To: <20170921154621.0000328d@huawei.com> References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2017?9?21? GMT+08:00 ??10:46:21, Jonathan Cameron ??: >On Wed, 20 Sep 2017 23:18:07 +0800 >Icenowy Zheng wrote: > >> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power >inputs: >> AC, USB and Battery. >> >> This patchset adds support for the AC and Battery supplies, which is >useful >> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, >Pinebook). >> >> The USB supply is not yet supported in this patchset because it's not >> present on Pine series boards. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXs. >> >> In order to enable battery monitoring the ADC for battery is also >enabled >> for AXP803. > >I'll go with the obvious question... > >Why an RFC rather than a standard patch submission? I'm not immediately >seeing what is controversial! Oh I am just not confident about this patchset, especially the IIO part. > >Jonathan > >> >> Icenowy Zheng (7): >> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >> iio: adc: axp20x-adc: allow to skip ADC rate setup now >> iio: adc: axp20x-adc: add support for AXP803 >> power: supply: axp20x-battery: support AXP803 >> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >> arm64: allwinner: a64: enable AC and Battery for Pine64 >> >> .../bindings/power/supply/axp20x_battery.txt | 1 + >> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >> drivers/iio/adc/axp20x_adc.c | 114 >++++++++++++++++++++- >> drivers/mfd/axp20x.c | 11 ++ >> drivers/power/supply/axp20x_battery.c | 88 >++++++++++++++-- >> 7 files changed, 226 insertions(+), 12 deletions(-) >> > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel at lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel