All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Fernando Fujita Pires <luis.pires@eldorado.org.br>
To: "Matheus Kowalczuk Ferst" <matheus.ferst@eldorado.org.br>,
	"Cédric Le Goater" <clg@kaod.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"QEMU PowerPC" <qemu-ppc@nongnu.org>
Subject: RE: Fwd: New Defects reported by Coverity Scan for QEMU
Date: Tue, 16 Nov 2021 20:21:50 +0000	[thread overview]
Message-ID: <CPXPR80MB5224B99CDBDD24B81FF4CC58DA999@CPXPR80MB5224.lamprd80.prod.outlook.com> (raw)
In-Reply-To: <92434193-3727-8994-9ebd-b823665aa90a@eldorado.org.br>

From: Matheus K. Ferst <matheus.ferst@eldorado.org.br>
> Hi Cédric,
> 
> The only change was the helper name that is now uppercase, so nothing new
> here. The underlying cause is that dfp_finalize_decimal64 only sets
> dfp->vt.VsrD(1) and set_dfp64 receives a pointer to the complete struct.
> 
> But since set_dfp64 also only access VsrD(1), it shouldn't be a real
> problem AFAICT. The same applies to CID 1465776~1465786 and
> 1465788~1465790.

Right. Coverity is probably reporting these as new just because the helper macros were re-written as part of the move to decodetree.
I believe these should be marked as false positives.

We *could* also wrap set_dfp{64,128} in new macros that would then reference only the appropriate parts of dfp, but, in this case, I don't think it's worth the trouble.

Thanks,

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

  reply	other threads:[~2021-11-16 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <618af1a42c458_27197b2b2515bd79b8920c6@prd-scan-dashboard-0.mail>
2021-11-10  8:18 ` Fwd: New Defects reported by Coverity Scan for QEMU Cédric Le Goater
2021-11-12 16:28   ` Matheus K. Ferst
2021-11-16 20:21     ` Luis Fernando Fujita Pires [this message]
2021-11-17 10:34       ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CPXPR80MB5224B99CDBDD24B81FF4CC58DA999@CPXPR80MB5224.lamprd80.prod.outlook.com \
    --to=luis.pires@eldorado.org.br \
    --cc=clg@kaod.org \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.