All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xu, Dongxiao" <dongxiao.xu@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/3] bitbake: add ${MACHINE} for do_populate_sysroot_setscene and do_package_setscene
Date: Fri, 28 Jan 2011 15:54:03 +0800	[thread overview]
Message-ID: <D5AB6E638E5A3E4B8F4406B113A5A19A31D8EFD4@shsmsx501.ccr.corp.intel.com> (raw)
In-Reply-To: <1296127452.27814.7107.camel@rex>

Richard Purdie wrote:
> On Thu, 2011-01-27 at 16:04 +0800, Dongxiao Xu wrote:
>> From: Dongxiao Xu <dongxiao.xu@intel.com>
>> 
>> ${MACHINE} information is also needed to be tagged on stamps for
>> do_populate_sysroot_setscene and do_package_setscene, otherwise if
>> build two machines both from sstate, the second machine's sysroot
>> will not be populated correctly. 
>> 
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> 
> The _setscene stuff is really an internal implementation issue within
> bitbake. I don't like the idea that the metadata has to get this
> right and I'd prefer it if bitbake always did the right thing. In
> this case that means looking up the extra stamp info against the
> parent task, not the setscene one.    
> 
> I therefore merged:
> 
> http://git.pokylinux.org/cgit.cgi/poky/commit/?id=c34913ea5a4f20ce4bca3c68a65e9f64f1e3910c

Yes, this approach is better then specifically handling *_setscene stamp-extra-info in meta files. Thanks!

-- Dongxiao

> 
> which should obsolete this patch?
> 
> Good catch on finding the problem though!
> 
> Cheers,
> 
> Richard



  reply	other threads:[~2011-01-28  7:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27  8:04 [PATCH 0/3][PULL] several machine specific sysroots fixes Dongxiao Xu
2011-01-27  8:04 ` [PATCH 1/3] bitbake: add ${MACHINE} for do_populate_sysroot_setscene and do_package_setscene Dongxiao Xu
2011-01-27 11:24   ` Richard Purdie
2011-01-28  7:54     ` Xu, Dongxiao [this message]
2011-01-27  8:04 ` [PATCH 2/3] rm_work.bbclass: handle stamp files while doing rm_work Dongxiao Xu
2011-01-27 11:13   ` Richard Purdie
2011-01-28  7:52     ` Xu, Dongxiao
2011-01-27  8:04 ` [PATCH 3/3] perl: Remove ${MACHINE} dependency in compile and package Dongxiao Xu
2011-01-27 11:26   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D5AB6E638E5A3E4B8F4406B113A5A19A31D8EFD4@shsmsx501.ccr.corp.intel.com \
    --to=dongxiao.xu@intel.com \
    --cc=poky@yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.