From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2844BC55178 for ; Tue, 27 Oct 2020 03:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFB06217A0 for ; Tue, 27 Oct 2020 03:14:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="k3B695qA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502390AbgJ0DOO (ORCPT ); Mon, 26 Oct 2020 23:14:14 -0400 Received: from mail-am6eur05on2051.outbound.protection.outlook.com ([40.107.22.51]:63942 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2409229AbgJ0DOO (ORCPT ); Mon, 26 Oct 2020 23:14:14 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIjP+SVQhfYw4Sgnuef4tsK3mN+W53axWPpkQVapHkftcjVvF417G7/eV4XgQ4HJ1agJIZ9NxU/CcFCB+gsBxGrhrQpqAt6JRdQ5Rxm731Yf1QIfnnxH3C9hXu+CJESDOOfKB0boZghczmNHxD5yG7+8xdufLoIxCVYJbxR7C1SySMp1rY4WFQ6SlgAwSc6OP1R9sIJZStMcmlvbqwl6vc0xatQts8YjLv5k2tF9/41FoHpyUA+SbhZLP70k++h8IRNlLW8CV/PTc7uyPd8WaT8EgQ0qfnqQPJo/WZLMw122TbaUK7mUfImw3DYnoNZXtLe+Q28WGgvOY/DUB+2myg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKi2HMqfmNOmz0tn0d04bFFbjloRXz7aq4/Fj24zPAA=; b=XxMPWef3bdZFtdgyVgBFmbRPiuUjTAf7ftOcMVIuyR3DvgigTidjXeNncCzEoq2WPa6vvxSzTECfaqv8Jv28RCKgHIjSGE68J5RL35N31kBCd8HKKOdsQ088JHBM36xD5/oIzUccFcdoMhYO3xN7iV8hVayDNA3QJDvJbxV8RPNmcLo8rUwhlNh3H3vsCWUthOve0aGq7dmo4IsiZaRHhAqdma9mTySSadO6rTFbWaEMxUkAhHsFIt3ecJBp94rIKN5StRHEW1Zp6snpjQg+bMr871zXcfULV7afJsqei367MJ0ArUEZy2mNP7/nFy8csSU5BPoCDoox6liyLvZhmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKi2HMqfmNOmz0tn0d04bFFbjloRXz7aq4/Fj24zPAA=; b=k3B695qAfroQm3hde7hELyCbw/d/DGbILv2h94onjQm6rMexeArJIGm1XvFHZ1niU8jtQ3Eo1zoyGO+qR708fvIF5LbFMohWBD1ltIPq6Q5uo/pGpLvbChRBpeGW9QVVGRjf6LKBX6DJziBq8CVj9APKuIki3kFEVCm5km//N90= Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com (2603:10a6:4:33::14) by DB7PR04MB4058.eurprd04.prod.outlook.com (2603:10a6:5:1b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Tue, 27 Oct 2020 03:14:10 +0000 Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e]) by DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e%7]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 03:14:09 +0000 From: Biwen Li To: Leo Li , Marc Zyngier , Rasmus Villemoes CC: "Biwen Li (OSS)" , "shawnguo@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "Z.q. Hou" , "tglx@linutronix.de" , "jason@lakedaemon.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jiafei Pan , Xiaobo Xie , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Thread-Topic: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Thread-Index: AQHWq6mP+ALMp9rpPEmvsss83oVh0Kmqxp/Q Date: Tue, 27 Oct 2020 03:14:09 +0000 Message-ID: References: <20201026080127.40499-1-biwen.li@oss.nxp.com> <31d8971374c261003aee9f4807c8ac8c@kernel.org> <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5aafe518-a6bf-48fd-ac5a-08d87a265f51 x-ms-traffictypediagnostic: DB7PR04MB4058: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1HX5VTjgkNW3FfRNaSSBb5aGZXgURQX2bVndsIKF9SBsiVV7lfItE0NfkuA6n3v4Lvp9cndu2EC5wyxG1pAuVCckOIv/H3Qgl/JtRumqRpf/RbqbzgXTgFzSvrOLdT2sBDtiRFrsL1VBK2Mf3G8JV7WXGhrUEDnvtj4hYuIxp+KKe1G59prn32YaXgjb7m2o0GXwLaZ2HKHUyDLf0pfl5VUZ5q3B4dFbqpnxBnWJ8urRXcfbKfBP+irwpaMLWW00oFHox+1qKdvN7oy9Wtxq9Y0diFj3LpuCPuhfs5Ci4KtcGxJ8bfiusq4DflZ7vojs4tJfrgoHhJxikvQr+F2J0g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0401MB2438.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(44832011)(64756008)(71200400001)(8676002)(55016002)(54906003)(7416002)(316002)(478600001)(186003)(8936002)(66946007)(52536014)(110136005)(26005)(6506007)(66476007)(66556008)(53546011)(86362001)(7696005)(83380400001)(5660300002)(9686003)(76116006)(4001150100001)(66446008)(33656002)(4326008)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: qeKIfy4AcNNP+GYd5pZ1D4pmnNBLG+5kFysesogFJxsgKPC4k354dQwdFlz5jZ6HG2XeXf0U5FvpFRFBCBYB7VIh3Z04/ea5My1fSZ+/kIMzQ5YZfmfivS3xKvQcV+vL+c8LBGlpqDYQ1MzKprLOVjADAciOutOhfwuNnX/qS2Lu1gxAAbWZwuS2KFp4gOTRU3yVCM5iwzBGpwWW7JEWcp27awDU5nopUXqU3ZPyWG3aC2Qztaued3WDXUu0uTMLf6TY2AF6BZY+CwOOh6g+X4NFX1wEHwU0QljeBJjtgKhoocmCyzi0edihAPmsLXIMEUruN0HpY4oV/k5ESEBEuYWXvz8bm8R+YQSLHi16S8NJSZHC3BtCfZzQ7anQGxIJteVlNOUsezvUQyZVCgrfOZ8/4L71DCsXG+/+DWehqX2uQjVuJg2rCpT4nCDWaiFAg1xcTL2HDtNM9/z5TXAiJfN1WcCj/AlOxtGrpZecbUdcjNVBN6wiPmwFLb6O/ajClZt2E2X/kvLv/s5oraQAyRzBukirnU8OwgHVD0uBf//eJE0RDdAfu9hWkrF+N3Hdqno+ntKgF3bwsHxdiiFZvzo3tbFIKbuMZDxS6aCwuCJHzn2kvaEneEMT4YqEeGq0Po6X2LAYSGIxf+jXN6qY7Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0401MB2438.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aafe518-a6bf-48fd-ac5a-08d87a265f51 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 03:14:09.7329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TadxpEu7fy2pD4VBtBVPZtyWq0ksLzKS/vaPD5xYKd0ufGdcgPNi3tiZWNYkIIQjnjRT9qOVcvhBHaz84WPI7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4058 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > -----Original Message----- > > From: Marc Zyngier > > Sent: Monday, October 26, 2020 4:23 AM > > To: Rasmus Villemoes > > Cc: Biwen Li (OSS) ; shawnguo@kernel.org; > > robh+dt@kernel.org; mark.rutland@arm.com; Leo Li ; > > Z.q. Hou ; tglx@linutronix.de; > > jason@lakedaemon.net; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; Jiafei Pan ; Xiaobo Xie > > ; linux-arm-kernel@lists.infradead.org; Biwen Li > > > > Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A > > external interrupt > > > > On 2020-10-26 09:06, Rasmus Villemoes wrote: > > > On 26/10/2020 09.44, Marc Zyngier wrote: > > >> On 2020-10-26 08:01, Biwen Li wrote: > > >>> From: Hou Zhiqiang > > >>> > > >>> Add an new IRQ chip declaration for LS1043A and LS1088A > > >>> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A > > >>> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA > > >> > > >> Three things: > > >> - This commit message doesn't describe the bit_reverse change > > > > > > Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't > > > mention anything about bit reversal for the scfg registers - they > > > don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but > > > perhaps, instead of removing it, that has just become a hard-coded > > > part of the IP. > > > > > > Also, IANAL etc., but > > > > > >>> +// Copyright 2019-2020 NXP > > > > > > really? Seems to be a bit of a stretch. > > > > > > At the very least, cc'ing the original author and only person to > > > ever touch that file would have been appreciated. > > > > Huh. Well spotted. That's definitely not on. > > NXP people, please talk to your legal department. >=20 > We do have an internal policy to require developer adding/updating NXP > copyright on non-trivial changes. I'm not sure if this change should be > considered trivial, but adding copyright claim on a file without prior co= pyright > claims could causing confusion like in this case. One potential solution= is to > add a more specific description on the NXP change together with the copyr= ight > claim. But maybe an easier solution is to add Rasmus your Copyright clai= m > first if you are ok with it. Yes, added a wrong Copyright. >=20 > Regards, > Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE2EC4363A for ; Tue, 27 Oct 2020 03:15:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE992072D for ; Tue, 27 Oct 2020 03:15:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ei+NK4/I"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="k3B695qA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE992072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kSoTh+Gfw7Zn9UNBAZ5HBh6xUVGPYjswN1QCaRvj41U=; b=Ei+NK4/Iq96SCLCNIDu1J9AMw v6wbtSdypCfKzbA/auvhDr87oXBE2gF45VtWs/uf5euaYoQbNn8R01JM2XyUxlFuFYYO7bHJzjIB2 m1y4tylEC52O6IQkhkF57xT/cuLlhRORQQas7ROBvcAGsmrDzFqiXEAr8i2/Vyuq9adaeSSLX0qH+ W71G9DJDCy6640Fr65ERBq/7YyPE9ewVTOtzvNZ+uYHIPPe0ID/3Eavj/rYqUTV+gGlYoPE7kZ2ax oBeVKRXQeiIP23l5bBJtjVqaP6d5Flj3UMYgwLdjlsjEZVpEhNnFhC29Y6N7gt7FZJHwv9L2+6Eax Oh0cVMbLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXFRC-0007cO-0K; Tue, 27 Oct 2020 03:14:18 +0000 Received: from mail-am6eur05on2044.outbound.protection.outlook.com ([40.107.22.44] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXFR8-0007bm-Gb for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 03:14:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIjP+SVQhfYw4Sgnuef4tsK3mN+W53axWPpkQVapHkftcjVvF417G7/eV4XgQ4HJ1agJIZ9NxU/CcFCB+gsBxGrhrQpqAt6JRdQ5Rxm731Yf1QIfnnxH3C9hXu+CJESDOOfKB0boZghczmNHxD5yG7+8xdufLoIxCVYJbxR7C1SySMp1rY4WFQ6SlgAwSc6OP1R9sIJZStMcmlvbqwl6vc0xatQts8YjLv5k2tF9/41FoHpyUA+SbhZLP70k++h8IRNlLW8CV/PTc7uyPd8WaT8EgQ0qfnqQPJo/WZLMw122TbaUK7mUfImw3DYnoNZXtLe+Q28WGgvOY/DUB+2myg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKi2HMqfmNOmz0tn0d04bFFbjloRXz7aq4/Fj24zPAA=; b=XxMPWef3bdZFtdgyVgBFmbRPiuUjTAf7ftOcMVIuyR3DvgigTidjXeNncCzEoq2WPa6vvxSzTECfaqv8Jv28RCKgHIjSGE68J5RL35N31kBCd8HKKOdsQ088JHBM36xD5/oIzUccFcdoMhYO3xN7iV8hVayDNA3QJDvJbxV8RPNmcLo8rUwhlNh3H3vsCWUthOve0aGq7dmo4IsiZaRHhAqdma9mTySSadO6rTFbWaEMxUkAhHsFIt3ecJBp94rIKN5StRHEW1Zp6snpjQg+bMr871zXcfULV7afJsqei367MJ0ArUEZy2mNP7/nFy8csSU5BPoCDoox6liyLvZhmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKi2HMqfmNOmz0tn0d04bFFbjloRXz7aq4/Fj24zPAA=; b=k3B695qAfroQm3hde7hELyCbw/d/DGbILv2h94onjQm6rMexeArJIGm1XvFHZ1niU8jtQ3Eo1zoyGO+qR708fvIF5LbFMohWBD1ltIPq6Q5uo/pGpLvbChRBpeGW9QVVGRjf6LKBX6DJziBq8CVj9APKuIki3kFEVCm5km//N90= Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com (2603:10a6:4:33::14) by DB7PR04MB4058.eurprd04.prod.outlook.com (2603:10a6:5:1b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Tue, 27 Oct 2020 03:14:10 +0000 Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e]) by DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e%7]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 03:14:09 +0000 From: Biwen Li To: Leo Li , Marc Zyngier , Rasmus Villemoes Subject: RE: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Thread-Topic: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Thread-Index: AQHWq6mP+ALMp9rpPEmvsss83oVh0Kmqxp/Q Date: Tue, 27 Oct 2020 03:14:09 +0000 Message-ID: References: <20201026080127.40499-1-biwen.li@oss.nxp.com> <31d8971374c261003aee9f4807c8ac8c@kernel.org> <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5aafe518-a6bf-48fd-ac5a-08d87a265f51 x-ms-traffictypediagnostic: DB7PR04MB4058: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1HX5VTjgkNW3FfRNaSSBb5aGZXgURQX2bVndsIKF9SBsiVV7lfItE0NfkuA6n3v4Lvp9cndu2EC5wyxG1pAuVCckOIv/H3Qgl/JtRumqRpf/RbqbzgXTgFzSvrOLdT2sBDtiRFrsL1VBK2Mf3G8JV7WXGhrUEDnvtj4hYuIxp+KKe1G59prn32YaXgjb7m2o0GXwLaZ2HKHUyDLf0pfl5VUZ5q3B4dFbqpnxBnWJ8urRXcfbKfBP+irwpaMLWW00oFHox+1qKdvN7oy9Wtxq9Y0diFj3LpuCPuhfs5Ci4KtcGxJ8bfiusq4DflZ7vojs4tJfrgoHhJxikvQr+F2J0g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0401MB2438.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(44832011)(64756008)(71200400001)(8676002)(55016002)(54906003)(7416002)(316002)(478600001)(186003)(8936002)(66946007)(52536014)(110136005)(26005)(6506007)(66476007)(66556008)(53546011)(86362001)(7696005)(83380400001)(5660300002)(9686003)(76116006)(4001150100001)(66446008)(33656002)(4326008)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: qeKIfy4AcNNP+GYd5pZ1D4pmnNBLG+5kFysesogFJxsgKPC4k354dQwdFlz5jZ6HG2XeXf0U5FvpFRFBCBYB7VIh3Z04/ea5My1fSZ+/kIMzQ5YZfmfivS3xKvQcV+vL+c8LBGlpqDYQ1MzKprLOVjADAciOutOhfwuNnX/qS2Lu1gxAAbWZwuS2KFp4gOTRU3yVCM5iwzBGpwWW7JEWcp27awDU5nopUXqU3ZPyWG3aC2Qztaued3WDXUu0uTMLf6TY2AF6BZY+CwOOh6g+X4NFX1wEHwU0QljeBJjtgKhoocmCyzi0edihAPmsLXIMEUruN0HpY4oV/k5ESEBEuYWXvz8bm8R+YQSLHi16S8NJSZHC3BtCfZzQ7anQGxIJteVlNOUsezvUQyZVCgrfOZ8/4L71DCsXG+/+DWehqX2uQjVuJg2rCpT4nCDWaiFAg1xcTL2HDtNM9/z5TXAiJfN1WcCj/AlOxtGrpZecbUdcjNVBN6wiPmwFLb6O/ajClZt2E2X/kvLv/s5oraQAyRzBukirnU8OwgHVD0uBf//eJE0RDdAfu9hWkrF+N3Hdqno+ntKgF3bwsHxdiiFZvzo3tbFIKbuMZDxS6aCwuCJHzn2kvaEneEMT4YqEeGq0Po6X2LAYSGIxf+jXN6qY7Q== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0401MB2438.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aafe518-a6bf-48fd-ac5a-08d87a265f51 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 03:14:09.7329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TadxpEu7fy2pD4VBtBVPZtyWq0ksLzKS/vaPD5xYKd0ufGdcgPNi3tiZWNYkIIQjnjRT9qOVcvhBHaz84WPI7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4058 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_231414_776872_3CF69D6E X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "jason@lakedaemon.net" , "Z.q. Hou" , "linux-kernel@vger.kernel.org" , "Biwen Li \(OSS\)" , Xiaobo Xie , "robh+dt@kernel.org" , "tglx@linutronix.de" , "shawnguo@kernel.org" , Jiafei Pan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > -----Original Message----- > > From: Marc Zyngier > > Sent: Monday, October 26, 2020 4:23 AM > > To: Rasmus Villemoes > > Cc: Biwen Li (OSS) ; shawnguo@kernel.org; > > robh+dt@kernel.org; mark.rutland@arm.com; Leo Li ; > > Z.q. Hou ; tglx@linutronix.de; > > jason@lakedaemon.net; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; Jiafei Pan ; Xiaobo Xie > > ; linux-arm-kernel@lists.infradead.org; Biwen Li > > > > Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A > > external interrupt > > > > On 2020-10-26 09:06, Rasmus Villemoes wrote: > > > On 26/10/2020 09.44, Marc Zyngier wrote: > > >> On 2020-10-26 08:01, Biwen Li wrote: > > >>> From: Hou Zhiqiang > > >>> > > >>> Add an new IRQ chip declaration for LS1043A and LS1088A > > >>> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A > > >>> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA > > >> > > >> Three things: > > >> - This commit message doesn't describe the bit_reverse change > > > > > > Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't > > > mention anything about bit reversal for the scfg registers - they > > > don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but > > > perhaps, instead of removing it, that has just become a hard-coded > > > part of the IP. > > > > > > Also, IANAL etc., but > > > > > >>> +// Copyright 2019-2020 NXP > > > > > > really? Seems to be a bit of a stretch. > > > > > > At the very least, cc'ing the original author and only person to > > > ever touch that file would have been appreciated. > > > > Huh. Well spotted. That's definitely not on. > > NXP people, please talk to your legal department. > > We do have an internal policy to require developer adding/updating NXP > copyright on non-trivial changes. I'm not sure if this change should be > considered trivial, but adding copyright claim on a file without prior copyright > claims could causing confusion like in this case. One potential solution is to > add a more specific description on the NXP change together with the copyright > claim. But maybe an easier solution is to add Rasmus your Copyright claim > first if you are ok with it. Yes, added a wrong Copyright. > > Regards, > Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel