All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, AlvinX" <alvinx.zhang@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type
Date: Fri, 4 Jun 2021 02:23:01 +0000	[thread overview]
Message-ID: <DM6PR11MB389823CB7730BA00A07923309F3B9@DM6PR11MB3898.namprd11.prod.outlook.com> (raw)
In-Reply-To: <405f6c00-3f34-dd84-d0e5-c2e00180df5b@oktetlabs.ru>

> > This patch defines new RSS offload type for IPv4 checksum, which is
> > required when users want to distribute packets based on the IPv4
> > checksum field.
> >
> > For example "flow create 0 ingress pattern eth / ipv4 / end actions
> > rss types ipv4-chksum end queues end / end", this flow causes all
> > matching packets to be distributed to queues on basis of IPv4
> > checksum.
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> 
> The patch LGTM now. I hope we'll have a PMD in the release cycle which
> supports it.
> 
> In fact it is a funny idea. Let's consider a TCP connection and routing change
> with one extra hop on the way while the connection is alive. Or a UDP stream in
> the same conditions. If so, TTL will different, checksum changes and connection
> packets may be delivered to a different Rx queue.
> May be sometimes it is not important and/or can't happen.
> 
> L4 checksum sounds better from this point of view since it covers IP addresses
> and transport ports and less bits to hash. The only concern is distribution fairness,
> but I keep the topic to those who understand corresponding math better.
> 
> > ---

We are preparing a PMD patch to support this feature, if ready, we will submit it ASAP.

Thanks,
Alvin

  reply	other threads:[~2021-06-04  2:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  3:12 [dpdk-dev] [PATCH] ethdev: add RSS offload type for L3 checksum Alvin Zhang
2021-06-03  7:14 ` Andrew Rybchenko
2021-06-03  7:28   ` Zhang, AlvinX
2021-06-03  8:03 ` [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type Alvin Zhang
2021-06-03  8:17   ` Andrew Rybchenko
2021-06-04  2:23     ` Zhang, AlvinX [this message]
2021-06-07 18:31   ` Ajit Khaparde
2021-06-15  8:19   ` [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types Alvin Zhang
2021-06-15  8:26     ` Jerin Jacob
2021-06-16 15:18       ` Zhang, Qi Z
2021-06-22  8:20         ` Singh, Aman Deep
2021-07-01 14:26     ` Andrew Rybchenko
2021-07-06  6:14       ` Zhang, AlvinX
2021-07-06  7:05       ` Zhang, AlvinX
2021-07-06  7:18         ` Zhang, Qi Z
2021-07-06  8:04           ` Andrew Rybchenko
2021-07-07  3:23             ` Zhang, Qi Z
2021-07-07  9:49               ` Andrew Rybchenko
2021-07-07 13:00                 ` Zhang, Qi Z
2021-07-07 13:10                   ` Andrew Rybchenko
2021-07-08  1:07                     ` Zhang, Qi Z
2021-07-08  7:45                       ` Andrew Rybchenko
2021-07-10  8:38                         ` Thomas Monjalon
2021-07-13  1:13     ` [dpdk-dev] [PATCH v4] " Alvin Zhang
2021-07-13  7:54       ` Andrew Rybchenko
2021-07-13  9:38         ` Zhang, AlvinX
2021-07-13 10:24           ` Andrew Rybchenko
2021-07-14  2:38             ` Zhang, AlvinX
2021-08-18  2:32       ` [dpdk-dev] [PATCH v5] " Alvin Zhang
2021-08-29 12:07         ` Zhang, Qi Z
2021-08-31  9:44         ` [dpdk-dev] [PATCH v6] " Alvin Zhang
2021-08-31  9:52           ` [dpdk-dev] [PATCH v7] " Alvin Zhang
2021-09-06  0:28             ` Zhang, Qi Z
2021-09-14 14:00             ` Ferruh Yigit
2021-09-15  1:36               ` Zhang, AlvinX
2021-09-15  5:47             ` [dpdk-dev] [PATCH v8] " Alvin Zhang
2021-09-21  8:26               ` Ferruh Yigit
2021-09-28 13:09               ` Ferruh Yigit
2021-09-29  2:27                 ` Zhang, AlvinX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB389823CB7730BA00A07923309F3B9@DM6PR11MB3898.namprd11.prod.outlook.com \
    --to=alvinx.zhang@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.