From: Raslan Darawsheh <rasland@nvidia.com>
To: Suanming Mou <suanmingm@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect meter table define
Date: Thu, 1 Oct 2020 10:03:37 +0000 [thread overview]
Message-ID: <DM6PR12MB27481E8C00830C149C14C045CF300@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1601448421-186392-1-git-send-email-suanmingm@nvidia.com>
Hi,
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Wednesday, September 30, 2020 9:47 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix incorrect meter table define
>
> As metering and metadata features were developed at the same time. The
> metering and metadata tables are defined conflicted.
>
> This cauese the meter suffix flow jump to the same metadata table and
> cause flow deadloop.
>
> Adjust the metering table define to fix that issue.
>
> Fixes: 46a5e6bc6a85 ("net/mlx5: prepare meter flow tables")
> Cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index 0907506..1b7bac1 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -503,14 +503,14 @@ struct mlx5_flow_tbl_resource {
> };
>
> #define MLX5_MAX_TABLES UINT16_MAX
> -#define MLX5_FLOW_TABLE_LEVEL_METER (UINT16_MAX - 3)
> -#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (UINT16_MAX - 2)
> #define MLX5_HAIRPIN_TX_TABLE (UINT16_MAX - 1)
> /* Reserve the last two tables for metadata register copy. */
> #define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)
> #define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)
> /* Tables for metering splits should be added here. */
> #define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3)
> +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)
> +#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3)
> #define MLX5_MAX_TABLES_FDB UINT16_MAX
>
> /* ID generation structure. */
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-10-01 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:47 [dpdk-dev] [PATCH] net/mlx5: fix incorrect meter table define Suanming Mou
2020-10-01 10:03 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27481E8C00830C149C14C045CF300@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.