RE: [PATCH] drm/amdgpu: fix build error

["Zhang, Hawking" <Hawking.Zhang@amd.com>]

[AMD Public Use]

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Guchun Chen
Sent: Wednesday, September 30, 2020 21:59
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com>; StDenis, Tom <Tom.StDenis@amd.com>
Cc: Chen, Guchun <Guchun.Chen@amd.com>
Subject: [PATCH] drm/amdgpu: fix build error

Regression by patch:
fd583c4f01a7 drm/amdgpu: drop duplicated ecc check for vega10 (v4)

CC [M]  drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.o
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function ‘gmc_v9_0_late_init’:
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:1216:59: error: expected ‘)’ before ‘{’ token
 1216 |   if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC)) {
      |      ~                                                    ^~
      |                                                           )
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:1220:2: error: expected expression before ‘}’ token
 1220 |  }
      |  ^
  CC [M]  drivers/gpu/drm/amd/amdgpu/umc_v6_1.o

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 151686888c32..6e9de02d5455 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1213,7 +1213,7 @@ static int gmc_v9_0_late_init(void *handle)
 	 * writes, while disables HBM ECC for vega10.
 	 */
 	if (!amdgpu_sriov_vf(adev) && (adev->asic_type == CHIP_VEGA10)) {
-		if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC)) {
+		if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC))) {
 			if (adev->df.funcs->enable_ecc_force_par_wr_rmw)
 				adev->df.funcs->enable_ecc_force_par_wr_rmw(adev, false);
 		}
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Chawking.zhang%40amd.com%7C045f187fa8964bc861e508d86548fa73%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637370712043484513&amp;sdata=GU%2FJfFpJEtWY52Yoe5%2FTF7RKNC139f1rM6NIQR9rInM%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx