From: "Liu, Shaoyun" <Shaoyun.Liu@amd.com>
To: "Luo, Zhigang" <Zhigang.Luo@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Zhang, Hawking" <Hawking.Zhang@amd.com>
Subject: RE: [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for sriov vf
Date: Thu, 3 Jun 2021 16:43:07 +0000 [thread overview]
Message-ID: <DM6PR12MB55344C9909B4490FE2C5AE94F43C9@DM6PR12MB5534.namprd12.prod.outlook.com> (raw)
In-Reply-To: <BL1PR12MB5317C909CDB48412330A608DF13C9@BL1PR12MB5317.namprd12.prod.outlook.com>
[AMD Official Use Only]
I will leave Hawking to comment on this serial .
Thanks
Shaoyun.liu
-----Original Message-----
From: Luo, Zhigang <Zhigang.Luo@amd.com>
Sent: Thursday, June 3, 2021 11:48 AM
To: Liu, Shaoyun <Shaoyun.Liu@amd.com>; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for sriov vf
All new PSP release will have this feature. And it will not cause any failure even the PSP doesn't have this feature yet.
Thanks,
Zhigang
-----Original Message-----
From: Liu, Shaoyun <Shaoyun.Liu@amd.com>
Sent: June 3, 2021 11:15 AM
To: Luo, Zhigang <Zhigang.Luo@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Luo, Zhigang <Zhigang.Luo@amd.com>
Subject: RE: [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for sriov vf
[AMD Official Use Only]
Please double verify whether this feature apply to all aisc PSP supported since this is not only apply to ARCTURUS and ALDEBARAN.
Shaoyun.liu
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhigang Luo
Sent: Thursday, June 3, 2021 10:13 AM
To: amd-gfx@lists.freedesktop.org
Cc: Luo, Zhigang <Zhigang.Luo@amd.com>
Subject: [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for sriov vf
psp added new feature to check fw buffer address for sriov vf. the address range must be in vf fb.
Signed-off-by: Zhigang Luo <zhigang.luo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 6bd7e39c3e75..7c0f1017a46b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -2320,11 +2320,20 @@ static int psp_load_fw(struct amdgpu_device *adev)
if (!psp->cmd)
return -ENOMEM;
- ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG,
- AMDGPU_GEM_DOMAIN_GTT,
- &psp->fw_pri_bo,
- &psp->fw_pri_mc_addr,
- &psp->fw_pri_buf);
+ if (amdgpu_sriov_vf(adev)) {
+ ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG,
+ AMDGPU_GEM_DOMAIN_VRAM,
+ &psp->fw_pri_bo,
+ &psp->fw_pri_mc_addr,
+ &psp->fw_pri_buf);
+ } else {
+ ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG,
+ AMDGPU_GEM_DOMAIN_GTT,
+ &psp->fw_pri_bo,
+ &psp->fw_pri_mc_addr,
+ &psp->fw_pri_buf);
+ }
+
if (ret)
goto failed;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CShaoyun.Liu%40amd.com%7C3f624a72d2574d5c10a808d92699c9a8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637583264223318916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4EfyfR26TENFq1%2BXlSufuOYocdCmNcdEZHyEPzAQPcc%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-06-03 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 14:13 [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location Zhigang Luo
2021-06-03 14:13 ` [PATCH 2/5] drm/amdgpu: remove sriov vf gfxhub fb location programming Zhigang Luo
2021-06-03 15:10 ` Liu, Shaoyun
2021-06-03 15:22 ` Luo, Zhigang
2021-06-03 14:13 ` [PATCH 3/5] drm/amdgpu: remove sriov vf mmhub system aperture and " Zhigang Luo
2021-06-03 15:11 ` Liu, Shaoyun
2021-06-03 14:13 ` [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf Zhigang Luo
2021-06-03 15:12 ` Liu, Shaoyun
2021-06-03 15:31 ` Luo, Zhigang
2021-06-07 13:51 ` Zhang, Hawking
2021-06-07 13:59 ` Luo, Zhigang
2021-06-03 14:13 ` [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for " Zhigang Luo
2021-06-03 15:14 ` Liu, Shaoyun
2021-06-03 15:47 ` Luo, Zhigang
2021-06-03 16:43 ` Liu, Shaoyun [this message]
2021-06-03 15:09 ` [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location Liu, Shaoyun
2021-06-04 1:13 ` Deng, Emily
2021-06-04 11:14 ` Christian König
2021-06-04 13:23 ` Luo, Zhigang
2021-06-04 13:46 ` Christian König
2021-06-04 14:06 ` Luo, Zhigang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB55344C9909B4490FE2C5AE94F43C9@DM6PR12MB5534.namprd12.prod.outlook.com \
--to=shaoyun.liu@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Zhigang.Luo@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.